Skip to contentSkip to conversation

driver location for platform-specific drivers

DISCUSSION John Hesterberg 4 participants 4 messages Feb 11, 2002 – Feb 12, 2002

lore
Share & tools
lore
#0 lore raw

Linus & Marcelo,

For SGI's upcoming Linux platform (nicknamed Scalable Node, or SN), we have some platform specific device drivers. Where should these go? I see several precedents in the current kernels.

1) Integrate in drivers/*.
Integrate SN drivers into appropriate directories. Put them directly in char, net, misc, etc., as appropriate.

2) Company (sgi) directory.
There is already an sgi directory, strangely enough. I *think* this was meant to be a platform directory for the discontinued SGI 320/540 Visual Workstations. However, maybe it was intended to be a new precedent of company specific directories. In this case, we'd probably create a platform directory under the company directory, so there would likely be drivers/sgi/sn (some of our SN drivers are here today in our internal development tree). However, there is no other precedent for "company" subdirectories under drivers. Apple didn't do it. IBM didn't do it. HP hasn't done it. Was the drivers/sgi directory really intended to start a new precedent of company specific directories under drivers?

3) New platform directory.
Create a platform directory for SN, probably drivers/sn. There is precedence for this with the drivers/macintosh and drivers/s390. Also, as noted, the SGI Visual Workstation drivers are in drivers/sgi. In this case, it might also make sense to rename drivers/sgi to drivers/visws to indicate these are drivers for the Visual Workstation platform, and not generic SGI drivers.

4) New architecture directory.
Another suggestion is to create an architecture directory, in this case drivers/ia64/{char,net,etc.}/.

I'm happy with whatever you'll accept. To give you something to either agree with or shoot down, I'll suggest #3. SGI's Scalable Node product will be different enough, with enough platform specific drivers, that it justifies it's own subdirectory, and that this should be called drivers/sn.

John Hesterberg
[email protected]

#1 lore raw
Quoted 3 lines · John Hesterberg

3) New platform directory.
Create a platform directory for SN, probably drivers/sn. There is precedence for this with the drivers/macintosh

Being a PPC person, I sometimes wonder if this wsn't a horrible idea sometimes. Much of whats in thereshould be in a 'drivers/adb' or so, ince it's all specific to the ADB bus, with the exception of things like 'rtc.c' (which works on all PPC except APUS). Keep in mind other 'macintosh' specific drivers, like network ones, are in drivers/net/.

Wer also have an arch/ppc/{8xx,8260}_io/ directories for other platform-specific drivers, which I want to kill in 2.5.x timeframe.

Quoted 5 lines

I'm happy with whatever you'll accept. To give you something to either agree with or shoot down, I'll suggest #3. SGI's Scalable Node product will be different enough, with enough platform specific drivers, that it justifies it's own subdirectory, and that this should be called drivers/sn.

What excelty are the specific to tho? Are these all for a new bus? If these are just variopus network, io, whatnot drivers, just put them in drivers/whatever.

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

#2 lore raw
In reply to John Hesterberg
Quoted 11 lines · John Hesterberg

For SGI's upcoming Linux platform (nicknamed Scalable Node, or SN), we have some platform specific device drivers. Where should these go? I see several precedents in the current kernels.

[...]

2) Company (sgi) directory.
There is already an sgi directory, strangely enough. I *think* this was meant to be a platform directory for the discontinued SGI 320/540 Visual Workstations. However, maybe

You are mistaken. The cruft in drivers/sgi mostly dates back to the attempts on the SGI Indy platform to get SGI's IRIX X server *binary* running under Linux (note that this work was NOT done by SGI).

The SGI Visual Workstation work was mostly done within the i386 arch code; the framebuffer driver (sgivwfb.[ch]) was put in drivers/video; and some other drivers had some modifications that were guarded by CONFIG_VISWS or CONFIG_VISWS_HACKS. (There was also a project that enabled multi-process accelerated/direct-rendered graphics on that platform, but that code was never released due to the fact that the project was killed the week it was demonstrated at SIGGRAPH'99.)

--macko

#3 lore raw
In reply to John Hesterberg
Quoted 4 lines · John Hesterberg

For SGI's upcoming Linux platform (nicknamed Scalable Node, or SN), we have some platform specific device drivers. Where should these go? I see several precedents in the current kernels.

If they are equivalent to a new bus, make a new platform directory under drivers, is my vote.

However, if they are likely to eventually spread out (ie they are really PCI-based, and just your own private chips, and they might end up as part of some other sgi platform), spread them out as normal drivers.

Linus