Skip to contentSkip to conversation

2.5.4 sound module problem

PATCH Albert Cranford 6 participants 9 messages Feb 13, 2002

lore
Share & tools
lore
#0 lore raw

Not sure if this was the same message I received. but here is the patch I used to get around my sound problem in 2.5.4.
Linus, please apply to 2.5.5 pre1
Later,
Albert

drivers/sound/dmabuf.c Tue Feb 12 10:15:06 2002 renamed from drivers/sound/dmabuf.c.orig Tue Feb 12 10:12:59 2002 +1 -1
@@ -113,7 +113,7 @@
                }
        }
        dmap->raw_buf = start_addr;
-       dmap->raw_buf_phys = virt_to_bus(start_addr);
+       dmap->raw_buf_phys = isa_virt_to_bus(start_addr);
 
        for (page = virt_to_page(start_addr); page <= virt_to_page(end_addr); page++)
                mem_map_reserve(page);
Signature · 2 lines
Albert Cranford Deerfield Beach FL USA
[email protected]
#1 lore raw

From: Albert Cranford <[email protected]>
Date: Tue, 12 Feb 2002 22:51:35 -0500

Not sure if this was the same message I received. but here is the patch I used to get around my sound problem in 2.5.4.
Linus, please apply to 2.5.5 pre1

Umm, I don't it is safe to assume that only ISA sound drivers end up making use of this code. I would like you to prove that before submitting this change.

#2 lore raw
Quoted 3 lines

Umm, I don't it is safe to assume that only ISA sound drivers end up making use of this code. I would like you to prove that before submitting this change.

There are PCI drivers using the old sound code. Whether it matters is a more complicated question as these devices use ISA DMA emulation or their own pseudo DMA functionality.

Alan

#3 lore raw

From: Alan Cox <[email protected]>
Date: Wed, 13 Feb 2002 09:26:32 +0000 (GMT)

There are PCI drivers using the old sound code. Whether it matters is a more complicated question as these devices use ISA DMA emulation or their own pseudo DMA functionality.

The sound layer PCI DMA stuff like a nice project for some kernel janitors :-))

#4 lore raw
Quoted 6 lines

There are PCI drivers using the old sound code. Whether it matters is a more complicated question as these devices use ISA DMA emulation or their own pseudo DMA functionality.

The sound layer PCI DMA stuff like a nice project for some kernel janitors :-))

Waste of effort. ALSA will replace the OSS code anyway

#5 lore raw
Quoted 2 lines · Alan Cox

Waste of effort. ALSA will replace the OSS code anyway

In fact, in my tree it right now has replaced it. I'll make a pre-patch and try to get the BK tree pushed out.

Linus

#6 lore raw
In reply to Alan Cox
Quoted 8 lines · Alan Cox
Quoted 6 lines

There are PCI drivers using the old sound code. Whether it matters is
a more complicated question as these devices use ISA DMA emulation or their own pseudo DMA functionality.

The sound layer PCI DMA stuff like a nice project for some kernel janitors :-))

Waste of effort. ALSA will replace the OSS code anyway

When I looked at the code, it looked like a lot more than just the sound code needed to be fixed. I will look at the next patch and see what is left.

#7 lore raw
In reply to David S. Miller
Quoted 9 lines · David S. Miller

From: Alan Cox <[email protected]>
Date: Wed, 13 Feb 2002 09:26:32 +0000 (GMT)

There are PCI drivers using the old sound code. Whether it matters is a more complicated question as these devices use ISA DMA emulation or their own pseudo DMA functionality.

The sound layer PCI DMA stuff like a nice project for some kernel janitors :-))

Not worth, IMO.

Machines that give us fun support the legacy virt_to_bus() semantic. Those that require the PCI DMA abstraction are so boring than adding sound will probably not improve user pleasure significantly.

:-)) (this smiley is just to prevent from too much flaming ;-)

Gérard.

#8 lore raw
In reply to Albert Cranford
Quoted 3 lines · Albert Cranford

Not sure if this was the same message I received. but here is the patch I used to get around my sound problem in 2.5.4.

Are you sure this is correct? include/asm/io.h seems to indicate that i/o addresses for PCI may not map correctly. The sound card I am using is PCI, not ISA.

Documentation/DMA-mapping.txt says that virt_to_bus is completly depreciated and nothing should be using it. Well, grepping the kernel source shows that quite a bit still uses it.

What it looks like, on first glance, is that virt_to_bus was changed for pci devices to give this error message. (Since that symbol goes nowhere.) That effects a number of things, not just sound. (A whole bunch of cardbus drivers I would guess...)

When was this change made? It appears as if they missed a few bits.

Comment: 2.5.4 has been more than a bit rough. Rarely do i see more than one patch needed just to get it to compile. Not trying to be bitchy about it. Just a wee bit frustrated...

Quoted 14 lines

Linus, please apply to 2.5.5 pre1
Later,
Albert

drivers/sound/dmabuf.c Tue Feb 12 10:15:06 2002 renamed from drivers/sound/dmabuf.c.orig Tue Feb 12 10:12:59 2002 +1 -1
@@ -113,7 +113,7 @@
                }
        }
        dmap->raw_buf = start_addr;
-       dmap->raw_buf_phys = virt_to_bus(start_addr);
+       dmap->raw_buf_phys = isa_virt_to_bus(start_addr);
 
        for (page = virt_to_page(start_addr); page <=
 virt_to_page(end_addr); page++) mem_map_reserve(page);