Skip to contentSkip to conversation

Linux 2.4.19-pre3-ac5

PATCH New [email protected] 5 participants 6 messages Mar 21, 2002 – Mar 22, 2002

lore
Share & tools
lore

[email protected]

author
#0 lore raw
Quoted 3 lines

stuff. If you want a peaceful life and a production -ac system please stick at 2.4.18-ac3 or 2.4.19pre3-ac4. IDE and large NFS changes do not in general make for stability first time around.

No complaints. Maybe this ksymoops output is helpful.

Oops occured at boot time:

VP_IDE: VIA vt82c586b (rev 47) IDE UDMA33 controller on pci00:07.1

    ide0: BM-DMA at 0xe000-0xe007, BIOS settings: hda:DMA, hdb:DMA
    ide1: BM-DMA at 0xe008-0xe00f, BIOS settings: hdc:DMA, hdd:DMA

hda: Maxtor 51536U3, ATA DISK drive
hdb: ATAPI CDROM, ATAPI CD/DVD-ROM drive
hdc: Maxtor 52049U4, ATA DISK drive
ide0 at 0x1f0-0x1f7,0x3f6 on irq 14
ide1 at 0x170-0x177,0x376 on irq 15
hda: 30015216 sectors (15368 MB) w/2048KiB Cache, CHS=1868/255/63, UDMA(33)
hdc: 40020624 sectors (20491 MB) w/2048KiB Cache, CHS=39703/16/63, UDMA(33) kernel BUG at ide-cd.c:790!
invalid operand: 0000

ksymoops output:

Code: 0f 0b 16 03 62 32 23 c0 68 9c 27 1c c0 56 ff 74 24 28 53 e8
 <0>Kernel panic: Attempted to kill init!
kernel BUG at ide-cd.c:790!
invalid operand: 0000
CPU:    0
EIP:    0010:[<c01c29c1>]    Not tainted

Using defaults from ksymoops -t elf32-i386 -a i386
EFLAGS: 00010246
eax: c151b160 ebx: c02b054c ecx: 0880bf37 edx: 000001f7
esi: 000001f4 edi: c151deac ebp: c01c348c esp: c151dccc
ds: 0018 es: 0018 ss: 0018
Process swapper (pid: 1, stackpage=c151d000)

Stack: c02b054c d7f36c00 00000000 c01c348c 00803272 c01c34b8 c02b054c c151de94
       c01c32c0 c01c2915 c02b054c c02b054c d7f36c00 c151dde4 00000000 00000190
       c01c34fe c02b054c 00000018 c01c348c c01c3a38 c02b054c 00000000 c02b054c
Call Trace: [<c01c348c>] [<c01c34b8>] [<c01c32c0>] [<c01c2915>] [<c01c34fe>]
   [<c01c348c>] [<c01c3a38>] [<c01b8096>] [<c01b83b7>] [<c01b897a>] [<c01c3573>]
   [<c0107e1c>] [<c01bc421>] [<c01c43db>] [<c01c716e>] [<c01c4acb>] [<c01c4b3b>]
   [<c01c546c>] [<c01c5934>] [<c0105023>] [<c01054dc>]
Code: 0f 0b 16 03 62 32 23 c0 68 9c 27 1c c0 56 ff 74 24 28 53 e8
Quoted 8 lines
Quoted 8 lines

EIP; c01c29c1 <cdrom_transfer_packet_command+71/a0> <=====

eax; c151b160 <END_OF_CODE+1265ae4/????>
ebx; c02b054c <ide_hwifs+18c/2198>
ecx; 0880bf37 Before first symbol
edi; c151deac <END_OF_CODE+1268830/????>
ebp; c01c348c <cdrom_do_pc_continuation+0/30>
esp; c151dccc <END_OF_CODE+1268650/????>

Trace; c01c348c <cdrom_do_pc_continuation+0/30> Trace; c01c34b8 <cdrom_do_pc_continuation+2c/30> Trace; c01c32c0 <cdrom_pc_intr+0/1cc>
Trace; c01c2915 <cdrom_start_packet_command+141/17c> Trace; c01c34fe <cdrom_do_packet_command+42/48> Trace; c01c348c <cdrom_do_pc_continuation+0/30> Trace; c01c3a38 <ide_do_rw_cdrom+108/144> Trace; c01b8096 <start_request+1a6/20c> Trace; c01b83b7 <ide_do_request+283/2d0> Trace; c01b897a <ide_do_drive_cmd+ea/11c> Trace; c01c3573 <cdrom_queue_packet_command+4f/b0> Trace; c0107e1c <handle_IRQ_event+34/60> Trace; c01bc421 <ide_timing_compute+b5/164> Trace; c01c43db <ide_cdrom_packet+6b/78> Trace; c01c716e <cdrom_mode_sense+5a/64> Trace; c01c4acb <ide_cdrom_get_capabilities+9f/b4> Trace; c01c4b3b <ide_cdrom_probe_capabilities+5b/43c> Trace; c01c546c <ide_cdrom_setup+468/4e8> Trace; c01c5934 <ide_cdrom_init+e0/17c> Trace; c0105023 <init+7/114>
Trace; c01054dc <kernel_thread+28/38>

Code; c01c29c1 <cdrom_transfer_packet_command+71/a0> 00000000 <_EIP>:
Code; c01c29c1 <cdrom_transfer_packet_command+71/a0> <=====
0: 0f 0b ud2a <=====
Code; c01c29c3 <cdrom_transfer_packet_command+73/a0>
2: 16 push %ss
Code; c01c29c4 <cdrom_transfer_packet_command+74/a0>
3: 03 62 32 add 0x32(%edx),%esp
Code; c01c29c7 <cdrom_transfer_packet_command+77/a0>
6: 23 c0 and %eax,%eax
Code; c01c29c9 <cdrom_transfer_packet_command+79/a0>
8: 68 9c 27 1c c0 push $0xc01c279c
Code; c01c29ce <cdrom_transfer_packet_command+7e/a0>
d: 56 push %esi
Code; c01c29cf <cdrom_transfer_packet_command+7f/a0>
e: ff 74 24 28 pushl 0x28(%esp,1)
Code; c01c29d3 <cdrom_transfer_packet_command+83/a0>
12: 53 push %ebx
Code; c01c29d4 <cdrom_transfer_packet_command+84/a0>
13: e8 00 00 00 00 call 18 <_EIP+0x18> c01c29d9 <cdrom_transfer_packet_command+89/a0>

<0>Kernel panic: Attempted to kill init!

The .config worked with 2.4.19-pre3-ac1.
config and lspci -vv output at:
http://home.earthlink.net/~rwhron/kernel/config/config-2.4.19-pre3-ac5
http://home.earthlink.net/~rwhron/kernel/config/lspci

Signature · 1 line
Randy Hron
#1 lore raw

----- Original Message -----
From: <[email protected]>
To: <[email protected]>
Sent: Thursday, March 21, 2002 6:08 PM
Subject: Re: Linux 2.4.19-pre3-ac5

Quoted 7 lines
Quoted 3 lines

stuff. If you want a peaceful life and a production -ac system please stick at 2.4.18-ac3 or 2.4.19pre3-ac4. IDE and large NFS changes do not in general make for stability first time around.

No complaints. Maybe this ksymoops output is helpful.

Oops occured at boot time:

<snip>

Me Too (tm).

Same BUG, similar oops trace, different hardware (SMP PPro, 440FX chipset). Here it is in case it's useful:

ksymoops 2.4.1 on i686 2.4.19-pre3-ac4. Options used

     -v /usr/src/linux-2.4.19-pre3-ac5/vmlinux (specified)
     -K (specified)
     -L (specified)
     -O (specified)
     -m /usr/src/linux-2.4.19-pre3-ac5/System.map (specified)

kernel BUG at ide-cd.c:790!

invalid operand: 0000
CPU:    1
EIP:    0010:[<c0237e5f>]    Not tainted

Using defaults from ksymoops -t elf32-i386 -a i386
EFLAGS: 00010246
eax: 00000000 ebx: c03d8c28 ecx: 00000064 edx: 00000177
esi: 000001f4 edi: c12f1e84 ebp: 00000000 esp: c12f1cb4
ds: 0018 es: 0018 ss: 0018
Process swapper (pid: 1, stackpage=c12f1000)

Stack: 0080c8dc 00000000 00000000 c1369a00 c03d8c28 c02389dd c03d8c28 c12f1e6c
       c02387d0 c0237de4 c03d8c28 00000064 00000000 c03d8c28 00000040 c12f1dac
       c0238a33 c03d8c28 00000018 c02389b0 c022d647 c03d8c28 c12f1dac 00000000
Call Trace: [<c02389dd>] [<c02387d0>] [<c0237de4>] [<c0238a33>] [<c02389b0>]
   [<c022d647>] [<c022d99c>] [<c022e03a>] [<c0238acf>] [<c01157a1>] [<c0239992>]
   [<c0265c5d>] [<c023a11b>] [<c023a18b>] [<c0140feb>] [<c023aaa6>] [<c023af99>]
   [<c0105000>] [<c0105068>] [<c0105000>] [<c0105696>] [<c0105040>]
Code: 0f 0b 16 03 9d 87 2f c0 68 50 7c 23 c0 56 8b 74 24 28 56 53
Quoted 1 line
Quoted 1 line

EIP; c0237e5f <cdrom_transfer_packet_command+6f/a0> <=====

Trace; c02389dd <cdrom_do_pc_continuation+2d/40> Trace; c02387d0 <cdrom_pc_intr+0/1e0>
Trace; c0237de4 <cdrom_start_packet_command+154/160> Trace; c0238a33 <cdrom_do_packet_command+43/50> Trace; c02389b0 <cdrom_do_pc_continuation+0/40> Trace; c022d647 <start_request+197/200> Trace; c022d99c <ide_do_request+29c/2f0> Trace; c022e03a <ide_do_drive_cmd+fa/130> Trace; c0238acf <cdrom_queue_packet_command+4f/b0> Trace; c01157a1 <wait_for_completion+91/c0> Trace; c0239992 <ide_cdrom_packet+72/80> Trace; c0265c5d <cdrom_mode_sense+4d/60> Trace; c023a11b <ide_cdrom_get_capabilities+9b/b0> Trace; c023a18b <ide_cdrom_probe_capabilities+5b/420> Trace; c0140feb <bdput+8b/a0>
Trace; c023aaa6 <ide_cdrom_setup+466/4f0> Trace; c023af99 <ide_cdrom_init+e9/17f> Trace; c0105000 <_stext+0/0>
Trace; c0105068 <init+28/190>
Trace; c0105000 <_stext+0/0>
Trace; c0105696 <kernel_thread+26/30>
Trace; c0105040 <init+0/190>
Code; c0237e5f <cdrom_transfer_packet_command+6f/a0> 00000000 <_EIP>:
Code; c0237e5f <cdrom_transfer_packet_command+6f/a0> <=====
0: 0f 0b ud2a <=====
Code; c0237e61 <cdrom_transfer_packet_command+71/a0>
2: 16 push %ss
Code; c0237e62 <cdrom_transfer_packet_command+72/a0>
3: 03 9d 87 2f c0 68 add 0x68c02f87(%ebp),%ebx
Code; c0237e68 <cdrom_transfer_packet_command+78/a0>
9: 50 push %eax
Code; c0237e69 <cdrom_transfer_packet_command+79/a0>
a: 7c 23 jl 2f <_EIP+0x2f> c0237e8e
<cdrom_transfer_packet_command+9e/a0>
Code; c0237e6b <cdrom_transfer_packet_command+7b/a0>
c: c0 56 8b 74 rclb $0x74,0xffffff8b(%esi)
Code; c0237e6f <cdrom_transfer_packet_command+7f/a0>
10: 24 28 and $0x28,%al
Code; c0237e71 <cdrom_transfer_packet_command+81/a0>
12: 56 push %esi
Code; c0237e72 <cdrom_transfer_packet_command+82/a0>
13: 53 push %ebx

--Adam

#2 lore raw

Hi!

Quoted 2 lines

kernel BUG at ide-cd.c:790!
invalid operand: 0000

The code appears to be too paranoid here. In case noone else submitted a patch yet, here is mine.
Apply with patch -p0.

Jörn

Signature · 15 lines
Measure. Don't tune for speed until you've measured, and even then
don't unless one part of the code overwhelms the rest.
-- Rob Pike

--- drivers/ide/ide-cd.c	Fri Mar 22 09:48:42 2002
+++ drivers/ide/ide-cd.c.new	Fri Mar 22 09:52:59 2002
@@ -786,9 +786,6 @@
 			return startstop;
 	}
 
-	if (HWGROUP(drive)->handler == NULL)	/* paranoia check */
-		BUG();
-
 	/* Arm the interrupt handler. */
 	ide_set_handler (drive, handler, timeout, cdrom_timer_expiry);
#3 lore raw
Quoted 3 lines · Jörn Engel

The code appears to be too paranoid here. In case noone else submitted a patch yet, here is mine.
Apply with patch -p0.

Actually that exact problem is present in 2.5 as well without the BUG check, "handler not null, timer being added twice blah blah..." there really is a problem.

Zwane

#4 lore raw

PATCH 1/1 ide-cd-typo.patch (Re: Linux 2.4.19-pre3-ac5)

In reply to Jörn Engel

Goto Line 790 in ide-cd.c and manually edit it.

But since you asked for a patch here is one.

Cheers,

Andre Hedrick
LAD Storage Consulting Group

Quoted 29 lines · Jörn Engel

Hi!

Quoted 2 lines

kernel BUG at ide-cd.c:790!
invalid operand: 0000

The code appears to be too paranoid here. In case noone else submitted a patch yet, here is mine.
Apply with patch -p0.

Jörn

Signature · 3 lines
Measure. Don't tune for speed until you've measured, and even then
don't unless one part of the code overwhelms the rest.
-- Rob Pike
ide/ide-cd.c.new renamed from ide/ide-cd.c +0 -4
@@ -786,9 +786,6 @@
 			return startstop;
 	}
 
-	if (HWGROUP(drive)->handler == NULL)	/* paranoia check */
-		BUG();
-
 	/* Arm the interrupt handler. */
 	ide_set_handler (drive, handler, timeout, cdrom_timer_expiry);
 
-
Quoted 5 lines

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

drivers/ide/ide-cd.c renamed from drivers/ide/ide-cd.c.orig +1 -1
@@ -786,7 +786,7 @@
 			return startstop;
 	}
 
-	if (HWGROUP(drive)->handler == NULL)	/* paranoia check */
+	if (HWGROUP(drive)->handler != NULL)	/* paranoia check */
 		BUG();
 
 	/* Arm the interrupt handler. */
#5 lore raw

Re: [PATCH] ide-cd-typo.patch (Re: Linux 2.4.19-pre3-ac5)

In reply to Jörn Engel

Review

Quoted 9 lines · Andre Hedrick

Goto Line 790 in ide-cd.c and manually edit it.

But since you asked for a patch here is one.

[...]

(quoted diff) +1 -1
-	if (HWGROUP(drive)->handler == NULL)	/* paranoia check */
+	if (HWGROUP(drive)->handler != NULL)	/* paranoia check */
 		BUG();

Makes more sense. Thank you!

Jörn

Signature · 4 lines
Highly skilled employees are always promoted to a level of
incompetency. They get promoted for doing a good job, until they
don't.
-- unknown