Fix console initialization deadlock for x86-64

PATCH New Andi Kleen 1 participant 1 message Apr 20, 2002 Char and misc drivers

Share & tools

Andi Kleen

author

2002-04-20 16:37 UTC #0 lore raw

PATCH 1/1 Fix console initialization deadlock for x86-64

When vt_init happens to run before the keyboard is initialized (the order is random because they're both different initcalls) then set_leds raises an not yet enabled tasklet. This causes an endless loop on the first schedule() call because the tasklet handling cannot handle raised but disabled tasklets.

This patch just does not do set_leds in virtual terminal initialization to avoid that. It is done later anyways.

Patch for 2.5.8

-Andi

drivers/char/console.c renamed from ../v2.5/linux/drivers/char/console.c +2 -1

diff -X ../../KDIFX -x *-o -x *-RESERVE -burpN ../../v2.5/linux/drivers/char/console.c linux/drivers/char/console.c
@@ -1420,7 +1420,8 @@ static void reset_terminal(int currcons,
 	kbd_table[currcons].slockstate = 0;
 	kbd_table[currcons].ledmode = LED_SHOW_FLAGS;
 	kbd_table[currcons].ledflagstate = kbd_table[currcons].default_ledflagstate;
-	set_leds();
+	/* do not do set_leds here because this causes an endless tasklet loop
+	   when the keyboard hasn't been initialized yet */
 
 	cursor_type = CUR_DEFAULT;
 	complement_mask = s_complement_mask;