fs/fat: printk cleanup
PATCH 1/1 fs/fat: printk cleanup
Attached patch adds proper printk levels into the FAT filesystem driver.
Signature · 2 lines
Andrey Panin | Embedded systems software engineer [email protected] | PGP key: wwwkeys.eu.pgp.net
fs/fat/cache.c +4 -4
@@ -52,7 +52,7 @@ } b =MSDOS_SB (sb)->fat_start + (first >> sb->s_blocksize_bits);if (!(bh =fat_bread (sb, b))) { -printk ("bread in fat_access failed\n" ); +printk (KERN_ERR "bread in fat_access failed\n" );return 0 ; }if ((first >> sb->s_blocksize_bits) == (last >> sb->s_blocksize_bits)) {
@@ -60,7 +60,7 @@ }else {if (!(bh2 =fat_bread (sb, b+1 ))) {fat_brelse (sb, bh); -printk ("2nd bread in fat_access failed\n" ); +printk (KERN_ERR "2nd bread in fat_access failed\n" );return 0 ; } }
@@ -208,7 +208,7 @@ && walk->start_cluster == first && walk->file_cluster == f_clu) {if (walk->disk_cluster != d_clu) { -printk ("FAT cache corruption inode=%ld\n" , +printk (KERN_ERR "FAT cache corruption inode=%ld\n" , inode->i_ino);spin_unlock (&fat_cache_lock);fat_cache_inval_inode (inode);
@@ -327,7 +327,7 @@ last = nr;if ((nr =fat_access (inode->i_sb,nr,-1 )) ==-1 )return 0 ;if (!nr) { -printk ("fat_free: skipped EOF\n" ); +printk (KERN_ERR "fat_free: skipped EOF\n" );return -EIO ; } }
fs/fat/inode.c +23 -23
179 lines not on this page · raw message
fs/fat/misc.c +8 -8
@@ -48,10 +48,10 @@if (not_ro) s->s_flags |=MS_RDONLY ; -printk ("FAT: Filesystem panic (dev %s)\n" +printk (KERN_ERR "FAT: Filesystem panic (dev %s)\n" " %s\n" , s->s_id, panic_msg);if (not_ro) -printk (" File system has been set read-only\n" ); +printk (KERN_ERR " File system has been set read-only\n" ); }
@@ -74,7 +74,7 @@if (!strncmp (extension,walk,3 ))return 0 ;return 1 ;/* default binary conversion */ default : -printk ("Invalid conversion mode - defaulting to " +printk (KERN_WARNING "Invalid conversion mode - defaulting to " "binary.\n" );return 1 ; }
@@ -99,14 +99,14 @@ bh =fat_bread (sb,MSDOS_SB (sb)->fsinfo_sector);if (bh ==NULL ) { -printk ("FAT bread failed in fat_clusters_flush\n" ); +printk (KERN_ERR "FAT bread failed in fat_clusters_flush\n" );return ; } fsinfo = (struct fat_boot_fsinfo *)bh->b_data;/* Sanity check */ if (!IS_FSINFO (fsinfo)) { - printk("FAT: Did not find valid FSINFO signature.\n" + printk(KERN_ERR "FAT: Did not find valid FSINFO signature.\n" " Found signature1 0x%08x signature2 0x%08x" " (sector = %lu)\n", CF_LE_L(fsinfo->signature1), CF_LE_L(fsinfo->signature2),
@@ -194,7 +194,7 @@mark_inode_dirty (inode); }if (file_cluster != (inode->i_blocks >> (cluster_bits -9 ))) { -printk ("file_cluster badly computed!!! %d <> %ld\n" , +printk (KERN_ERR "file_cluster badly computed!!! %d <> %ld\n" , file_cluster, inode->i_blocks >> (cluster_bits -9 ));fat_cache_inval_inode (inode); }
@@ -228,7 +228,7 @@ }else {for ( ; sector < last_sector; sector++) {if (!(bh =fat_getblk (sb, sector))) -printk ("FAT: fat_getblk() failed\n" ); +printk (KERN_ERR "FAT: fat_getblk() failed\n" );else {memset (bh->b_data,0 , sb->s_blocksize);fat_set_uptodate (sb, bh,1 );
@@ -346,7 +346,7 @@return -1 ;/* beyond EOF */ *pos +=sizeof (struct msdos_dir_entry );if (!(*bh =fat_bread (sb, sector))) { -printk ("Directory sread (sector 0x%x) failed\n" ,sector); +printk (KERN_ERR "Directory sread (sector 0x%x) failed\n" ,sector);continue ; }PRINTK (("get_entry apres sread\n" ));