Skip to contentSkip to conversation

AMD PowerNow booboo in 2.4.19-pre7-ac3

PATCH CaT 5 participants 6 messages May 2, 2002

lore
Share & tools
lore

CaT

author
#0 lore raw
i386/kernel/amdk6plus.c Thu May 2 18:51:17 2002 renamed from i386/kernel/amdk6plus.c.old Thu May 2 18:51:13 2002 +1 -1
@@ -117,4 +117,4 @@
 MODULE_LICENSE ("GPL");
 module_init(PowerNow_k6plus_init);
 module_exit(PowerNow_k6plus_exit);
-__initcall (PowerNOW_k6plus_init);
+__initcall (PowerNow_k6plus_init);
Signature · 5 lines
CORUSCANT-Presiding over a memorial service commemorating the victims
of the attack on the Death Star, the Emperor declared that while recent
victories over the Rebel Alliance were "encouraging, the War on Terror
is not over yet."
	- http://www.zip.com.au/~cat/misc/txt/waronterror.txt
#1 lore raw

i386/kernel/amdk6plus.c Thu May 2 18:51:17 2002 line 120

Quoted 9 lines · CaT
i386/kernel/amdk6plus.c Thu May 2 18:51:17 2002 renamed from i386/kernel/amdk6plus.c.old Thu May 2 18:51:13 2002 +1 -1
@@ -117,4 +117,4 @@
 MODULE_LICENSE ("GPL");
 module_init(PowerNow_k6plus_init);
 module_exit(PowerNow_k6plus_exit);
-__initcall (PowerNOW_k6plus_init);
+__initcall (PowerNow_k6plus_init);

Hmm, that looks really odd - module_init() should be identical to __initcall when built into the kernel. Copied to the cpufreq list.

Signature · 2 lines
Russell King ([email protected])                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html
#2 lore raw

SANDEEP DEY,
ROOM NO.308,
HALL 3,
IIT KANPUR,
KANPUR 208016.

"I am a slow walker but i do not walk backwards."
Abraham Lincoln....

Quoted 25 lines · Russell King

i386/kernel/amdk6plus.c Thu May 2 18:51:17 2002 line 120

Quoted 9 lines · CaT
i386/kernel/amdk6plus.c Thu May 2 18:51:17 2002 renamed from i386/kernel/amdk6plus.c.old Thu May 2 18:51:13 2002 +1 -1
@@ -117,4 +117,4 @@
 MODULE_LICENSE ("GPL");
 module_init(PowerNow_k6plus_init);
 module_exit(PowerNow_k6plus_exit);
-__initcall (PowerNOW_k6plus_init);
+__initcall (PowerNow_k6plus_init);

Hmm, that looks really odd - module_init() should be identical to __initcall when built into the kernel. Copied to the cpufreq list.

Signature · 8 lines
Russell King ([email protected])                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
author
#3 lore raw
In reply to CaT
Quoted 12 lines · Russell King

i386/kernel/amdk6plus.c Thu May 2 18:51:17 2002 line 120

Quoted 8 lines · CaT
i386/kernel/amdk6plus.c Thu May 2 18:51:17 2002 renamed from i386/kernel/amdk6plus.c.old Thu May 2 18:51:13 2002 +1 -1
@@ -117,4 +117,4 @@
 MODULE_LICENSE ("GPL");
 module_init(PowerNow_k6plus_init);
 module_exit(PowerNow_k6plus_exit);
-__initcall (PowerNOW_k6plus_init);
+__initcall (PowerNow_k6plus_init);

Hmm, that looks really odd - module_init() should be identical to __initcall when built into the kernel. Copied to the cpufreq list.

I did a test make bzlilo to continue compiling and that -seemed- to work but I probably did something wrong as it bombed out with a 'duplicate definition' (from memory) so I removed the __initcall and it compiled fine this time.

Signature · 5 lines
CORUSCANT-Presiding over a memorial service commemorating the victims
of the attack on the Death Star, the Emperor declared that while recent
victories over the Rebel Alliance were "encouraging, the War on Terror
is not over yet."
	- http://www.zip.com.au/~cat/misc/txt/waronterror.txt
#4 lore raw
In reply to CaT
Quoted 8 lines · Russell King

i386/kernel/amdk6plus.c Thu May 2 18:51:17 2002 line 120

Quoted 6 lines

MODULE_LICENSE ("GPL");
module_init(PowerNow_k6plus_init);
module_exit(PowerNow_k6plus_exit);

i386/kernel/amdk6plus.c Thu May 2 18:51:17 2002 renamed from i386/kernel/amdk6plus.c.old Thu May 2 18:51:13 2002 +1 -1
-__initcall (PowerNOW_k6plus_init);
+__initcall (PowerNow_k6plus_init);

Hmm, that looks really odd - module_init() should be identical to __initcall when built into the kernel. Copied to the cpufreq list.

Odd, Alan must have merged an old version of the cvs tree, as the initcalls were nuked a long time ago there iirc. They're certainly not in my copy of the current tree

Signature · 2 lines
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs
#5 lore raw
Quoted 3 lines

Odd, Alan must have merged an old version of the cvs tree, as the initcalls were nuked a long time ago there iirc. They're certainly not in my copy of the current tree

I merged head at the time of the merge, and told you about the initcalls when I merged them 8). It does need updating especially now spudstop support is in