Skip to contentSkip to conversation

About integer64

DISCUSSION Jaroslav Kysela 3 participants 3 messages May 9, 2002 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 12 lines · Paul Davis
Quoted 6 lines

I don't think that's a bad thing to have support for 64 bit integers (perhaps for future use, who knows), but I think that to use this to store a fixed point float is a big mistake.

If you think for it you realize that it's *not* an integer and applications are betrayed in their expectation.

in this case, it *is* an integer. your original question was about why its 64 bits - i think that comes from the fixed point internal arithmetic. but the end result is a straightforward 64 bit little endian integer that needs scaling to get the actual RMS value.

Quoted 6 lines

which actually creates another problem that i've noticed with the control API. INTEGER and INTEGER64 assume that the control value is signed. there is no way to infer from the control element info that its unsigned. this isn't a "deep" problem, but it will mess up user interfaces that present a large unsigned value and end up displaying it as a negative number.

I think that we can add 'int unsign: 1;' to sndrv_ctl_elem_info for integer and integer64. Any objections?

Jaroslav

-----
Jaroslav Kysela <[email protected]>
Linux Kernel Sound Maintainer
ALSA Project http://www.alsa-project.org
SuSE Linux http://www.suse.com

_______________________________________________________________

Have big pipes? SourceForge.net is looking for download mirrors. We supply the hardware. You get the recognition. Email Us: [email protected]

#2 lore raw
Quoted 22 lines · Jaroslav Kysela
Quoted 12 lines · Paul Davis
Quoted 6 lines

I don't think that's a bad thing to have support for 64 bit integers (perhaps for future use, who knows), but I think that to use this to store a fixed point float is a big mistake.

If you think for it you realize that it's *not* an integer and applications are betrayed in their expectation.

in this case, it *is* an integer. your original question was about why its 64 bits - i think that comes from the fixed point internal arithmetic. but the end result is a straightforward 64 bit little endian integer that needs scaling to get the actual RMS value.

Quoted 6 lines

which actually creates another problem that i've noticed with the control API. INTEGER and INTEGER64 assume that the control value is signed. there is no way to infer from the control element info that its unsigned. this isn't a "deep" problem, but it will mess up user interfaces that present a large unsigned value and end up displaying it as a negative number.

Quoted 2 lines

I think that we can add 'int unsign: 1;' to sndrv_ctl_elem_info for integer and integer64. Any objections?

I'd avoid that.

About the problem Paul has shown the important thing is to know if all 64 bits are used. This is also the reason why I've asked the original
question: I can't imagine a quantity in audio problem space that need 64 bit of resolution and all the bits are significant and they make a sensible difference.

However also if this is the case I'd prefer to have UINTEGER and/or UINTEGER64.

Signature · 13 lines
Abramo Bagnara                       mailto:[email protected]

Opera Unica                          Phone: +39.546.656023
Via Emilia Interna, 140
48014 Castel Bolognese (RA) - Italy

ALSA project               http://www.alsa-project.org
It sounds good!

_______________________________________________________________

Have big pipes? SourceForge.net is looking for download mirrors. We supply
the hardware. You get the recognition. Email Us: [email protected]
#3 lore raw
Quoted 2 lines

However also if this is the case I'd prefer to have UINTEGER and/or UINTEGER64.

I agree. I would prefer specific types for unsigned controls, not an extra bit to indicate this. imagine:

      switch (control->type) {
      case INTEGER:
           if (control->unsigned) {
	      ...
	   } else {
	      ...
	   }
	   break;

versus:

       switch (control->type) {
       case INTEGER:
           ...
	   break;
       case UINTEGER:
           ...
	   break;

i much prefer the latter.

--p

_______________________________________________________________

Have big pipes? SourceForge.net is looking for download mirrors. We supply the hardware. You get the recognition. Email Us: [email protected]