Skip to contentSkip to conversation

GUS PCM fixes

PATCH In review Ville Syrjälä 2 participants 3 messages May 10, 2002

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 GUS PCM fixes

Here's a fix for gus pcm rate limits and interwave pcm name.

Index: alsa-kernel/isa/gus/gus_pcm.c
===================================================================
RCS file: /cvsroot/alsa/alsa-kernel/isa/gus/gus_pcm.c,v retrieving revision 1.8
diff -u -r1.8 gus_pcm.c
--- alsa-kernel/isa/gus/gus_pcm.c 18 Feb 2002 13:21:15 -0000
1.8
+++ alsa-kernel/isa/gus/gus_pcm.c 10 May 2002 01:13:43 -0000
@@ -38,7 +38,7 @@

/* maximum rate */

-#define SNDRV_GF1_PCM_RATE 48000
+#define SNDRV_GF1_PCM_RATE 44100

#define SNDRV_GF1_PCM_PFLG_NONE 0
#define SNDRV_GF1_PCM_PFLG_ACTIVE (1<<0)
@@ -624,7 +624,7 @@
SNDRV_PCM_FMTBIT_S16_LE |
SNDRV_PCM_FMTBIT_U16_LE),
rates: SNDRV_PCM_RATE_CONTINUOUS |
SNDRV_PCM_RATE_8000_44100,
rate_min: 5510,
- rate_max: 48000,
+ rate_max: 44100,
channels_min: 1,
channels_max: 2,
buffer_bytes_max: (128*1024),
Index: alsa-kernel/isa/gus/interwave.c
===================================================================
RCS file: /cvsroot/alsa/alsa-kernel/isa/gus/interwave.c,v retrieving revision 1.11
diff -u -r1.11 interwave.c
--- alsa-kernel/isa/gus/interwave.c 18 Mar 2002 14:27:50 -0000
1.11
+++ alsa-kernel/isa/gus/interwave.c 10 May 2002 01:13:44 -0000
@@ -805,7 +805,7 @@
return err;
}
sprintf(pcm->name + strlen(pcm->name), " rev %c", gus->revision +
'A');
- strcat(pcm->name, " (chip)");
+ strcat(pcm->name, " (codec)");
if ((err = snd_cs4231_timer(cs4231, 2, NULL)) < 0) {
snd_card_free(card);
return err;

Signature · 8 lines
Ville Syrjälä
[email protected]
http://www.sci.fi/~syrjala/

_______________________________________________________________

Have big pipes? SourceForge.net is looking for download mirrors. We supply
the hardware. You get the recognition. Email Us: [email protected]
#1 lore raw
Quoted 11 lines · On Fri, 10 May 2002, [iso-8859-1] Ville Syrj�l� wrote:

Here's a fix for gus pcm rate limits and interwave pcm name.

Index: alsa-kernel/isa/gus/gus_pcm.c
===================================================================
RCS file: /cvsroot/alsa/alsa-kernel/isa/gus/gus_pcm.c,v retrieving revision 1.8
diff -u -r1.8 gus_pcm.c
--- alsa-kernel/isa/gus/gus_pcm.c 18 Feb 2002 13:21:15 -0000
1.8
+++ alsa-kernel/isa/gus/gus_pcm.c 10 May 2002 01:13:43 -0000

Review line 41

Quoted 5 lines
(quoted diff) +1 -1
@@ -38,7 +38,7 @@
 
 /* maximum rate */
 
-#define SNDRV_GF1_PCM_RATE		48000
+#define SNDRV_GF1_PCM_RATE		44100

There is no reason to limit playback to 44100Hz. Hardware can do frequency shift and interleaving, so although DAC operates at 44100Hz, the 48kHz sound can be played.

Jaroslav

-----
Jaroslav Kysela <[email protected]>
Linux Kernel Sound Maintainer
ALSA Project http://www.alsa-project.org
SuSE Linux http://www.suse.com

_______________________________________________________________

Have big pipes? SourceForge.net is looking for download mirrors. We supply the hardware. You get the recognition. Email Us: [email protected]

#2 lore raw
Quoted 3 lines · Jaroslav Kysela

There is no reason to limit playback to 44100Hz. Hardware can do frequency shift and interleaving, so although DAC operates at 44100Hz, the 48kHz sound can be played.

Ok. Have you taken a look at my other message about my MikMod driver efforts? I've sent at least three messages related to that. I think I've narrowed the problem down to voice allocation problems. I'm beginning to think that you're ignoring me on purpose.

Signature · 8 lines
Ville Syrjälä
[email protected]
http://www.sci.fi/~syrjala/

_______________________________________________________________

Have big pipes? SourceForge.net is looking for download mirrors. We supply
the hardware. You get the recognition. Email Us: [email protected]