Skip to contentSkip to conversation

Interwave PCM name

PATCH In review Ville Syrjälä 2 participants 4 messages May 10, 2002 – May 12, 2002

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Interwave PCM name

I'm resending this since you didn't apply it from my previous patch.

Index: alsa-kernel/isa/gus/interwave.c
===================================================================
RCS file: /cvsroot/alsa/alsa-kernel/isa/gus/interwave.c,v retrieving revision 1.11
diff -u -r1.11 interwave.c
--- alsa-kernel/isa/gus/interwave.c 18 Mar 2002 14:27:50 -0000
1.11
+++ alsa-kernel/isa/gus/interwave.c 10 May 2002 21:44:50 -0000
@@ -805,7 +805,7 @@
return err;
}
sprintf(pcm->name + strlen(pcm->name), " rev %c", gus->revision
+ 'A');
- strcat(pcm->name, " (chip)");
+ strcat(pcm->name, " (codec)");
if ((err = snd_cs4231_timer(cs4231, 2, NULL)) < 0) {
snd_card_free(card);
return err;

Signature · 8 lines
Ville Syrjälä
[email protected]
http://www.sci.fi/~syrjala/

_______________________________________________________________

Have big pipes? SourceForge.net is looking for download mirrors. We supply
the hardware. You get the recognition. Email Us: [email protected]
#1 lore raw
Quoted 1 line · On Sat, 11 May 2002, [iso-8859-1] Ville Syrj�l� wrote:

I'm resending this since you didn't apply it from my previous patch.

The revision is revision of interwave chip not codec which is only a part of interwave chip. So this change does not make sense.

Jaroslav

-----
Jaroslav Kysela <[email protected]>
Linux Kernel Sound Maintainer
ALSA Project http://www.alsa-project.org
SuSE Linux http://www.suse.com

_______________________________________________________________

Have big pipes? SourceForge.net is looking for download mirrors. We supply the hardware. You get the recognition. Email Us: [email protected]

#2 lore raw
Quoted 2 lines · Jaroslav Kysela

The revision is revision of interwave chip not codec which is only a part of interwave chip. So this change does not make sense.

I don't understand what you mean. This is the name of a PCM device we're talking about here.

This is without the patch:

# cat /proc/asound/pcm
00-00: CS4231 : AMD InterWave rev B (chip) : playback 1 : capture 1
00-01: AMD InterWave : AMD InterWave rev B (synth) : playback 1

Doesn't look right to me. It's always bee "(codec)" in the past.

Signature · 8 lines
Ville Syrjälä
[email protected]
http://www.sci.fi/~syrjala/

_______________________________________________________________

Have big pipes? SourceForge.net is looking for download mirrors. We supply
the hardware. You get the recognition. Email Us: [email protected]
#3 lore raw
Quoted 7 lines · On Sun, 12 May 2002, [iso-8859-1] Ville Syrj�l� wrote:
Quoted 2 lines · Jaroslav Kysela

The revision is revision of interwave chip not codec which is only a part of interwave chip. So this change does not make sense.

I don't understand what you mean. This is the name of a PCM device we're talking about here.

Quoted 6 lines

This is without the patch:

# cat /proc/asound/pcm
00-00: CS4231 : AMD InterWave rev B (chip) : playback 1 : capture 1
00-01: AMD InterWave : AMD InterWave rev B (synth) : playback 1

Doesn't look right to me. It's always bee "(codec)" in the past.

Ok, I've overlooked that it's PCM name. Changed and thanks.

Jaroslav

-----
Jaroslav Kysela <[email protected]>
Linux Kernel Sound Maintainer
ALSA Project http://www.alsa-project.org
SuSE Linux http://www.suse.com

_______________________________________________________________

Have big pipes? SourceForge.net is looking for download mirrors. We supply the hardware. You get the recognition. Email Us: [email protected]