Skip to contentSkip to conversation

Serverworks IDE driver: missing static

PATCH In review Andrey Panin 2 participants 2 messages May 22, 2002

lore
Share & tools
lore

Andrey Panin

author
#0 lore raw

PATCH 1/1 Serverworks IDE driver: missing static

Hi,

svwks_tune_chipset() function contains 3 arrays which IMHO should be static. Attached patch fixed it, saving for me 48 bytes of code :)) Compiles, but untested. Please consider applying.

Best regards.

Signature · 2 lines
Andrey Panin            | Embedded systems software engineer
[email protected]        | PGP key: wwwkeys.eu.pgp.net
drivers/ide/serverworks.c +3 -3
diff -urN -X /usr/share/dontdiff linux.vanilla/drivers/ide/serverworks.c linux/drivers/ide/serverworks.c
@@ -242,9 +242,9 @@
 
 static int svwks_tune_chipset(struct ata_device *drive, byte speed)
 {
-	byte udma_modes[]	= { 0x00, 0x01, 0x02, 0x03, 0x04, 0x05 };
-	byte dma_modes[]	= { 0x77, 0x21, 0x20 };
-	byte pio_modes[]	= { 0x5d, 0x47, 0x34, 0x22, 0x20 };
+	static byte udma_modes[] = { 0x00, 0x01, 0x02, 0x03, 0x04, 0x05 };
+	static byte dma_modes[]	= { 0x77, 0x21, 0x20 };
+	static byte pio_modes[]	= { 0x5d, 0x47, 0x34, 0x22, 0x20 };
 
 	struct ata_channel *hwif = drive->channel;
 	struct pci_dev *dev	= hwif->pci_dev;
#1 lore raw
Quoted 7 lines · Użytkownik Andrey Panin

Hi,

svwks_tune_chipset() function contains 3 arrays which IMHO should be static. Attached patch fixed it, saving for me 48 bytes of code :)) Compiles, but untested. Please consider applying.

Best regards.

Considered and applied of course.