SLC82C105 IDE driver: missing __init
PATCH 1/1 SLC82C105 IDE driver: missing __init
Hi,
slc82c105_bridge_revision() functions lacks __init modifier. Attached patch (against 2.5.17) fixes it. Compiles, but untested. Please consider applying.
Best regards.
Signature · 2 lines
Andrey Panin | Embedded systems software engineer [email protected] | PGP key: wwwkeys.eu.pgp.net
drivers/ide/sl82c105.c +1 -1
@@ -185,7 +185,7 @@* Return the revision of the Winbond bridge * which this function is part of. */ -static unsigned int sl82c105_bridge_revision (struct pci_dev *dev) +static unsigned int __init sl82c105_bridge_revision (struct pci_dev *dev) {struct pci_dev *bridge;unsigned char rev;
Quoted 3 lines · Andrey Panin
slc82c105_bridge_revision()functions lacks__initmodifier. Attached patch (against 2.5.17) fixes it. Compiles, but untested. Please consider applying.
I'm surprised it compiles. I've got a rather major update to it here, but I need to find time to pull it out of the ARM patch, and I need IDE to settle down a bit so the two are actually in sync with each other. (Martin messed up my DMA changes which'd prevent sl82c105 linking - I'm waiting for the fix to emerge, which I think is in 2.5.17, but the TLB stuff in 2.5.17 has broken all my ARM builds, so I'm unable to build or test anything on 2.5 currently.)
Too many things to do... too many problems to solve... too many patches to look at... too much email... not enough hours in the day... not enough fast machines to build kernels on... not enough rmk clones to run kernel tests... 8)
Signature · 2 lines
Russell King ([email protected]) The developer of ARM Linux http://www.arm.linux.org.uk/personal/aboutme.html
Uz.ytkownik Russell King napisa?:
Quoted 8 lines · Andrey Panin
Quoted 4 lines
slc82c105_bridge_revision()functions lacks__initmodifier. Attached patch (against 2.5.17) fixes it. Compiles, but untested. Please consider applying.I'm surprised it compiles.
I'm not :-). I wouldn't be even surprised if it works by accident...
Quoted 5 lines
I've got a rather major update to it here,
but I need to find time to pull it out of the ARM patch, and I need IDE to settle down a bit so the two are actually in sync with each other. (Martin messed up my DMA changes which'd prevent sl82c105 linking - I'm waiting for the fix to emerge, which I think is in 2.5.17, but the TLB
It should indeed be all in place right now. Other then this: If you feel like something in the generic code has to be changed - don't hessitate just do it. We can always sort it out.
Quoted 2 lines
stuff in 2.5.17 has broken all my ARM builds, so I'm unable to build or test anything on 2.5 currently.)
Just to make it clean - this time it was not me ;-).
Quoted 5 lines
Too many things to do... too many problems to solve... too many patches to look at... too much email... not enough hours in the day... not enough fast machines to build kernels on... not enough rmk clones to run kernel tests... 8)
Quoted 3 lines
slc82c105_bridge_revision()functions lacks__initmodifier. Attached patch (against 2.5.17) fixes it. Compiles, but untested. Please consider applying.
I wouldnt get too carried away with these. Once the IDE core is clean enough to allow hot plugging of IDE interfaces those __init's are all going to need changing anyway
(and yes you can get hot pluggable IDE setups already - the mobility stuff
for example has a case with a PCI split bridge, 3 or 4 PCI slots and connects to the cardbus on a laptop)
Quoted 7 lines · Alan Cox
Quoted 3 lines
slc82c105_bridge_revision()functions lacks__initmodifier. Attached patch (against 2.5.17) fixes it. Compiles, but untested. Please consider applying.I wouldnt get too carried away with these. Once the IDE core is clean enough to allow hot plugging of IDE interfaces those __init's are all going to need changing anyway
Then we'll grep and change them to __devinit.
But missing __init can't be changed :))
Quoted 3 lines
(and yes you can get hot pluggable IDE setups already - the mobility stuff
for example has a case with a PCI split bridge, 3 or 4 PCI slots and connects to the cardbus on a laptop)
Signature · 2 lines
Andrey Panin | Embedded systems software engineer [email protected] | PGP key: wwwkeys.eu.pgp.net