2.4.19-pre10 bug in disable_APIC_timer
PATCH 1/1 2.4.19-pre10 bug in disable_APIC_timer
Marcelo,
This one bit me when I actually started using the (relatively) new
services disable_APIC_timer() and enable_APIC_timer(). Enable_APIC_timer() is coded correctly; this patch fixes the bug in the disable service.
Please apply. Patch is against 2.4.19-pre10.
Joe
arch/i386/kernel/apic.c renamed from arch/i386/kernel/apic.c.orig +1 -1
@@ -941,7 +941,7 @@smp_call_function (setup_APIC_timer, (void *)calibration_result,1 ,1 ); } -void __init disable_APIC_timer (void ) +void disable_APIC_timer (void ) {if (using_apic_timer) {unsigned long v;
Quoted 4 lines · Joe Korty
Marcelo,
This one bit me when I actually started using the (relatively) new
servicesdisable_APIC_timer()andenable_APIC_timer().Enable_APIC_timer()is coded correctly; this patch fixes the bug in the disable service.
When is this getting called from a non boot up situation ?
Quoted 8 lines · Joe Korty
Quoted 4 lines
Marcelo,
This one bit me when I actually started using the (relatively) new
servicesdisable_APIC_timer()andenable_APIC_timer().Enable_APIC_timer()is coded correctly; this patch fixes the bug in the disable service.When is this getting called from a non boot up situation ?
I am calling it from some cpu shielding code I've written and am debugging.
Joe
Quoted 3 lines · Joe Korty
I am calling it from some cpu shielding code I've written and am debugging.
So the __init isnt actually a bug. It might be an appropriate change if your code ever becomes part of the main tree thats all
Quoted 7 lines · Joe Korty
Quoted 3 lines
I am calling it from some cpu shielding code I've written and am debugging.
So the
__initisnt actually a bug. It might be an appropriate change if your code ever becomes part of the main tree thats all
True. In that case, an __init should be added to enable_APIC_timer.