Skip to contentSkip to conversation

w9966 doesn't compile

BUG Rolf Fokkens 3 participants 4 messages Jun 25, 2002 – Jun 29, 2002

lore
Share & tools
lore

Rolf Fokkens

author
#0 lore raw

Hi!

While trying to compile 2.4.19-rc1 the following error occurs:

w9966.c:68: warning: invalid character in macro parameter name w9966.c:68: badly punctuated parameter list in #define' w9966.c:69: warning: invalid character in macro parameter name w9966.c:69: badly punctuated parameter list in #define' w9966.c: In function `w9966_init':
w9966.c:329: warning: implicit declaration of function DPRINTF' w9966.c: In function w9966_setup':
w9966.c:432: warning: implicit declaration of function `DASSERT'

Relevant config options seem to me:

CONFIG_VIDEO_W9966=m

Cheers,

Rolf

#1 lore raw
Quoted 1 line · Rolf Fokkens

Hi!

Hi Rolf!

Quoted 11 lines

While trying to compile 2.4.19-rc1 the following error occurs:

w9966.c:68: warning: invalid character in macro parameter name w9966.c:68: badly punctuated parameter list in #define' w9966.c:69: warning: invalid character in macro parameter name w9966.c:69: badly punctuated parameter list in #define' w9966.c: In function `w9966_init':
w9966.c:329: warning: implicit declaration of function DPRINTF' w9966.c: In function w9966_setup':
w9966.c:432: warning: implicit declaration of function `DASSERT'

Quoted 3 lines

Relevant config options seem to me:

CONFIG_VIDEO_W9966=m

You are using egcs?

It seems egcs can't handle the following in lines 68-69:

<-- snip -->

...
# define DPRINTF(...) do {} while(0)
# define DASSERT(...) do {} while(0)
...

<-- snip -->

Since egcs is a supported compiler someone should fix this before 2.4.19-final comes out.

A solution might be something like the patch below (but I don't know for sure whether this is the correct solution):

media/video/w9966.c renamed from media/video/w9966.c.old +2 -2
@@ -65,8 +65,8 @@
 			DPRINTF("Assertion failed at line %d.\n", __LINE__);\
 	} while (0)
 #else
-#   define DPRINTF(...) do {} while(0)
-#   define DASSERT(...) do {} while(0)
+#   define DPRINTF(x...)
+#   define DASSERT(x...)
 #endif
 
 /*
Quoted 3 lines

Cheers,

Rolf

cu
Adrian

Signature · 3 lines
You only think this is a free country. Like the US the UK spends a lot of
time explaining its a free country because its a police state.
								Alan Cox
#2 lore raw
Quoted 4 lines · Adrian Bunk
Quoted 1 line · Rolf Fokkens

Hi!

Hi Rolf!

Hi Rolf and Adrian!

Quoted 41 lines
Quoted 12 lines

While trying to compile 2.4.19-rc1 the following error occurs:

w9966.c:68: warning: invalid character in macro parameter name w9966.c:68: badly punctuated parameter list in #define' w9966.c:69: warning: invalid character in macro parameter name w9966.c:69: badly punctuated parameter list in #define' w9966.c: In function `w9966_init':
w9966.c:329: warning: implicit declaration of function DPRINTF' w9966.c: In function w9966_setup':
w9966.c:432: warning: implicit declaration of function `DASSERT'

Quoted 3 lines

Relevant config options seem to me:

CONFIG_VIDEO_W9966=m

You are using egcs?

It seems egcs can't handle the following in lines 68-69:

<-- snip -->

...
# define DPRINTF(...) do {} while(0)
# define DASSERT(...) do {} while(0)
...

<-- snip -->

Since egcs is a supported compiler someone should fix this before 2.4.19-final comes out.

A solution might be something like the patch below (but I don't know for sure whether this is the correct solution):

media/video/w9966.c line 72

Quoted 10 lines
media/video/w9966.c renamed from media/video/w9966.c.old +2 -2
@@ -65,8 +65,8 @@
 			DPRINTF("Assertion failed at line %d.\n", __LINE__);\
 	} while (0)
 #else
-#   define DPRINTF(...) do {} while(0)
-#   define DASSERT(...) do {} while(0)
+#   define DPRINTF(x...)
+#   define DASSERT(x...)
 #endif
 
 /*

Unfortunatley I don't have egcs handy. Would this be a fix for egcs?

w9966.c renamed from w9966.c.orig +2 -2
@@ -65,8 +65,8 @@
 			DPRINTF("Assertion failed at line %d.\n", __LINE__);\
 	} while (0)
 #else
-#   define DPRINTF(...) do {} while(0)
-#   define DASSERT(...) do {} while(0)
+#   define DPRINTF(f, a...) do {} while(0)
+#   define DASSERT(f, a...) do {} while(0)
 #endif
 
 /*
Quoted 6 lines
Quoted 3 lines

Cheers,

Rolf

cu
Adrian

Regards,
Jakob

#3 lore raw
Quoted 1 line · Jakob Kemi

Hi Rolf and Adrian!

Hi Jakob,

Quoted 27 lines
Quoted 4 lines
Quoted 4 lines

While trying to compile 2.4.19-rc1 the following error occurs:

w9966.c:68: warning: invalid character in macro parameter name w9966.c:68: badly punctuated parameter list in `#define'

...

Quoted 11 lines

You are using egcs?

It seems egcs can't handle the following in lines 68-69:

<-- snip -->

...
# define DPRINTF(...) do {} while(0)
# define DASSERT(...) do {} while(0)
...

Quoted 5 lines

<-- snip -->

Since egcs is a supported compiler someone should fix this before 2.4.19-final comes out.

...
Unfortunatley I don't have egcs handy. Would this be a fix for egcs?

w9966.c line 72

Quoted 10 lines
w9966.c renamed from w9966.c.orig +2 -2
@@ -65,8 +65,8 @@
 			DPRINTF("Assertion failed at line %d.\n", __LINE__);\
 	} while (0)
 #else
-#   define DPRINTF(...) do {} while(0)
-#   define DASSERT(...) do {} while(0)
+#   define DPRINTF(f, a...) do {} while(0)
+#   define DASSERT(f, a...) do {} while(0)
 #endif
 
 /*

yes, this patch fixes the compilation for egcs.

Quoted 2 lines

Regards,
Jakob

Thanks for your fast response and patch
Adrian

media/video/w9966.c renamed from media/video/w9966.c.old +2 -2
@@ -65,8 +65,8 @@
 			DPRINTF("Assertion failed at line %d.\n", __LINE__);\
 	} while (0)
 #else
-#   define DPRINTF(...) do {} while(0)
-#   define DASSERT(...) do {} while(0)
+#   define DPRINTF(f, a...) do {} while(0)
+#   define DASSERT(f, a...) do {} while(0)
 #endif
 
 /*