LVM 1.0.5 patch for Linux 2.4.19-rc3
Quoted 14 lines · Marcin Dalecki
Quoted 7 lines · Christoph Hellwig
(quoted diff) +3
-0+#ifndef uchar +typedef unsigned char uchar; +#endifDo you _really_ have to use this non-standard type? can't you use the BSD
u_charor sysv unchar? and typedef/#define don't really mix nicely..Or of course the normal u8 u16 and u32 and infally u64, which are so much more explicit about the fact that we are actually dealig with bit slices.
Quoted 1 line
Quoted 7 lines
Quoted 2 lines
All in all this patch would be _soooo_ much easier to review if you wouldn't mix random indentation changes with real fixes.
Christoph applying the patch and rediffing with diffs "ingore white space' options can help you here.
And plese note that this kind of problems wouldn't be that common if we finally decided to make indent -kr -i8 mandatory.
It should have been for this patch.
Obviously an error on my end.
We'll resend...
Signature · 15 lines
Regards,
Heinz -- The LVM Guy --
*** Software bugs are stupid.
Nevertheless it needs not so stupid people to solve them ***
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Heinz Mauelshagen Sistina Software Inc.
Senior Consultant/Developer Am Sonnenhang 11
56242 Marienrachdorf
Germany
[email protected] +49 2626 141200
FAX 924446
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-