Buglet in irq compat code in 2.5.30

The save_flags used to save flags, while local_irq_save saves AND closes interrupts, and local_irq_save_off simply does not exist. I did not see anything on the list, perhaps nobody is bold enough to use 2.5.30?

diff -urN -X dontdiff linux-2.5.30/include/linux/interrupt.h linux-2.5.30-sparc/include/linux/interrupt.h
@@ -50,9 +50,9 @@
 #if !CONFIG_SMP
 # define cli()			local_irq_disable()
 # define sti()			local_irq_enable()
-# define save_flags(x)		local_irq_save(x)
+# define save_flags(x)		local_save_flags(x)
 # define restore_flags(x)	local_irq_restore(x)
-# define save_and_cli(x)	local_irq_save_off(x)
+# define save_and_cli(x)	local_irq_save(x)
 #endif
 
 

From: Pete Zaitcev <[email protected]>
Date: Wed, 7 Aug 2002 16:54:43 -0400

The save_flags used to save flags, while local_irq_save saves AND closes interrupts, and local_irq_save_off simply does not exist. I did not see anything on the list, perhaps nobody is bold enough to use 2.5.30?

These things really will die very soon, probably best not to rely on them at all :-)