cpumask_t
Subsystems (12)
PATCH 1/1 cpumask_t
Linus, this removes the "NR_CPUS < BITS_PER_LONG" assumption, with a few per-arch helpers (cpu_online_mask(mask) and any_online_cpu(mask)).
I've tested this now with making cpumask_t a struct, and it works fine (at the moment it's unsigned long for every arch, no change).
First tiny patch adds a "migrate_to_cpu(cpu)" helper to handle that (common) case simply.
Hot-unplug cpu patch does more cpu mask manip, so I want this fixed FIRST.
Thanks,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
Name: migrate_to_cpu patch
Author: Rusty Russell
Status: Trivial
D: This patch adds an easy "migrate_to_cpu()" call for simple
D: in-kernel affinity, in preparation for generic cpu maps.
Documentation/sched-coding.txt +4 -1
@@ -103,7 +103,10 @@ void set_user_nice(task_t *p, long nice) Sets the "nice" value of task p to the given value. int setscheduler(pid_t pid, int policy, struct sched_param *param) Sets the scheduling policy and parameters for the given pid. -void set_cpus_allowed(task_t *p, unsigned long new_mask) +void migrate_to_cpu(unsigned int cpu) + Migrates the current task to the cpu and nails it there. This + is a more convenient form of: +void set_cpus_allowed(task_t *p, cpu_mask_t new_mask) Sets a given task's CPU affinity and migrates it to a proper cpu. Callers must have a valid reference to the task and assure the task not exit prematurely. No locks can be held during the call.
arch/ppc64/kernel/rtasd.c +1 -1
@@ -226,7 +226,7 @@ repeat:continue ;DEBUG ("scheduling on %d\n" , cpu); -set_cpus_allowed (current,1UL << cpu); +migrate_to_cpu (cpu);DEBUG ("watchdog scheduled on cpu %d\n" ,smp_processor_id ()); do {
include/linux/sched.h +9 -1
@@ -411,8 +411,16 @@ do { if (atomic_dec_and_test(&(tsk)->usa#if CONFIG_SMP extern void set_cpus_allowed (task_t *p,unsigned long new_mask); +static inline void migrate_to_cpu (unsigned int cpu) +{ +unsigned long mask =0 ; +BUG_ON (!cpu_online (cpu)); +__set_bit (cpu, &mask); +set_cpus_allowed (current, mask); +}#else -# define set_cpus_allowed (p, new_mask) do { } while (0) +#define set_cpus_allowed (p, new_mask) do { } while (0) +#define migrate_to_cpu (cpu) do { BUG_ON((cpu) != 0); } while(0)#endif extern void set_user_nice (task_t *p,long nice);
kernel/softirq.c +1 -2
@@ -361,8 +361,7 @@ static int ksoftirqd(void * __bind_cpu) current->flags |=PF_IOTHREAD ;sigfillset (¤t->blocked); -/* Migrate to the right CPU */ -set_cpus_allowed (current,1UL << cpu); +migrate_to_cpu (cpu);if (smp_processor_id () != cpu)BUG ();
kernel/sched.c +1 -1
@@ -1972,7 +1973,7 @@ static int migration_thread(void * data)sigfillset (¤t->blocked);set_fs (KERNEL_DS ); -set_cpus_allowed (current,1UL << cpu); +migrate_to_cpu (cpu);/* * Migration can happen without a migration thread on the
Name: CPU mask patch
Author: Rusty Russell
Status: Trivial
Depends: Hotcpu/migrate-to-cpu.patch.gz
D: This patch adds a cpumask_t for easy future expansion of cpu masks.
D: It also changes any_online_cpu to return NR_CPUS on failure, like
D: find_first_bit.
include/asm-i386/smp.h +15 -6
@@ -90,17 +90,26 @@ extern volatile unsigned long cpu_callou#define cpu_possible (cpu) (cpu_callout_map & (1<<(cpu)))#define cpu_online (cpu) (cpu_online_map & (1<<(cpu))) -extern inline unsigned int num_online_cpus (void ) +/* This has to be bitop capable, so for most archs, an unsigned long */ +typedef unsigned long cpumask_t ; +#define CPU_MASK_ALL (~0UL) +#define CPU_MASK_NONE (0UL) + +static inline void cpu_online_mask (cpumask_t *res,const cpumask_t *mask) { -return hweight32 (cpu_online_map); + *res = (*mask & cpu_online_map); } -extern inline int any_online_cpu (unsigned int mask) +static inline unsigned int any_online_cpu (const cpumask_t *mask) { -if (mask & cpu_online_map) -return __ffs (mask & cpu_online_map); +if (*mask & cpu_online_map) +return __ffs (*mask & cpu_online_map); +return NR_CPUS ; +} -return -1 ; +static inline unsigned int num_online_cpus (void ) +{ +return hweight32 (cpu_online_map); }static __inlineint hard_smp_processor_id (void )
include/asm-ia64/smp.h +14 -4
@@ -51,12 +51,22 @@ extern inline unsigned int num_online_cpreturn hweight64 (cpu_online_map); } -extern inline int any_online_cpu (unsigned int mask) +/* This has to be bitop capable, so for most archs, an unsigned long */ +typedef unsigned long cpumask_t ; +#define CPU_MASK_ALL (~0UL) +#define CPU_MASK_NONE (0UL) + +static inline void cpu_online_mask (cpumask_t *res,const cpumask_t *mask) { -if (mask & cpu_online_map) -return __ffs (mask & cpu_online_map); + *res = (*mask & cpu_online_map); +} -return -1 ; +static inline unsigned int any_online_cpu (const cpumask_t *mask) +{ +if (*mask & cpu_online_map) +return __ffs (*mask & cpu_online_map); + +return NR_CPUS ; }/*
include/asm-ppc/smp.h +12 -4
@@ -56,12 +56,20 @@ extern inline unsigned int num_online_cpreturn hweight32 (cpu_online_map); } -extern inline int any_online_cpu (unsigned int mask) +typedef unsigned long cpumask_t ; +#define CPU_MASK_ALL (~0UL) +#define CPU_MASK_NONE (0UL) + +static inline void cpu_online_mask (cpumask_t *res,const cpumask_t *mask) { -if (mask & cpu_online_map) -return __ffs (mask & cpu_online_map); + *res = (*mask & cpu_online_map); +} -return -1 ; +static inline unsigned int any_online_cpu (const cpumask_t *mask) +{ +if (*mask & cpu_online_map) +return __ffs (*mask & cpu_online_map); +return NR_CPUS ; }extern int __cpu_up (unsigned int cpu);
include/asm-ppc64/smp.h +17 -0
@@ -53,6 +53,23 @@ static inline int num_online_cpus(void)return nr; } +typedef unsigned long cpumask_t ; +#define CPU_MASK_ALL (~0UL) +#define CPU_MASK_NONE (0UL) + +static inline void cpu_online_mask (cpumask_t *res,const cpumask_t *mask) +{ + *res = (mask & cpu_online_map); +} + +static inline unsigned int any_online_cpu (const cpumask_t *mask) +{ +if (*mask & cpu_online_map) +return __ffs (*mask & cpu_online_map); + +return NR_CPUS ; +} +extern volatile unsigned long cpu_callin_map[NR_CPUS ];#define smp_processor_id () (get_paca()->xPacaIndex)
include/asm-sparc64/smp.h +13 -4
@@ -70,11 +70,20 @@ extern unsigned long cpu_online_map;extern atomic_t sparc64_num_cpus_online;#define num_online_cpus () (atomic_read(&sparc64_num_cpus_online)) -static inline int any_online_cpu (unsigned long mask) +typedef unsigned long cpumask_t ; +#define CPU_MASK_ALL (~0UL) +#define CPU_MASK_NONE (0UL) + +static inline void cpu_online_mask (cpumask_t *res,const cpumask_t *mask) { -if ((mask &= cpu_online_map) !=0UL ) -return __ffs (mask); -return -1 ; + *res = (*mask & cpu_online_map); +} + +static inline int any_online_cpu (const cpumask_t *mask) +{ + if (*mask & cpu_online_map) != 0UL) +return __ffs (*mask & cpu_online_map); +return NR_CPUS ; }/*
include/linux/init_task.h +1 -1
@@ -48,7 +48,7 @@ prio: MAX_PRIO-20, \ static_prio: MAX_PRIO-20, \ policy: SCHED_NORMAL, \ - cpus_allowed: -1, \ + cpus_allowed: CPU_MASK_ALL, \ mm: NULL, \ active_mm: &init_mm, \ run_list: LIST_HEAD_INIT(tsk.run_list), \
include/linux/sched.h +6 -7
@@ -20,6 +20,7 @@ extern unsigned long event;#include <asm/page.h> #include <asm/ptrace.h> #include <asm/mmu.h> +#include <asm/current.h> #include <linux/smp.h> #include <linux/sem.h>
@@ -262,7 +263,7 @@ struct task_struct {unsigned long sleep_timestamp;unsigned long policy; -unsigned long cpus_allowed; +cpumask_t cpus_allowed;unsigned int time_slice, first_time_slice;struct list_head tasks;
@@ -410,13 +411,13 @@ do { if (atomic_dec_and_test(&(tsk)->usa#define _STK_LIM (8*1024*1024)#if CONFIG_SMP -extern void set_cpus_allowed (task_t *p,unsigned long new_mask); +extern void set_cpus_allowed (task_t *p,cpumask_t *new_mask);static inline void migrate_to_cpu (unsigned int cpu) { -unsigned long mask =0 ; +cpumask_t mask =CPU_MASK_NONE ;BUG_ON (!cpu_online (cpu)); -__set_bit (cpu, &mask); -set_cpus_allowed (current, mask); +__set_bit (cpu, (unsigned long *)&mask); +set_cpus_allowed (current, &mask); }#else #define set_cpus_allowed (p, new_mask) do { } while (0)
@@ -487,8 +488,6 @@ static inline struct task_struct *find_textern struct user_struct *alloc_uid (uid_t );extern void free_uid (struct user_struct *); -#include <asm/current.h> -extern unsigned long itimer_ticks;extern unsigned long itimer_next;extern void do_timer (struct pt_regs *);
include/linux/smp.h +6 -1
@@ -93,13 +93,18 @@ int cpu_up(unsigned int cpu);#define smp_call_function (func,info,retry,wait) ({ 0; })static inline void smp_send_reschedule (int cpu) { }static inline void smp_send_reschedule_all (void ) { } -#define cpu_online_map 1#define cpu_online (cpu) ({ cpu; 1; })#define num_online_cpus () 1#define __per_cpu_data#define per_cpu (var, cpu) var#define this_cpu (var) var +typedef unsigned long cpumask_t ; +#define CPU_MASK_ALL 1 +#define CPU_MASK_NONE 0 +#define cpu_online_mask (res,mask) do { *(res) = (*(mask) & 1); } while(0) +#define any_online_cpu (mask) ((*(mask) & 1) ? 0 : 1) +/* Need to know about CPUs going up/down? */ static inline int register_cpu_notifier (struct notifier_block *nb) {
kernel/sched.c +15 -13
@@ -415,7 +415,8 @@ repeat_lock_task:*/ if (unlikely (sync && !task_running (rq, p) && (task_cpu (p) !=smp_processor_id ()) && - (p->cpus_allowed & (1UL <<smp_processor_id ())))) { +test_bit (smp_processor_id (), + (unsigned long *)&p->cpus_allowed))) {set_task_cpu (p,smp_processor_id ());task_rq_unlock (rq, &flags);
@@ -789,7 +790,7 @@ skip_queue:#define CAN_MIGRATE_TASK (p,rq,this_cpu) \ ((jiffies - (p)->sleep_timestamp > cache_decay_ticks) && \ !task_running(rq, p) && \ - ((p)->cpus_allowed & (1UL << (this_cpu)))) + (test_bit((this_cpu), (unsigned long *)&(p)->cpus_allowed))) curr = curr->prev;
@@ -1542,7 +1543,7 @@ out_unlock: asmlinkage int sys_sched_setaffinity(pid_t pid, unsigned int len,unsigned long *user_mask_ptr) { -unsigned long new_mask; +cpumask_t online_mask, new_mask;int retval;task_t *p;
@@ -1552,8 +1553,8 @@ asmlinkage int sys_sched_setaffinity(pidif (copy_from_user (&new_mask, user_mask_ptr,sizeof (new_mask)))return -EFAULT ; - new_mask &= cpu_online_map; -if (!new_mask) +cpu_online_mask (&online_mask, &new_mask); +if (find_first_bit ((unsigned long *)&online_mask,NR_CPUS ) ==NR_CPUS )return -EINVAL ;read_lock (&tasklist_lock);
@@ -1578,7 +1579,7 @@ asmlinkage int sys_sched_setaffinity(pid goto out_unlock; retval =0 ; -set_cpus_allowed (p, new_mask); +set_cpus_allowed (p, &online_mask); out_unlock:put_task_struct (p);
@@ -1595,7 +1596,7 @@ asmlinkage int sys_sched_getaffinity(pid unsigned long *user_mask_ptr) {unsigned int real_len; -unsigned long mask; +cpumask_t mask;int retval;task_t *p;
@@ -1611,7 +1612,7 @@ asmlinkage int sys_sched_getaffinity(pid goto out_unlock; retval =0 ; - mask = p->cpus_allowed & cpu_online_map; +cpu_online_mask (&mask, &p->cpus_allowed); out_unlock:read_unlock (&tasklist_lock);
@@ -1914,7 +1915,7 @@ typedef struct {* task must not exit() & deallocate itself prematurely. The * call is not atomic; no spinlocks may be held. */ -void set_cpus_allowed (task_t *p,unsigned long new_mask) +void set_cpus_allowed (task_t *p,cpumask_t *new_mask) {unsigned long flags;migration_req_t req;
@@ -1928,12 +1929,12 @@ void set_cpus_allowed(task_t *p, unsignepreempt_disable (); rq =task_rq_lock (p, &flags); - p->cpus_allowed = new_mask; + p->cpus_allowed = *new_mask;/* * Can the task run on the task's current CPU? If not then * migrate the thread off to a proper CPU. */ -if (new_mask & (1UL <<task_cpu (p))) { +if (test_bit (task_cpu (p), (unsigned long *)new_mask)) {task_rq_unlock (rq, &flags); goto out; }
@@ -1942,7 +1943,8 @@ void set_cpus_allowed(task_t *p, unsigne* it is sufficient to simply update the task's cpu field. */ if (!p->array && !task_running (rq, p)) { -set_task_cpu (p,__ffs (p->cpus_allowed)); +set_task_cpu (p,any_online_cpu (&p->cpus_allowed)); +BUG_ON (task_cpu (p) >=NR_CPUS );task_rq_unlock (rq, &flags); goto out; }
@@ -2010,7 +2012,7 @@ static int migration_thread(void * data)spin_unlock_irqrestore (&rq->lock, flags); p = req->task; - cpu_dest =__ffs (p->cpus_allowed); + cpu_dest =any_online_cpu (&p->cpus_allowed); rq_dest =cpu_rq (cpu_dest); repeat: cpu_src =task_cpu (p);
From: Rusty Russell <[email protected]>
Date: Thu, 08 Aug 2002 17:39:18 +1000
I've tested this now with making cpumask_t a struct, and it works fine (at the moment it's unsigned long for every arch, no change).
It worked because you cast the thing to (unsigned long *) in every bitops. We either:
1) shouldn't need to do that, meaning cpumask_t must be a long or array or longs
2) you need to abstract away bitops on cpumask_t so that one _really_ could make cpumask_t a struct with things other than the mask itself inside, so cpumask_test, cpumask_add, cpumask_remove or however you'd like to name them
Didn't we go through a lot of effort to sanitize bitops types and kill the ugly casts? :-))))
In message <[email protected]> you write:
Quoted 11 lines
From: Rusty Russell <[email protected]>
Date: Thu, 08 Aug 2002 17:39:18 +1000I've tested this now with making
cpumask_ta struct, and it works fine (at the moment it's unsigned long for every arch, no change).It worked because you cast the thing to (unsigned long *) in every bitops. We either:
1) shouldn't need to do that, meaning
cpumask_tmust be a long or array or longs
Yes, this is the other way. It's probably neater to just make it completely generic and explicit.
Quoted 4 lines
2) you need to abstract away bitops on
cpumask_tso that one _really_ could makecpumask_ta struct with things other than the mask itself inside, socpumask_test,cpumask_add,cpumask_removeor however you'd like to name them
Naah, if I make it that flexible you'll do some godawful Sparc64 hack just to be different 8)
Quoted 2 lines
Didn't we go through a lot of effort to sanitize bitops types and kill the ugly casts? :-))))
I never claimed to be consistent 8)
Patch renames bitmap_member to DECLARE_BITMAP, then uses it for cpu masks. Arch adds "cpu_online_mask(res, src)" to clear offline bits in src.
Rusty.
PS. Yes, Dave, an asm-generic/smp.h is coming too 8) --
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
Name: Bitops Cleanup
Author: Rusty Russell
Status: Trivial
D: This renames bitmap_member to DECLARE_BITMAP, and moves it to bitops.h.
drivers/zorro/zorro.c +1 -1
@@ -80,7 +80,7 @@ struct zorro_dev *zorro_find_device(zorr* FIXME: use the normal resource management */ -bitmap_member (zorro_unused_z2ram,128 ); +DECLARE_BITMAP (zorro_unused_z2ram,128 ); static void __init mark_region(unsigned long start, unsigned long end,
include/linux/bitops.h +3 -3
@@ -2,6 +2,9 @@#define _LINUX_BITOPS_H#include <asm/bitops.h> +#define DECLARE_BITMAP (name,bits) \ + unsigned long name[((bits)+BITS_PER_LONG-1)/BITS_PER_LONG] +/* * ffs: find first bit set. This is defined the same way as * the libc and compiler builtin ffs routines, therefore
@@ -106,8 +109,5 @@ static inline unsigned int generic_hweig res = (res &0x33 ) + ((res >>2 ) &0x33 ); return (res & 0x0F) + ((res >> 4) & 0x0F); } - -#include <asm/bitops.h> -#endif
include/linux/types.h +0 -3
@@ -3,9 +3,6 @@#ifdef __KERNEL__#include <linux/config.h> - -#define bitmap_member (name,bits) \ - unsigned long name[((bits)+BITS_PER_LONG-1)/BITS_PER_LONG]#endif #include <linux/posix_types.h>
include/linux/zorro.h +2 -1
@@ -10,6 +10,7 @@#ifndef _LINUX_ZORRO_H#define _LINUX_ZORRO_H +#include <linux/bitops.h> #ifndef __ASSEMBLY__
@@ -199,7 +200,7 @@ extern struct zorro_dev *zorro_find_devi* the corresponding bits. */ -extern bitmap_member(zorro_unused_z2ram, 128); +extern DECLARE_BITMAP(zorro_unused_z2ram, 128);#define Z2RAM_START (0x00200000)#define Z2RAM_END (0x00a00000)
include/sound/ac97_codec.h +2 -1
@@ -25,6 +25,7 @@* */ +#include <linux/bitops.h> #include "control.h" #include "info.h"
@@ -169,7 +170,7 @@ struct _snd_ac97 {unsigned int rates_mic_adc;unsigned int spdif_status;unsigned short regs[0x80 ];/* register cache */ -bitmap_member (reg_accessed,0x80 );/* bit flags */ +DECLARE_BITMAP (reg_accessed,0x80 );/* bit flags */ union { /* vendor specific code */ struct { unsigned short unchained[3]; // 0 = C34, 1 = C79, 2 = C69
sound/core/seq/seq_clientmgr.h +1 -1
@@ -53,7 +53,7 @@ struct _snd_seq_client {char name[64 ];/* client name */ int number;/* client number */ unsigned int filter;/* filter flags */ -bitmap_member (event_filter,256 ); +DECLARE_BITMAP (event_filter,256 );snd_use_lock_t use_lock;int event_lost;/* ports */
sound/core/seq/seq_queue.h +2 -1
@@ -26,6 +26,7 @@#include "seq_lock.h" #include <linux/interrupt.h> #include <linux/list.h> +#include <linux/bitops.h> #define SEQ_QUEUE_NO_OWNER (-1)
@@ -51,7 +52,7 @@ struct _snd_seq_queue {spinlock_t check_lock;/* clients which uses this queue (bitmap) */ -bitmap_member (clients_bitmap,SNDRV_SEQ_MAX_CLIENTS ); +DECLARE_BITMAP (clients_bitmap,SNDRV_SEQ_MAX_CLIENTS );unsigned int clients;/* users of this queue */ struct semaphore timer_mutex;
Name: CPU mask patch
Author: Rusty Russell
Status: Trivial
Depends: Misc/bitops.patch.gz
D: This patch changes cpu masks to a generic bitmap.
fs/partitions/check.c +1 -1
@@ -467,7 +467,7 @@ void devfs_register_partitions (struct gfor (part =1 ; part < max_p; part++) {if ( unregister || (p[part].nr_sects <1 ) ) {devfs_unregister (p[part].de); - dev->part[p].de =NULL ; + dev->part[part].de =NULL ;continue ; }devfs_register_partition (dev, minor, part);
include/asm-i386/smp.h +14 -5
@@ -87,20 +87,29 @@ extern volatile int logical_apicid_to_cpextern volatile unsigned long cpu_callout_map; +#if NR_CPUS >32 +#error asm/smp.h needs fixing for > 32 CPUS. +#endif +#define cpu_possible (cpu) (cpu_callout_map & (1<<(cpu)))#define cpu_online (cpu) (cpu_online_map & (1<<(cpu))) +static inline void cpu_online_mask (unsigned long *res, +const unsigned long *mask) +{ + res[0 ] = (mask[0 ] & cpu_online_map); +} +extern inline unsigned int num_online_cpus (void ) {return hweight32 (cpu_online_map); } -extern inline int any_online_cpu (unsigned int mask) +static inline int any_online_cpu (const unsigned long *mask) { -if (mask & cpu_online_map) -return __ffs (mask & cpu_online_map); - -return -1 ; +if ((mask[0 ] & cpu_online_map) !=0UL ) +return __ffs (mask[0 ] & cpu_online_map); +return NR_CPUS ; }static __inlineint hard_smp_processor_id (void )
include/asm-ia64/smp.h +15 -5
@@ -45,18 +45,28 @@ extern volatile int ia64_cpu_to_sapicid[extern unsigned long ap_wakeup_vector; +#if NR_CPUS >64 +#error asm/smp.h needs fixing for > 64 CPUS. +#endif +#define cpu_online (cpu) (cpu_online_map & (1<<(cpu))) + +static inline void cpu_online_mask (unsigned long *res, +const unsigned long *mask) +{ + res[0 ] = (mask[0 ] & cpu_online_map); +} +extern inline unsigned int num_online_cpus (void ) {return hweight64 (cpu_online_map); } -extern inline int any_online_cpu (unsigned int mask) +static inline int any_online_cpu (const unsigned long *mask) { -if (mask & cpu_online_map) -return __ffs (mask & cpu_online_map); - -return -1 ; +if ((mask[0 ] & cpu_online_map) !=0UL ) +return __ffs (mask[0 ] & cpu_online_map); +return NR_CPUS ; }/*
include/asm-ppc/smp.h +14 -5
@@ -48,20 +48,29 @@ extern void smp_local_timer_interrupt(st#define smp_processor_id () (current_thread_info()->cpu) +#if NR_CPUS >32 +#error asm/smp.h needs fixing for > 32 CPUS. +#endif +#define cpu_online (cpu) (cpu_online_map & (1<<(cpu)))#define cpu_possible (cpu) (cpu_possible_map & (1<<(cpu))) +static inline void cpu_online_mask (unsigned long *res, +const unsigned long *mask) +{ + res[0 ] = (mask[0 ] & cpu_online_map); +} +extern inline unsigned int num_online_cpus (void ) {return hweight32 (cpu_online_map); } -extern inline int any_online_cpu (unsigned int mask) +static inline int any_online_cpu (const unsigned long *mask) { -if (mask & cpu_online_map) -return __ffs (mask & cpu_online_map); - -return -1 ; +if ((mask[0 ] & cpu_online_map) !=0UL ) +return __ffs (mask[0 ] & cpu_online_map); +return NR_CPUS ; }extern int __cpu_up (unsigned int cpu);
include/asm-ppc64/smp.h +17 -0
@@ -39,10 +39,20 @@ extern void smp_send_reschedule_all(void#define NO_PROC_ID 0xFF/* No processor magic marker */ +#if NR_CPUS >64 +#error asm/smp.h needs fixing for > 64 CPUS. +#endif +#define cpu_online (cpu) test_bit((cpu), &cpu_online_map)#define cpu_possible (cpu) paca[cpu].active +static inline void cpu_online_mask (unsigned long *res, +const unsigned long *mask) +{ + res[0 ] = (mask[0 ] & cpu_online_map); +} +static inline int num_online_cpus (void ) {int i, nr =0 ;
@@ -53,6 +63,13 @@ static inline int num_online_cpus(void)return nr; } +static inline int any_online_cpu (const unsigned long *mask) +{ +if ((mask[0 ] & cpu_online_map) !=0UL ) +return __ffs (mask[0 ] & cpu_online_map); +return NR_CPUS ; +} +extern volatile unsigned long cpu_callin_map[NR_CPUS ];#define smp_processor_id () (get_paca()->xPacaIndex)
include/asm-sparc64/smp.h +10 -4
@@ -70,11 +70,17 @@ extern unsigned long cpu_online_map;extern atomic_t sparc64_num_cpus_online;#define num_online_cpus () (atomic_read(&sparc64_num_cpus_online)) -static inline int any_online_cpu (unsigned long mask) +static inline void cpu_online_mask (unsigned long *res, +const unsigned long *mask) { -if ((mask &= cpu_online_map) !=0UL ) -return __ffs (mask); -return -1 ; + res[0 ] = (mask[0 ] & cpu_online_map); +} + +static inline int any_online_cpu (const unsigned long *mask) +{ +if ((mask[0 ] & cpu_online_map) !=0UL ) +return __ffs (mask[0 ] & cpu_online_map); +return NR_CPUS ; }/*
include/linux/init_task.h +1 -1
@@ -48,7 +48,7 @@ prio: MAX_PRIO-20, \ static_prio: MAX_PRIO-20, \ policy: SCHED_NORMAL, \ - cpus_allowed: -1, \ + cpus_allowed: CPU_MASK_ALL, \ mm: NULL, \ active_mm: &init_mm, \ run_list: LIST_HEAD_INIT(tsk.run_list), \
include/linux/sched.h +15 -4
@@ -14,12 +14,14 @@ extern unsigned long event;#include <linux/jiffies.h> #include <linux/rbtree.h> #include <linux/thread_info.h> +#include <linux/bitops.h> #include <asm/system.h> #include <asm/semaphore.h> #include <asm/page.h> #include <asm/ptrace.h> #include <asm/mmu.h> +#include <asm/current.h> #include <linux/smp.h> #include <linux/sem.h>
@@ -262,7 +264,7 @@ struct task_struct {unsigned long sleep_timestamp;unsigned long policy; -unsigned long cpus_allowed; +DECLARE_BITMAP (cpus_allowed,NR_CPUS );unsigned int time_slice, first_time_slice;struct list_head tasks;
@@ -410,10 +412,21 @@ do { if (atomic_dec_and_test(&(tsk)->usa#define _STK_LIM (8*1024*1024)#if CONFIG_SMP -extern void set_cpus_allowed (task_t *p,unsigned long new_mask); +extern void set_cpus_allowed (task_t *p,const unsigned long new_mask[]);#else # define set_cpus_allowed (p, new_mask) do { } while (0)#endif +#define CPU_MASK_NONE { 0 } +#define CPU_MASK_ALL \ + { [0 ... ((NR_CPUS+BITS_PER_LONG-1)/BITS_PER_LONG)-1] = ~0UL } + +static inline void migrate_to_cpu (unsigned int cpu) +{ +DECLARE_BITMAP (mask,NR_CPUS ) =CPU_MASK_NONE ; +BUG_ON (!cpu_online (cpu)); +__set_bit (cpu, mask); +set_cpus_allowed (current, mask); +}extern void set_user_nice (task_t *p,long nice);extern int task_prio (task_t *p);
@@ -479,8 +492,6 @@ static inline struct task_struct *find_textern struct user_struct *alloc_uid (uid_t );extern void free_uid (struct user_struct *); -#include <asm/current.h> -extern unsigned long itimer_ticks;extern unsigned long itimer_next;extern void do_timer (struct pt_regs *);
include/linux/smp.h +2 -1
@@ -93,12 +93,13 @@ int cpu_up(unsigned int cpu);#define smp_call_function (func,info,retry,wait) ({ 0; })static inline void smp_send_reschedule (int cpu) { }static inline void smp_send_reschedule_all (void ) { } -#define cpu_online_map 1#define cpu_online (cpu) ({ cpu; 1; })#define num_online_cpus () 1#define __per_cpu_data#define per_cpu (var, cpu) var#define this_cpu (var) var +#define cpu_online_mask (res,mask) do { *(res) = (*(mask) & 1); } while(0) +#define any_online_cpu (mask) ((*(mask) & 1) ? 0 : 1)/* Need to know about CPUs going up/down? */ static inline int register_cpu_notifier (struct notifier_block *nb)
kernel/sched.c +13 -13
@@ -29,6 +29,7 @@#include <linux/security.h> #include <linux/notifier.h> #include <linux/delay.h> +#include <linux/bitops.h> /* * Convert user-nice values [ -20 ... 0 ... 19 ]
@@ -415,7 +416,7 @@ repeat_lock_task:*/ if (unlikely (sync && !task_running (rq, p) && (task_cpu (p) !=smp_processor_id ()) && - (p->cpus_allowed & (1UL <<smp_processor_id ())))) { + (test_bit (smp_processor_id (), p->cpus_allowed)))) {set_task_cpu (p,smp_processor_id ());task_rq_unlock (rq, &flags);
@@ -789,7 +790,7 @@ skip_queue:#define CAN_MIGRATE_TASK (p,rq,this_cpu) \ ((jiffies - (p)->sleep_timestamp > cache_decay_ticks) && \ !task_running(rq, p) && \ - ((p)->cpus_allowed & (1UL << (this_cpu)))) + (test_bit(smp_processor_id(), p->cpus_allowed))) curr = curr->prev;
@@ -1542,7 +1543,7 @@ out_unlock: asmlinkage int sys_sched_setaffinity(pid_t pid, unsigned int len,unsigned long *user_mask_ptr) { -unsigned long new_mask; +DECLARE_BITMAP (new_mask,NR_CPUS );int retval;task_t *p;
@@ -1552,8 +1553,7 @@ asmlinkage int sys_sched_setaffinity(pidif (copy_from_user (&new_mask, user_mask_ptr,sizeof (new_mask)))return -EFAULT ; - new_mask &= cpu_online_map; -if (!new_mask) +if (any_online_cpu (new_mask) ==NR_CPUS )return -EINVAL ;read_lock (&tasklist_lock);
@@ -1595,7 +1595,7 @@ asmlinkage int sys_sched_getaffinity(pid unsigned long *user_mask_ptr) {unsigned int real_len; -unsigned long mask; +DECLARE_BITMAP (mask,NR_CPUS );int retval;task_t *p;
@@ -1611,7 +1611,7 @@ asmlinkage int sys_sched_getaffinity(pid goto out_unlock; retval =0 ; - mask = p->cpus_allowed & cpu_online_map; +cpu_online_mask (mask, p->cpus_allowed); out_unlock:read_unlock (&tasklist_lock);
@@ -1914,7 +1914,7 @@ typedef struct {* task must not exit() & deallocate itself prematurely. The * call is not atomic; no spinlocks may be held. */ -void set_cpus_allowed (task_t *p,unsigned long new_mask) +void set_cpus_allowed (task_t *p,const unsigned long new_mask[]) {unsigned long flags;migration_req_t req;
@@ -1928,12 +1928,12 @@ void set_cpus_allowed(task_t *p, unsignepreempt_disable (); rq =task_rq_lock (p, &flags); - p->cpus_allowed = new_mask; +memcpy (p->cpus_allowed, new_mask,sizeof (p->cpus_allowed));/* * Can the task run on the task's current CPU? If not then * migrate the thread off to a proper CPU. */ -if (new_mask & (1UL <<task_cpu (p))) { +if (test_bit (task_cpu (p), new_mask)) {task_rq_unlock (rq, &flags); goto out; }
@@ -1942,7 +1942,7 @@ void set_cpus_allowed(task_t *p, unsigne* it is sufficient to simply update the task's cpu field. */ if (!p->array && !task_running (rq, p)) { -set_task_cpu (p,__ffs (p->cpus_allowed)); +set_task_cpu (p,any_online_cpu (p->cpus_allowed));task_rq_unlock (rq, &flags); goto out; }
@@ -1972,7 +1972,7 @@ static int migration_thread(void * data)sigfillset (¤t->blocked);set_fs (KERNEL_DS ); -set_cpus_allowed (current,1UL << cpu); +migrate_to_cpu (cpu);/* * Migration can happen without a migration thread on the
@@ -2010,7 +2010,7 @@ static int migration_thread(void * data)spin_unlock_irqrestore (&rq->lock, flags); p = req->task; - cpu_dest =__ffs (p->cpus_allowed); + cpu_dest =any_online_cpu (p->cpus_allowed); rq_dest =cpu_rq (cpu_dest); repeat: cpu_src =task_cpu (p);
kernel/softirq.c +1 -2
@@ -361,8 +361,7 @@ static int ksoftirqd(void * __bind_cpu) current->flags |=PF_IOTHREAD ;sigfillset (¤t->blocked); -/* Migrate to the right CPU */ -set_cpus_allowed (current,1UL << cpu); +migrate_to_cpu (cpu);if (smp_processor_id () != cpu)BUG ();
fs/partitions/check.c void devfs_register_partitions (struct g · line 473
Quoted 12 lines · Rusty Russell
diff -urpN --exclude TAGS -X
/home/rusty/devel/kernel/kernel-patches/current-dontdiff--minimal.28255-2.5.30-cpumask.pre/fs/partitions/check.c.28255-2.5.30-cpumask/fs/partitions/check.cfs/partitions/check.c +1
-1@@ -467,7 +467,7 @@ void devfs_register_partitions (struct gfor (part =1 ; part < max_p; part++) {if ( unregister || (p[part].nr_sects <1 ) ) {devfs_unregister (p[part].de); - dev->part[p].de =NULL ; + dev->part[part].de =NULL ;continue ; }devfs_register_partition (dev, minor, part);
The above seems unrelated to cpumask_t. Also the current BK tree lists the fix as:
fs/partitions/check.c +1 -1
@@ -467,7 +467,7 @@for (part =1 ; part < max_p; part++) {if ( unregister || (p[part].nr_sects <1 ) ) {devfs_unregister (p[part].de); - dev->part[p].de =NULL ; + p[part].de =NULL ;continue ; }devfs_register_partition (dev, minor, part);
Signature · 1 line
Brad Heilbrun
Quoted 4 lines
Quoted 4 lines
It worked because you cast the thing to (unsigned long *) in every bitops. We either:
1) shouldn't need to do that, meaningcpumask_tmust be a long or array or longs
Quoted 3 lines · Rusty Russell
Yes, this is the other way. It's probably neater to just make it completely generic and explicit.
In message <[email protected]> you write:
Quoted 4 lines
Quoted 4 lines
2) you need to abstract away bitops on
cpumask_tso that one _really_ could makecpumask_ta struct with things other than the mask itself inside, socpumask_test,cpumask_add,cpumask_removeor however you'd like to name them
Quoted 2 lines · Rusty Russell
Naah, if I make it that flexible you'll do some godawful Sparc64 hack just to be different 8)
I just don't want this to die. Here's a stab at bringing it a little closer to up-to-date. I wasn't very careful but it's probably not much more than 3-4 hours to reconstitute from scratch if worse comes to worse. OTOH this is some really crusty stuff.
Resurrect cpumask_t or something on that order.
Compiletested with CONFIG_X86_NUMAQ only.
arch/i386/kernel/apic.c | 3 arch/i386/kernel/cpu/proc.c | 2 arch/i386/kernel/io_apic.c | 70 +++++++++------ arch/i386/kernel/irq.c | 35 +++++-- arch/i386/kernel/ldt.c | 12 +- arch/i386/kernel/mpparse.c | 6 - arch/i386/kernel/reboot.c | 2 arch/i386/kernel/smp.c | 67 ++++++++------ arch/i386/kernel/smpboot.c | 70 +++++++-------- drivers/base/node.c | 8 + include/asm-i386/mach-numaq/mach_apic.h | 24 +++-- include/asm-i386/mach-numaq/mach_ipi.h | 9 + include/asm-i386/mmu_context.h | 9 - include/asm-i386/mpspec.h | 2 include/asm-i386/smp.h | 29 +----- include/asm-i386/topology.h | 9 + include/linux/bitmap.h | 148 ++++++++++++++++++++++++++++++++ include/linux/cpumask.h | 51 +++++++++++ include/linux/init_task.h | 2 include/linux/irq.h | 2 include/linux/node.h | 2 include/linux/rcupdate.h | 4 include/linux/sched.h | 6 - include/linux/types.h | 6 - kernel/fork.c | 2 kernel/module.c | 9 + kernel/rcupdate.c | 12 +- kernel/sched.c | 61 +++++++------ kernel/softirq.c | 7 - kernel/workqueue.c | 4 30 files changed, 467 insertions(+), 206 deletions(-)
arch/i386/kernel/apic.c +2 -1
@@ -1138,7 +1138,8 @@ int __init APIC_init_uniprocessor (void)connect_bsp_APIC (); - phys_cpu_present_map =1 ; +bitmap_clear (phys_cpu_present_map.mask,NR_CPUS ); +cpu_set (0 , phys_cpu_present_map);apic_write_around (APIC_ID , boot_cpu_physical_apicid);apic_pm_init2 ();
arch/i386/kernel/cpu/proc.c +1 -1
@@ -47,7 +47,7 @@ static int show_cpuinfo(struct seq_fileint fpu_exception;#ifdef CONFIG_SMP -if (!(cpu_online_map & (1 <<n))) +if (!cpu_isset (n, cpu_online_map))return 0 ;#endif seq_printf(m, "processor\t: %d\n"
arch/i386/kernel/io_apic.c +45 -25
170 lines not on this page · raw message
arch/i386/kernel/irq.c +24 -11
@@ -793,13 +793,13 @@ int setup_irq(unsigned int irq, struct istatic struct proc_dir_entry * root_irq_dir;static struct proc_dir_entry * irq_dir [NR_IRQS ]; -#define HEX_DIGITS 8 +#define HEX_DIGITS (2*sizeof(cpumask_t))static unsigned int parse_hex_value (const char *buffer, -unsigned long count,unsigned long *ret) +unsigned long count,cpumask_t *ret) {unsigned char hexnum [HEX_DIGITS ]; -unsigned long value; +cpumask_t value =CPU_MASK_NONE ;int i;if (!count)
@@ -813,10 +813,10 @@ static unsigned int parse_hex_value (con* Parse the first 8 characters as a hex string, any non-hex char * is end-of-string. '00e1', 'e1', '00E1', 'E1' are all the same. */ - value =0 ;for (i =0 ; i < count; i++) {unsigned int c = hexnum[i]; +int k;switch (c) { case '0' ... '9': c -= '0'; break;
@@ -825,7 +825,10 @@ static unsigned int parse_hex_value (condefault : goto out; } - value = (value <<4 ) | c; +bitmap_shift_left (value.mask, value.mask,4 ,NR_CPUS ); +for (k =0 ; k <4 ; ++k) +if (test_bit (k, (unsigned long *)&c)) +cpu_set (k, value); } out: *ret = value;
@@ -836,20 +839,28 @@ out:static struct proc_dir_entry * smp_affinity_entry [NR_IRQS ]; -unsigned long irq_affinity [NR_IRQS ] = { [0 ...NR_IRQS -1 ] = ~0UL }; +cpumask_t irq_affinity [NR_IRQS ] = { [0 ...NR_IRQS -1 ] =CPU_MASK_ALL };static int irq_affinity_read_proc (char *page,char **start,off_t off,int count,int *eof,void *data) { +int k, len;if (count <HEX_DIGITS +1 )return -EINVAL ; -return sprintf (page,"%08lx\n" , irq_affinity[(long )data]); + + len =0 ; +for (k =0 ; k <CPU_ARRAY_SIZE ; ++k) { +int j =sprintf (page,"%08lx\n" , irq_affinity[(long )data].mask[k]); + len += j; + page += j; + } +return len; }static int irq_affinity_write_proc (struct file *file,const char *buffer,unsigned long count,void *data) {int irq = (long ) data, full_count = count, err; -unsigned long new_value; +cpumask_t new_value, tmp;if (!irq_desc[irq].handler->set_affinity)return -EIO ;
@@ -861,7 +872,8 @@ static int irq_affinity_write_proc (stru* way to make the system unusable accidentally :-) At least * one online CPU still has to be targeted. */ -if (!(new_value & cpu_online_map)) +cpus_and (tmp, new_value, cpu_online_map); +if (!any_online_cpu (tmp))return -EINVAL ; irq_affinity[irq] = new_value;
@@ -884,8 +896,9 @@ static int prof_cpu_mask_read_proc (charstatic int prof_cpu_mask_write_proc (struct file *file,const char *buffer,unsigned long count,void *data) { -unsigned long *mask = (unsigned long *) data, full_count = count, err; -unsigned long new_value; +cpumask_t *mask = (cpumask_t *)data; +unsigned long full_count = count, err; +cpumask_t new_value; err =parse_hex_value (buffer, count, &new_value);if (err)
arch/i386/kernel/ldt.c +8 -4
@@ -57,10 +57,14 @@ static int alloc_ldt(mm_context_t *pc, iif (reload) {load_LDT (pc);#ifdef CONFIG_SMP -preempt_disable (); -if (current->mm->cpu_vm_mask != (1 <<smp_processor_id ())) -smp_call_function (flush_ldt,0 ,1 ,1 ); -preempt_enable (); + { +cpumask_t tmp =CPU_MASK_NONE ; +preempt_disable (); +cpu_set (smp_processor_id (), tmp); +if (!cpus_equal (current->mm->cpu_vm_mask, tmp)) +smp_call_function (flush_ldt,0 ,1 ,1 ); +preempt_enable (); + }#endif }if (oldsize) {
arch/i386/kernel/mpparse.c +4 -2
@@ -70,7 +70,7 @@ unsigned int boot_cpu_logical_apicid = -static unsigned int __initdata num_processors;/* Bitmask of physically existing CPUs */ -unsigned long phys_cpu_present_map; +cpumask_t phys_cpu_present_map;int x86_summit =0 ;u8 bios_cpu_apicid[NR_CPUS ] = { [0 ...NR_CPUS -1 ] =BAD_APICID };
@@ -106,6 +106,7 @@ static struct mpc_config_translation *trvoid __init MP_processor_info (struct mpc_config_processor *m) {int ver, apicid; +cpumask_t tmp;if (!(m->mpc_cpuflag &CPU_ENABLED ))return ;
@@ -176,7 +177,8 @@ void __init MP_processor_info (struct mp } ver = m->mpc_apicver; - phys_cpu_present_map |=apicid_to_cpu_present (apicid); + tmp =apicid_to_cpu_present (apicid); +cpus_or (phys_cpu_present_map, phys_cpu_present_map, tmp);/* * Validate version
arch/i386/kernel/reboot.c +1 -1
@@ -234,7 +234,7 @@ void machine_restart(char * __unused)if its not, default to the BSP */ if ((reboot_cpu ==-1 ) || (reboot_cpu > (NR_CPUS -1 )) || - !(phys_cpu_present_map & (1 <<cpuid))) + !(cpu_isset (cpuid, phys_cpu_present_map))) reboot_cpu = boot_cpu_physical_apicid; reboot_smp =0 ;/* use this as a flag to only go through this once*/
arch/i386/kernel/smp.c +37 -30
180 lines not on this page · raw message
arch/i386/kernel/smpboot.c +36 -34
225 lines not on this page · raw message
drivers/base/node.c +7 -1
@@ -31,7 +31,13 @@ struct device_driver node_driver = {static ssize_t node_read_cpumap (struct device * dev,char * buf) {struct node *node_dev =to_node (to_root (dev)); -return sprintf (buf,"%lx\n" ,node_dev->cpumap); +int k, len =0 ; +for (k =0 ; k <CPU_ARRAY_SIZE ; ++k) { +int j =sprintf (buf,"%lx\n" ,node_dev->cpumap.mask[k]); + len += j; + buf += j; + } +return len; } static DEVICE_ATTR(cpumap,S_IRUGO,node_read_cpumap,NULL);
include/asm-i386/mach-numaq/mach_apic.h +17 -7
@@ -12,12 +12,12 @@#define INT_DEST_MODE 0/* physical delivery on LOCAL quad */ #define APIC_BROADCAST_ID 0x0F -#define check_apicid_used (bitmap, apicid) ((bitmap) & (1 << (apicid))) -#define check_apicid_present (bit) (phys_cpu_present_map & (1 << bit)) +#define check_apicid_used (bitmap, apicid) cpu_isset(apicid, bitmap) +#define check_apicid_present (bit) cpu_isset(bit, phys_cpu_present_map)static inline int apic_id_registered (void ) { -return (1 ); +return 1 ; }static inline void init_apic_ldr (void )
@@ -40,10 +40,15 @@ static inline int multi_timer_check(intreturn (apic !=0 && irq ==0 ); } -static inline ulong ioapic_phys_id_map (ulong phys_map) +static inline cpumask_t ioapic_phys_id_map (cpumask_t phys_map) {/* We don't have a good way to do this yet - hack */ -return 0xf ; +cpumask_t mask; +cpu_set (0 , mask); +cpu_set (1 , mask); +cpu_set (2 , mask); +cpu_set (3 , mask); +return mask; }/* Mapping from cpu number to logical apicid */
@@ -68,9 +73,14 @@ static inline int apicid_to_node(int logreturn (logical_apicid >>4 ); } -static inline unsigned long apicid_to_cpu_present (int logical_apicid) +static inline cpumask_t apicid_to_cpu_present (int logical_apicid) { -return ( (logical_apicid&0xf ) << (4 *apicid_to_node (logical_apicid)) ); +cpumask_t mask =CPU_MASK_NONE ; +int node =apicid_to_node (logical_apicid); +int cpu =__ffs (logical_apicid &0xf ); + +cpu_set (cpu +4 *node, mask); +return mask; }static inline int mpc_apic_id (struct mpc_config_processor *m,int quad)
include/asm-i386/mach-numaq/mach_ipi.h +5 -4
@@ -1,18 +1,19 @@#ifndef __ASM_MACH_IPI_H#define __ASM_MACH_IPI_H -static inline void send_IPI_mask_sequence (int mask,int vector); +static inline void send_IPI_mask_sequence (cpumask_t ,int vector); -static inline void send_IPI_mask (int mask,int vector) +static inline void send_IPI_mask (cpumask_t mask,int vector) {send_IPI_mask_sequence (mask, vector); }static inline void send_IPI_allbutself (int vector) { -unsigned long mask = cpu_online_map & ~(1 <<smp_processor_id ()); +cpumask_t mask = cpu_online_map; +cpu_clear (smp_processor_id (), mask); -if (mask) +if (any_online_cpu (mask) <NR_CPUS )send_IPI_mask (mask, vector); }
include/asm-i386/mmu_context.h +4 -5
@@ -30,12 +30,12 @@ static inline void switch_mm(struct mm_s {if (likely (prev != next)) {/* stop flush ipis for the previous mm */ -clear_bit (cpu, &prev->cpu_vm_mask); +cpu_clear (cpu, prev->cpu_vm_mask);#ifdef CONFIG_SMP cpu_tlbstate[cpu].state =TLBSTATE_OK ; cpu_tlbstate[cpu].active_mm = next;#endif -set_bit (cpu, &next->cpu_vm_mask); +cpu_set (cpu, next->cpu_vm_mask);/* Re-load page tables */ load_cr3 (next->pgd);
@@ -49,9 +49,8 @@ static inline void switch_mm(struct mm_s#ifdef CONFIG_SMP else { cpu_tlbstate[cpu].state =TLBSTATE_OK ; -if (cpu_tlbstate[cpu].active_mm != next) -BUG (); -if (!test_and_set_bit (cpu, &next->cpu_vm_mask)) { +BUG_ON (cpu_tlbstate[cpu].active_mm != next); +if (!cpu_test_and_set (cpu, next->cpu_vm_mask)) {/* We were in lazy tlb mode and leave_mm disabled * tlb flush IPI delivery. We must reload %cr3. */
include/asm-i386/mpspec.h +1 -1
@@ -206,7 +206,7 @@ extern int quad_local_to_mp_bus_id [NR_Cextern int mp_bus_id_to_pci_bus [MAX_MP_BUSSES ];extern unsigned int boot_cpu_physical_apicid; -extern unsigned long phys_cpu_present_map; +extern cpumask_t phys_cpu_present_map;extern int smp_found_config;extern void find_smp_config (void );extern void get_smp_config (void );
include/asm-i386/smp.h +6 -23
@@ -8,6 +8,7 @@#include <linux/config.h> #include <linux/kernel.h> #include <linux/threads.h> +#include <linux/cpumask.h> #endif #ifdef CONFIG_X86_LOCAL_APIC
@@ -31,8 +32,8 @@*/ extern void smp_alloc_memory (void ); -extern unsigned long phys_cpu_present_map; -extern unsigned long cpu_online_map; +extern cpumask_t phys_cpu_present_map; +extern cpumask_t cpu_online_map;extern volatile unsigned long smp_invalidate_needed;extern int pic_mode;extern int smp_num_siblings;
@@ -55,37 +56,19 @@ extern void zap_low_mappings (void);*/ #define smp_processor_id () (current_thread_info()->cpu) -extern volatile unsigned long cpu_callout_map; +extern volatile cpumask_t cpu_callout_map; -#define cpu_possible (cpu) (cpu_callout_map & (1<<(cpu))) -#define cpu_online (cpu) (cpu_online_map & (1<<(cpu))) - -#define for_each_cpu (cpu, mask) \ - for(mask = cpu_online_map; \ - cpu = __ffs(mask), mask != 0; \ - mask &= ~(1<<cpu)) - -extern inline unsigned int num_online_cpus (void ) -{ -return hweight32 (cpu_online_map); -} +#define cpu_possible (cpu) test_bit(cpu, cpu_callout_map.mask)/* We don't mark CPUs online until __cpu_up(), so we need another measure */ static inline int num_booting_cpus (void ) { -return hweight32 (cpu_callout_map); +return bitmap_weight ((unsigned long *)cpu_callout_map.mask,NR_CPUS ); }extern void map_cpu_to_logical_apicid (void );extern void unmap_cpu_to_logical_apicid (int cpu); -extern inline int any_online_cpu (unsigned int mask) -{ -if (mask & cpu_online_map) -return __ffs (mask & cpu_online_map); - -return -1 ; -}#ifdef CONFIG_X86_LOCAL_APIC static __inlineint hard_smp_processor_id (void ) {
include/asm-i386/topology.h +6 -3
@@ -29,8 +29,10 @@#ifdef CONFIG_NUMA +#include <linux/cpumask.h> +/* Mappings between logical cpu number and node number */ -extern volatile unsigned long node_2_cpu_mask[]; +extern volatile cpumask_t node_2_cpu_mask[];extern volatile int cpu_2_node[];/* Returns the number of the node containing CPU 'cpu' */
@@ -47,7 +49,7 @@ static inline int __cpu_to_node(int cpu)#define __parent_node (node) (node)/* Returns a bitmask of CPUs on Node 'node'. */ -static inline unsigned long __node_to_cpu_mask (int node) +static inline cpumask_t __node_to_cpu_mask (int node) {return node_2_cpu_mask[node]; }
@@ -55,7 +57,8 @@ static inline unsigned long __node_to_cp/* Returns the number of the first CPU on Node 'node'. */ static inline int __node_to_first_cpu (int node) { -return __ffs (__node_to_cpu_mask (node)); +cpumask_t mask =__node_to_cpu_mask (node); +return first_cpu (mask); }/* Returns the number of the first MemBlk on Node 'node' */
include/linux/bitmap.h +148 -0
148 lines not on this page · raw message
include/linux/cpumask.h +51 -0
51 lines not on this page · raw message
include/linux/init_task.h +1 -1
@@ -63,7 +63,7 @@ .prio = MAX_PRIO-20, \ .static_prio = MAX_PRIO-20, \ .policy = SCHED_NORMAL, \ - .cpus_allowed = ~0UL, \ + .cpus_allowed = CPU_MASK_ALL, \ .mm = NULL, \ .active_mm = &init_mm, \ .run_list = LIST_HEAD_INIT(tsk.run_list), \
include/linux/irq.h +1 -1
@@ -44,7 +44,7 @@ struct hw_interrupt_type {void (*disable)(unsigned int irq);void (*ack)(unsigned int irq);void (*end)(unsigned int irq); -void (*set_affinity)(unsigned int irq,unsigned long mask); +void (*set_affinity)(unsigned int irq,cpumask_t mask); };typedef struct hw_interrupt_type hw_irq_controller ;
include/linux/node.h +1 -1
@@ -22,7 +22,7 @@#include <linux/device.h> struct node { -unsigned long cpumap;/* Bitmap of CPUs on the Node */ +cpumask_t cpumap;/* Bitmap of CPUs on the Node */ struct sys_root sysroot; };
include/linux/rcupdate.h +2 -2
@@ -67,7 +67,7 @@ struct rcu_ctrlblk {spinlock_t mutex;/* Guard this struct */ long curbatch;/* Current batch number. */ long maxbatch;/* Max requested batch number. */ -unsigned long rcu_cpu_mask;/* CPUs that need to switch in order */ +cpumask_t rcu_cpu_mask;/* CPUs that need to switch in order */ /* for current batch to proceed. */ };
@@ -114,7 +114,7 @@ static inline int rcu_pending(int cpu) rcu_batch_before(RCU_batch(cpu), rcu_ctrlblk.curbatch)) || (list_empty (&RCU_curlist (cpu)) && !list_empty (&RCU_nxtlist (cpu))) || - test_bit(cpu, &rcu_ctrlblk.rcu_cpu_mask)) + cpu_isset(cpu, rcu_ctrlblk.rcu_cpu_mask)) return 1; else return 0;
include/linux/sched.h +3 -3
@@ -199,7 +199,7 @@ struct mm_struct {unsigned long arg_start, arg_end, env_start, env_end;unsigned long rss, total_vm, locked_vm;unsigned long def_flags; -unsigned long cpu_vm_mask; +cpumask_t cpu_vm_mask;unsigned long swap_address; unsigned dumpable:1;
@@ -298,7 +298,7 @@ struct task_struct {unsigned long sleep_timestamp;unsigned long policy; -unsigned long cpus_allowed; +cpumask_t cpus_allowed;unsigned int time_slice, first_time_slice;struct list_head tasks;
@@ -444,7 +444,7 @@ do { if (atomic_dec_and_test(&(tsk)->usa#define PT_TRACE_EXEC 0x00000080#if CONFIG_SMP -extern void set_cpus_allowed (task_t *p,unsigned long new_mask); +extern void set_cpus_allowed (task_t *p,cpumask_t new_mask);#else # define set_cpus_allowed (p, new_mask) do { } while (0)#endif
include/linux/types.h +1 -5
@@ -3,15 +3,11 @@#ifdef __KERNEL__#include <linux/config.h> - -#define DECLARE_BITMAP (name,bits) \ - unsigned long name[((bits)+BITS_PER_LONG-1)/BITS_PER_LONG] -#define CLEAR_BITMAP (name,bits) \ - memset(name, 0, ((bits)+BITS_PER_LONG-1)/8)#endif #include <linux/posix_types.h> #include <asm/types.h> +#include <linux/bitmap.h> #ifndef __KERNEL_STRICT_NAMES
kernel/fork.c +1 -1
@@ -235,7 +235,7 @@ static inline int dup_mmap(struct mm_str mm->free_area_cache =TASK_UNMAPPED_BASE ; mm->map_count =0 ; mm->rss =0 ; - mm->cpu_vm_mask =0 ; +bitmap_clear (mm->cpu_vm_mask.mask,NR_CPUS ); pprev = &mm->mmap;/*
kernel/module.c +6 -3
@@ -220,6 +220,7 @@ static int stopref(void *cpu) {int irqs_disabled =0 ;int prepared =0 ; +cpumask_t allowed_mask =CPU_MASK_NONE ;sprintf (current->comm,"kmodule%lu\n" , (unsigned long )cpu);
@@ -228,7 +229,8 @@ static int stopref(void *cpu)struct sched_param param = { .sched_priority =MAX_RT_PRIO -1 };setscheduler (current->pid,SCHED_FIFO , ¶m);#endif -set_cpus_allowed (current,1UL << (unsigned long )cpu); +cpu_set ((int )cpu, allowed_mask); +set_cpus_allowed (current, allowed_mask);/* Ack: we are alive */ atomic_inc (&stopref_thread_ack);
@@ -281,7 +283,7 @@ static void stopref_set_state(enum stoprstatic int stop_refcounts (void ) {unsigned int i, cpu; -unsigned long old_allowed; +cpumask_t old_allowed, allowed_mask =CPU_MASK_NONE ;int ret =0 ;/* One thread per cpu. We'll do our own. */
@@ -289,7 +291,8 @@ static int stop_refcounts(void)/* FIXME: racy with set_cpus_allowed. */ old_allowed = current->cpus_allowed; -set_cpus_allowed (current,1UL << (unsigned long )cpu); +cpu_set (cpu, allowed_mask); +set_cpus_allowed (current, allowed_mask);atomic_set (&stopref_thread_ack,0 ); stopref_num_threads =0 ;
kernel/rcupdate.c +6 -6
@@ -47,7 +47,7 @@/* Definition for rcupdate control block. */ struct rcu_ctrlblk rcu_ctrlblk = { .mutex =SPIN_LOCK_UNLOCKED , .curbatch =1 , - .maxbatch =1 , .rcu_cpu_mask =0 }; + .maxbatch =1 , .rcu_cpu_mask =CPU_MASK_NONE }; DEFINE_PER_CPU(struct rcu_data, rcu_data) = { 0L };/* Fake initialization required by compiler */
@@ -106,7 +106,7 @@ static void rcu_start_batch(long newbatc rcu_ctrlblk.maxbatch = newbatch; }if (rcu_batch_before (rcu_ctrlblk.maxbatch, rcu_ctrlblk.curbatch) || - (rcu_ctrlblk.rcu_cpu_mask !=0 )) { + (any_online_cpu (rcu_ctrlblk.rcu_cpu_mask) <NR_CPUS )) {return ; } rcu_ctrlblk.rcu_cpu_mask = cpu_online_map;
@@ -121,7 +121,7 @@ static void rcu_check_quiescent_state(vo {int cpu =smp_processor_id (); -if (!test_bit (cpu, &rcu_ctrlblk.rcu_cpu_mask)) { +if (!cpu_isset (cpu, rcu_ctrlblk.rcu_cpu_mask)) {return ; }
@@ -139,13 +139,13 @@ static void rcu_check_quiescent_state(vo }spin_lock (&rcu_ctrlblk.mutex); -if (!test_bit (cpu, &rcu_ctrlblk.rcu_cpu_mask)) { +if (!cpu_isset (cpu, rcu_ctrlblk.rcu_cpu_mask)) {spin_unlock (&rcu_ctrlblk.mutex);return ; } -clear_bit (cpu, &rcu_ctrlblk.rcu_cpu_mask); +cpu_clear (cpu, rcu_ctrlblk.rcu_cpu_mask);RCU_last_qsctr (cpu) =RCU_QSCTR_INVALID ; -if (rcu_ctrlblk.rcu_cpu_mask !=0 ) { +if (any_online_cpu (rcu_ctrlblk.rcu_cpu_mask) <NR_CPUS ) {spin_unlock (&rcu_ctrlblk.mutex);return ; }
kernel/sched.c +35 -26
191 lines not on this page · raw message
kernel/softirq.c +4 -3
@@ -299,6 +299,7 @@ void __init softirq_init()static int ksoftirqd (void * __bind_cpu) {int cpu = (int ) (long ) __bind_cpu; +cpumask_t allowed_mask =CPU_MASK_NONE ;daemonize ();set_user_nice (current,19 );
@@ -306,9 +307,9 @@ static int ksoftirqd(void * __bind_cpu)sigfillset (¤t->blocked);/* Migrate to the right CPU */ -set_cpus_allowed (current,1UL << cpu); -if (smp_processor_id () != cpu) -BUG (); +cpu_set (cpu, allowed_mask); +set_cpus_allowed (current, allowed_mask); +BUG_ON (smp_processor_id () != cpu);sprintf (current->comm,"ksoftirqd/%d" , cpu);
kernel/workqueue.c +3 -1
@@ -171,6 +171,7 @@ static int worker_thread(void *__startupint cpu = cwq - cwq->wq->cpu_wq;DECLARE_WAITQUEUE (wait, current);struct k_sigaction sa; +cpumask_t allowed_mask =CPU_MASK_NONE ;daemonize ();sprintf (current->comm,"%s/%d" , startup->name, cpu);
@@ -178,7 +179,8 @@ static int worker_thread(void *__startup cwq->thread = current;set_user_nice (current,-10 ); -set_cpus_allowed (current,1UL << cpu); +cpu_set (cpu, allowed_mask); +set_cpus_allowed (current, allowed_mask);spin_lock_irq (¤t->sig->siglock);siginitsetinv (¤t->blocked,sigmask (SIGCHLD ));
arch/i386/kernel/io_apic.c static void clear_IO_APIC (void) · line 198
Quoted 3 lines · William Lee Irwin III
arch/i386/kernel/io_apic.c +2
-1-static void set_ioapic_affinity (unsigned int irq,unsigned long mask) +#if NR_CPUS <=32 +static void set_ioapic_affinity (unsigned int irq,cpumask_t mask)
This is just broken anyway. And fixing it isn't as obvious as just using some mask -> APIC destination converter, as it's not possible to form all masks in all APIC modes. Even better, we set up our RTE's with physical DESTMOD, which not only finds these "masks" to be garbage, but can only address things parked on the same APIC bus as the IO-APIC; its implicit "any IO-APIC can interrupt any cpu" assumption is broken.
There are various very good reasons to keep it that way, too, for one, interrupting cpus on remote nodes would be dog slow, and the software interrupt number resolution techniques seem to require locality restrictions, as I don't believe the box has anything resembling MSI or whatever allows IA64 boxen to get away with 1:1 vector <-> irq maps.
I should probably find some way to make it play fair with xAPIC-based stuff and find something better to #ifdef on (or some other way out of actually being forced to deal with this) if I push this any further.
arch/i386/kernel/io_apic.c static void __init setup_ioapic_ids_from · line 1500
Quoted 7 lines · William Lee Irwin III
arch/i386/kernel/io_apic.c +3
-2@@ -1478,8 +1497,9 @@ static void __init setup_ioapic_ids_from -if (check_apicid_used (phys_id_present_map, - mp_ioapics[apic].mpc_apicid)) { + +/* MAJOR BRAINDAMAGE */ +if (phys_id_present_map & (1UL << mp_ioapics[apic].mpc_apicid)) { printk(KERN_ERR "BIOS bug, IO-APIC#%d ID %d is already used!...\n",
It's currently broken on multi-APIC-bus boxen anyway, and there is a replacement (not included here), at least for NUMA-Q. NFI about others; multi-APIC bus configs predating xAPIC's etc. with 8-bit physid's are probably rare outside of Sequent's boxen.
arch/i386/kernel/irq.c static int irq_affinity_write_proc (stru · line 877
Quoted 4 lines · William Lee Irwin III
arch/i386/kernel/irq.c +2
-1-if (!(new_value & cpu_online_map)) +cpus_and (tmp, new_value, cpu_online_map); +if (!any_online_cpu (tmp))return -EINVAL ;
Woops; I better fix that.
Hmm, there are probably other stupidities about. It could probably be cleaner/tested/etc. too. The IO-APIC and irq balancing stuff is a disaster area with or without the patch; I'm not sure how much I can really be expected to clean up down there. The TLB flushing stuff wanting various tidbits of atomicity is a wee bit worrying as well. I think I can get away with just shoving a barrier or two in there. And the shift operations on bitmaps could probably made faster, but AFAICT they aren't on any performance-critical paths.
-- wli
Quoted 1 line · William Lee Irwin III
This is just broken anyway. And fixing it isn't as obvious as just
Fix up several obvious stupidities. Atop the prior patch:
arch/i386/kernel/irq.c | 2 +- arch/i386/kernel/smp.c | 7 +++++-- include/linux/cpumask.h | 6 +++--- 3 files changed, 9 insertions(+), 6 deletions(-)
arch/i386/kernel/irq.c +1 -1
@@ -873,7 +873,7 @@ static int irq_affinity_write_proc (stru* one online CPU still has to be targeted. */ cpus_and (tmp, new_value, cpu_online_map); -if (!any_online_cpu (tmp)) +if (!any_online_cpu (tmp) >=NR_CPUS )return -EINVAL ; irq_affinity[irq] = new_value;
arch/i386/kernel/smp.c +5 -2
@@ -331,8 +331,9 @@ asmlinkage void smp_invalidate_interruptleave_mm (cpu); }ack_APIC_irq (); +smp_mb__before_clear_bit ();cpu_clear (cpu, flush_cpumask); - +smp_mb__after_clear_bit (); out:put_cpu_no_resched (); }
@@ -370,6 +371,7 @@ static void flush_tlb_others(cpumask_t c* atomic_set_mask(cpumask, &flush_cpumask); */ flush_cpumask = cpumask; +mb ();/* * We have to send the IPI only to * CPUs affected.
@@ -377,7 +379,8 @@ static void flush_tlb_others(cpumask_t csend_IPI_mask (cpumask,INVALIDATE_TLB_VECTOR );while (any_online_cpu (flush_cpumask) <NR_CPUS ) -/* nothing. lockup detection does not belong here */ ; +/* nothing. lockup detection does not belong here */ +mb (); flush_mm =NULL ; flush_va =0 ;
include/linux/cpumask.h +3 -3
@@ -16,7 +16,7 @@ extern cpumask_t cpu_online_map;#define cpu_online (cpu) test_bit(cpu, cpu_online_map.mask)#define num_online_cpus () bitmap_weight(cpu_online_map.mask, NR_CPUS) -#define any_online_cpu (map) find_first_zero_bit((map).mask, NR_CPUS) +#define any_online_cpu (map) find_first_bit((map).mask, NR_CPUS)#define cpu_set (cpu, map) set_bit(cpu, (map).mask)#define cpu_clear (cpu, map) clear_bit(cpu, (map).mask)
@@ -26,8 +26,8 @@ extern cpumask_t cpu_online_map;#define cpus_and (dst,src1,src2) bitmap_and((dst).mask,(src1).mask, (src2).mask, NR_CPUS)#define cpus_or (dst,src1,src2) bitmap_or((dst).mask, (src1).mask, (src2).mask, NR_CPUS)#define cpus_equal (map1, map2) bitmap_equal((map1).mask, (map2).mask, NR_CPUS) -#define first_cpu (map) find_first_zero_bit((map).mask, NR_CPUS) -#define next_cpu (cpu, map) find_next_zero_bit((map).mask, NR_CPUS, cpu) +#define first_cpu (map) find_first_bit((map).mask, NR_CPUS) +#define next_cpu (cpu, map) find_next_bit((map).mask, NR_CPUS, cpu)static inline int next_online_cpu (int cpu,cpumask_t map) {
Review
Quoted 2 lines · William Lee Irwin III
(quoted diff) +1
-0+ if (!any_online_cpu(tmp) >= NR_CPUS)
Thanks for spotting this, kai
arch/i386/kernel/irq.c +1 -1
@@ -873,7 +873,7 @@ static int irq_affinity_write_proc (stru* one online CPU still has to be targeted. */ cpus_and (tmp, new_value, cpu_online_map); -if (!any_online_cpu (tmp) >=NR_CPUS ) +if (any_online_cpu (tmp) >=NR_CPUS )return -EINVAL ; irq_affinity[irq] = new_value;
Quoted 1 line · William Lee Irwin III
Thanks for spotting this, kai
Zwane spotted this one, do_irq_balance() is clearing a cpumask but used the wrong bitmap size. This extends the API for extra safety with a cpus_clear() and avoids the need to be aware of the size (NR_CPUS) of cpumasks in calling code.
I might need a machine to test this on and/or testers eventually.
-- wli
Introduce cpus_clear() and convert open-coded bitmap_clear(., NR_CPUS) to use it instead.
arch/i386/kernel/apic.c | 2 +- arch/i386/kernel/io_apic.c | 8 ++++---- arch/i386/kernel/smpboot.c | 6 +++--- include/linux/cpumask.h | 1 + kernel/fork.c | 2 +- 5 files changed, 10 insertions(+), 9 deletions(-)
arch/i386/kernel/apic.c +1 -1
@@ -1138,7 +1138,7 @@ int __init APIC_init_uniprocessor (void)connect_bsp_APIC (); -bitmap_clear (phys_cpu_present_map.mask,NR_CPUS ); +cpus_clear (phys_cpu_present_map);cpu_set (0 , phys_cpu_present_map);apic_write_around (APIC_ID , boot_cpu_physical_apicid);
arch/i386/kernel/io_apic.c +4 -4
@@ -441,7 +441,7 @@ tryanotherirq: min_loaded = cpu_sibling_map[min_loaded];cpus_and (allowed_mask, cpu_online_map, irq_affinity[selected_irq]); -bitmap_clear (target_cpu_mask.mask,BITS_PER_LONG ); +cpus_clear (target_cpu_mask);cpu_set (min_loaded, target_cpu_mask);cpus_and (tmp, target_cpu_mask, allowed_mask);
@@ -509,7 +509,7 @@ static inline void balance_irq (int cpu,if (cpu != new_cpu) {irq_desc_t *desc = irq_desc + irq;spin_lock (&desc->lock); -bitmap_clear (irq_balance_mask[irq].mask,NR_CPUS ); +cpus_clear (irq_balance_mask[irq]);cpu_set (new_cpu, irq_balance_mask[irq]);spin_unlock (&desc->lock); }
@@ -526,7 +526,7 @@ int balanced_irq(void *unused)/* push everything to CPU 0 to give us a starting point. */ for (i =0 ; i <NR_IRQS ; i++) { -bitmap_clear (irq_balance_mask[i].mask,NR_CPUS ); +cpus_clear (irq_balance_mask[i]);cpu_set (0 , irq_balance_mask[i]); }for (;;) {
@@ -598,7 +598,7 @@ static inline void move_irq(int irq)/* note - we hold the desc->lock */ if (unlikely (any_online_cpu (irq_balance_mask[irq]) <NR_CPUS )) {set_ioapic_affinity (irq, irq_balance_mask[irq]); -bitmap_clear (irq_balance_mask[irq].mask,NR_CPUS ); +cpus_clear (irq_balance_mask[irq]); } }
arch/i386/kernel/smpboot.c +3 -3
@@ -979,7 +979,7 @@ static void __init smp_boot_cpus(unsigneif (!smp_found_config) {printk (KERN_NOTICE "SMP motherboard not detected.\n" );smpboot_clear_io_apic_irqs (); -bitmap_clear (phys_cpu_present_map.mask,NR_CPUS ); +cpus_clear (phys_cpu_present_map);cpu_set (1 , phys_cpu_present_map);if (APIC_init_uniprocessor ()) printk(KERN_NOTICE "Local APIC not detected."
@@ -1006,7 +1006,7 @@ static void __init smp_boot_cpus(unsigne boot_cpu_physical_apicid);printk (KERN_ERR "... forcing use of dummy APIC emulation. (tell your hw vendor)\n" );smpboot_clear_io_apic_irqs (); -bitmap_clear (phys_cpu_present_map.mask,NR_CPUS ); +cpus_clear (phys_cpu_present_map);cpu_set (1 , phys_cpu_present_map);return ; }
@@ -1020,7 +1020,7 @@ static void __init smp_boot_cpus(unsigne smp_found_config =0 ;printk (KERN_INFO "SMP mode deactivated, forcing use of dummy APIC emulation.\n" );smpboot_clear_io_apic_irqs (); -bitmap_clear (phys_cpu_present_map.mask,NR_CPUS ); +cpus_clear (phys_cpu_present_map);return ; }
include/linux/cpumask.h +1 -0
@@ -25,6 +25,7 @@ extern cpumask_t cpu_online_map;#define cpus_and (dst,src1,src2) bitmap_and((dst).mask,(src1).mask, (src2).mask, NR_CPUS)#define cpus_or (dst,src1,src2) bitmap_or((dst).mask, (src1).mask, (src2).mask, NR_CPUS) +#define cpus_clear (map) bitmap_clear((map).mask, NR_CPUS)#define cpus_equal (map1, map2) bitmap_equal((map1).mask, (map2).mask, NR_CPUS)#define first_cpu (map) find_first_bit((map).mask, NR_CPUS)#define next_cpu (cpu, map) find_next_bit((map).mask, NR_CPUS, cpu)
kernel/fork.c +1 -1
@@ -235,7 +235,7 @@ static inline int dup_mmap(struct mm_str mm->free_area_cache =TASK_UNMAPPED_BASE ; mm->map_count =0 ; mm->rss =0 ; -bitmap_clear (mm->cpu_vm_mask.mask,NR_CPUS ); +cpus_clear (mm->cpu_vm_mask); pprev = &mm->mmap;/*
I'm totally fine with this work, in fact I consider it a cleanup.
I could call it a bug fix, but that would be stretching it :-)
Quoted 3 lines · David S. Miller
I'm totally fine with this work, in fact I consider it a cleanup.
I could call it a bug fix, but that would be stretching it :-)
I'll try to maintain it, then. It's received zero runtime testing, esp. not in true NR_CPUS > BITS_PER_LONG circumstances. But I don't have any kind of regular (read as: once annually or less) access to such systems, so the best I can do is chip in and attempt to keep (largely untested/untestable) patches current.
This looks like it diverged a little bit from rusty's implementation, partly because I thought it'd be easier to just pound things out from scratch as opposed to attempting to port directly.
rusty, if you could comment on the differences, I'd be much obliged.
I'll also attempt to get a SPARC toolchain together (as I understand it, there are some divergences from mainline/current gcc/binutils) and do some compiletesting-like and API conversion things there.
Thanks,
Bill
From: William Lee Irwin III <[email protected]>
Date: Sun, 19 Jan 2003 22:32:19 -0800
I'll also attempt to get a SPARC toolchain together (as I understand it, there are some divergences from mainline/current gcc/binutils) and do some compiletesting-like and API conversion things there.
For sparc64 we use an old CVS egcs snapshot as that is the only thing which builds reliable kernels, especially in 2.5.x