Skip to contentSkip to conversation

Still more USB changes for 2.5.31

PATCH In review Greg KH 2 participants 2 messages Aug 21, 2002

lore
Share & tools
lore

Greg KH

author
#0 lore raw

PATCH 1/1 Still more USB changes for 2.5.31

This tree includes the last set of USB changes that have not shown up in your tree yet, and these new ones.

Pull from: http://linuxusb.bkbits.net/linus-2.5

thanks,

greg k-h

 drivers/usb/Config.in          |    8 
 drivers/usb/Makefile           |    2 
 drivers/usb/image/scanner.h    |    5 
 drivers/usb/media/ibmcam.c     |   84 +--
 drivers/usb/media/konicawc.c   |  144 ++++-
 drivers/usb/media/ultracam.c   |   36 -
 drivers/usb/media/usbvideo.c   |  279 ++++------
 drivers/usb/media/usbvideo.h   |   42 -
 drivers/usb/misc/Config.help   |   28 +
 drivers/usb/misc/Config.in     |   11 
 drivers/usb/misc/Makefile      |    4 
 drivers/usb/misc/atmsar.c      |  720 +++++++++++++++++++++++++++
 drivers/usb/misc/atmsar.h      |   81 +++
 drivers/usb/misc/speedtouch.c  | 1068 +++++++++++++++++++++++++++++++++++++++++
 drivers/usb/misc/usblcd.c      |  356 +++++++++++++
 drivers/usb/storage/scsiglue.c |    9 
 drivers/usb/storage/scsiglue.h |    1 
 drivers/usb/storage/usb.c      |   49 +
 18 files changed, 2654 insertions(+), 273 deletions(-)

-----

[email protected], 2002-08-21 15:04:15-07:00, [email protected]
[PATCH] typedef uvd_t removal in usbvideo

This patch replaces typedef struct { .. } uvd_t with struct uvd as a cleanup removing typedef *_t types.

 drivers/usb/media/ibmcam.c   |   84 +++++++++++++++++++++---------------------
 drivers/usb/media/konicawc.c |   36 +++++++++---------
 drivers/usb/media/ultracam.c |   36 +++++++++---------
 drivers/usb/media/usbvideo.c |   86 +++++++++++++++++++++----------------------
 drivers/usb/media/usbvideo.h |   42 ++++++++++-----------
 5 files changed, 142 insertions(+), 142 deletions(-)

------

[email protected], 2002-08-21 14:54:14-07:00, [email protected]
USB: added the speedtouch usb driver.

Patch originally from Richard Purdie <[email protected]> but tweaked by me.

 drivers/usb/Makefile          |    1 
 drivers/usb/misc/Config.help  |   28 +
 drivers/usb/misc/Config.in    |    1 
 drivers/usb/misc/Makefile     |    3 
 drivers/usb/misc/atmsar.c     |  720 ++++++++++++++++++++++++++++
 drivers/usb/misc/atmsar.h     |   81 +++
 drivers/usb/misc/speedtouch.c | 1068 ++++++++++++++++++++++++++++++++++++++++++
 7 files changed, 1902 insertions(+)

------

[email protected], 2002-08-21 14:27:46-07:00, [email protected]
[PATCH] patch for 2.5 scanner.h add device id's

 drivers/usb/image/scanner.h |    5 +++++
 1 files changed, 5 insertions(+)

------

[email protected], 2002-08-21 14:26:53-07:00, [email protected]
[PATCH] use __FUNCTION__ in usbvideo

This patch replaces static const char proc[] = <function name> with __FUNCTION__

 drivers/usb/media/usbvideo.c |  193 ++++++++++++++++++-------------------------
 1 files changed, 85 insertions(+), 108 deletions(-)

------

[email protected], 2002-08-21 13:53:49-07:00, [email protected]
[PATCH] PATCH: fix devices which don't support START_STOP

Based on my discussions with Pete Zaitcev <[email protected]>, I'm convinced that globally re-writing the START_STOP command into a TEST_UNIT_READY command is a good idea. This is supported by the fact that:

(1) Lots of devices don't support START_STOP
(2) Those that do support it often don't do a good job
(3) Win/Mac will never send these commands over a USB bus

So, here's a patch that re-writes them into Test Unit Ready commands. It seems to work on my system, but needs more testing. There may be a problem with this code still.... it seems that the SCSI layer can get convinced that the unit is not ready permanently. I'm honestly not certain what bit of code is wrong where, so reports from others would be greatly appreciated.

 drivers/usb/storage/usb.c |   38 +++++++++++++++++++++++++++++++-------
 1 files changed, 31 insertions(+), 7 deletions(-)

------

[email protected], 2002-08-21 13:52:42-07:00, [email protected]
[PATCH] PATCH: fix devices which don't support EVPD

Apparently, some new 2.5 scsi code tries to get the vital product data pages using the INQUIRY command. Unfortunately, most USB devices do not support this.

The following patch intercepts all EVPD requests and responds with the per-spec response of "Illegal Request: Invalid field in CDB".

 drivers/usb/storage/scsiglue.c |    9 +++++++++
 drivers/usb/storage/scsiglue.h |    1 +
 drivers/usb/storage/usb.c      |   11 +++++++++++
 3 files changed, 21 insertions(+)

------

[email protected], 2002-08-21 13:45:45-07:00, [email protected]
[PATCH] add VIDIOCSWIN support to konicawc driver

This patch uses the setVideoMode callback in usbvideo to allow the VIDIOCSWIN ioctl() to set the size and speed of the camera.

 drivers/usb/media/konicawc.c |  108 +++++++++++++++++++++++++++++++++++++++----
 1 files changed, 100 insertions(+), 8 deletions(-)

------

[email protected], 2002-08-21 13:38:10-07:00, [email protected]
USB: fix minor number for the usblcd driver.

 drivers/usb/misc/usblcd.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

------

[email protected], 2002-08-21 13:34:24-07:00, [email protected]
USB: added usblcd driver

Ported it from 2.4, any breakage is my fault :)

 drivers/usb/Config.in      |    8 -
 drivers/usb/Makefile       |    1 
 drivers/usb/misc/Config.in |   10 +
 drivers/usb/misc/Makefile  |    1 
 drivers/usb/misc/usblcd.c  |  354 +++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 367 insertions(+), 7 deletions(-)

------

#1 lore raw
Quoted 11 lines

From: Greg KH <[email protected]>
Date: Wed, 21 Aug 2002 15:49:40 -0700

[email protected], 2002-08-21 13:53:49-07:00, [email protected]
[PATCH] PATCH: fix devices which don't support START_STOP

Based on my discussions with Pete Zaitcev <[email protected]>, I'm convinced that globally re-writing the START_STOP command into a TEST_UNIT_READY command is a good idea. This is supported by the fact that:

Quoted 5 lines

(1) Lots of devices don't support START_STOP
(2) Those that do support it often don't do a good job
(3) Win/Mac will never send these commands over a USB bus

So, here's a patch that re-writes them into Test Unit Ready commands.

For the record, I do not think the blanket rewrite is a good idea. I did it for broken devices only, governed by a new quirk flag, and this is what we currently ship.

Matt reviewed what I did, but decided it would be cleaner to rewrite commands always. I did not go on a roll against it because:
1. 2.5 is supposed to be somewhat broken;
2. Matt is the module maintainer, he knows what he's doing.

-- Pete