2.5 port of aio-20020619 for raw devices
Subsystems (6)
PATCH 1/1 2.5 port of aio-20020619 for raw devices
I just did a rough port of the raw device part of the aio-20020619.diff over to 2.5.32 using the 2.5 aio API published so far. The changeset comments are below. The patch hasn't been tested. Its only guaranteed to compile.
I'd like to reiterate that this is not a fork of aio kernel code development or any attempt to question Ben's role as maintainer ! This was only an exercise in porting to enable a comparison of the older (2.4) approach with whatever's coming soon.
Comments are invited on all aspects of the design and implementation.
- Shailabh
# This changeset provides a partial port of Ben LaHaise's asynchronous # I/O patch for 2.4 kernel to 2.5. The port conforms to the aio API
# included in 2.5.32 and uses the design, data structures and functions # of the aio-20020619.diff.txt patch. # What this patch does # - implements aio read/write for raw devices # - provides the kvec data structure and helper functions # - conforms to the kiocb data structure provided in the 2.5.32 aio API # What this patch doesn't do # - support read/write for regular files (including those opened with # O_DIRECT), pipes, sockets. # - use the dio related functions providing O_DIRECT support. # - change any of the synchronous read/write functions. # - allow large transfers (> 128 KB) which were done in 2.4 using the # generic_aio_next_chunk function and kiocb->u task queue. # # The intent of providing this patch is to allow a performance # comparison of the aio design provided in 2.4 with any forthcoming # design in 2.5. Hopefully it will lead to an estimate of the # performance impact of keeping the async and sync I/O paths separate. # To have a fair comparison, its probably necessary for this code to # use bios directly rather than buffer heads, allow large I/O's etc. # The comparison will also be more complete if the missing 2.4 # functionality (regular files, pipes....) is ported over too. # # It is NOT intended to fork aio kernel code development or to suggest # an alternate design for 2.5 aio kernel support. # # Comments, suggestion for changes welcome. # # - Shailabh Nagar ([email protected])
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux Kernel 2.5
# This patch format is intended for GNU patch command version 2.5 or higher. # This patch includes the following deltas:
# ChangeSet 1.2 -> 1.4 # include/linux/aio.h 1.1 -> 1.3 # Makefile 1.1 -> 1.2 # fs/buffer.c 1.1 -> 1.3 # include/linux/types.h 1.1 -> 1.2 # mm/memory.c 1.1 -> 1.3 # include/linux/fs.h 1.1 -> 1.3 # fs/aio.c 1.1 -> 1.3 # drivers/char/raw.c 1.1 -> 1.3 # (new) -> 1.2 include/linux/kiovec.h
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 02/09/11 [email protected] 1.3
# This changeset provides a partial port of Ben LaHaise's asynchronous # I/O patch for 2.4 kernel to 2.5. The port conforms to the aio API
# included in 2.5.32 and uses the design, data structures and functions # of the aio-20020619.diff.txt patch. # What this patch does # - implements aio read/write for raw devices # - provides the kvec data structure and helper functions # - conforms to the kiocb data structure provided in the 2.5.32 aio API # What this patch doesn't do # - support read/write for regular files (including those opened with # O_DIRECT), pipes, sockets. # - use the dio related functions providing O_DIRECT support. # - change any of the synchronous read/write functions. # - allow large transfers (> 128 KB) which were done in 2.4 using the # generic_aio_next_chunk function and kiocb->u task queue. # # The intent of providing this patch is to allow a performance # comparison of the aio design provided in 2.4 with any forthcoming # design in 2.5. Hopefully it will lead to an estimate of the # performance impact of keeping the async and sync I/O paths separate. # To have a fair comparison, its probably necessary for this code to # use bios directly rather than buffer heads, allow large I/O's etc. # The comparison will also be more complete if the missing 2.4 # functionality (regular files, pipes....) is ported over too. # # It is NOT intended to fork aio kernel code development or to suggest # an alternate design for 2.5 aio kernel support. # # Comments, suggestion for changes welcome. # # - Shailabh Nagar ([email protected]) # # -------------------------------------------- # 02/09/11 [email protected] 1.4 # compilefixes # -------------------------------------------- # diff -Nru a/Makefile b/Makefile --- a/Makefile Wed Sep 11 14:00:00 2002 +++ b/Makefile Wed Sep 11 14:00:00 2002 @@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 5 SUBLEVEL = 32 -EXTRAVERSION = +EXTRAVERSION = -aioportraw
# *DOCUMENTATION*
# Too see a list of typical targets execute "make help"
drivers/char/raw.c +88 -0
@@ -17,6 +17,7 @@#include <linux/capability.h> #include <asm/uaccess.h> +#include <linux/kiovec.h> struct raw_device_data {struct block_device *binding;
@@ -238,12 +239,99 @@return rw_raw_dev (WRITE , filp, (char *)buf, size, offp); } + +int raw_kvec_rw (struct file *filp,int rw,kvec_cb_t cb,size_t size,loff_t pos) +{ +int err; +unsigned minor; +kdev_t dev; +unsigned long limit, blocknr, blocks; + +unsigned sector_size, sector_bits, sector_mask; +unsigned max_sectors; +unsigned i; + + minor =minor (filp->f_dentry->d_inode->i_rdev); + dev =to_kdev_t (raw_devices[minor].binding->bd_dev); + sector_size = raw_devices[minor].binding->bd_block_size; + sector_bits =blksize_bits (sector_size); + sector_mask = sector_size-1 ; + max_sectors =25000 ;/* Arbitrarily chosen from 2.4 code */ + +if (blk_size[major (dev)]) + limit = (((loff_t ) blk_size[major (dev)][minor (dev)]) <<BLOCK_SIZE_BITS ) >> sector_bits; +else + limit =INT_MAX ; + +/* EOF at the end */ + err =0 ; +if (!size || (pos >> sector_bits) == limit) { +pr_debug ("raw_kvec_rw: %Lu > %lu, %d\n" , pos >> sector_bits, limit, sector_bits); + cb.fn (cb.data, cb.vec, err); +return 0 ; + } + +/* ENXIO for io beyond the end */ + err = -ENXIO ; +if ((pos >> sector_bits) >= limit) { +pr_debug ("raw_kvec_rw: %Lu > %lu, %d\n" , pos >> sector_bits, limit, sector_bits); + goto out; + } + + err = -EINVAL ; +if ((pos <0 ) || (pos & sector_mask) || (size & sector_mask)) { +pr_debug ("pos(%Ld)/size(%lu) wrong(%d)\n" , pos, size, sector_mask); + goto out; + } + +/* Verify that the scatter-gather list is sector aligned. */ +for (i=0 ; i<cb.vec->nr; i++) +if ((cb.vec->veclet[i].offset & sector_mask) || + (cb.vec->veclet[i].length & sector_mask)) { +pr_debug ("veclet offset/length wrong" ); + goto out; + } + + blocknr = pos >> sector_bits; + blocks = size >> sector_bits; +if (blocks > max_sectors) + blocks = max_sectors; +if (blocks > limit - blocknr) + blocks = limit - blocknr; + err = -ENXIO ; +if (!blocks) { +pr_debug ("raw: !blocks %d %ld %ld\n" , max_sectors, limit, blocknr); + goto out; + } + + err =brw_kvec_async (rw, cb, raw_devices[minor].binding, blocks, blocknr, sector_bits); +out: +if (err) +printk (KERN_DEBUG "raw_kvec_rw: ret is %d\n" , err); +return err; + + +} +int raw_kvec_read (struct file *file,kvec_cb_t cb,size_t size,loff_t pos) +{ +return raw_kvec_rw (file,READ , cb, size, pos); +} + +int raw_kvec_write (struct file *file,kvec_cb_t cb,size_t size,loff_t pos) +{ +return raw_kvec_rw (file,WRITE , cb, size, pos); +} +static struct file_operations raw_fops = { .read = raw_read, .write = raw_write, .open = raw_open, .release= raw_release, .ioctl = raw_ioctl, + .aio_read = generic_file_aio_read, + .aio_write = generic_file_aio_write, + .kvec_read = raw_kvec_read, + .kvec_write = raw_kvec_write, .owner =THIS_MODULE , };
fs/aio.c +95 -0
120 lines not on this page · raw message
fs/buffer.c +168 -0
171 lines not on this page · raw message
include/linux/aio.h +4 -0
@@ -2,6 +2,7 @@#define __LINUX__AIO_H#include <linux/tqueue.h> +#include <linux/kiovec.h> #include <linux/list.h> #include <asm/atomic.h>
@@ -120,6 +121,9 @@ { return list_entry(h, struct kiocb, ki_list); } + +extern ssize_t generic_file_aio_read (struct kiocb *req,char *buf,size_t size,loff_t pos); +extern ssize_t generic_file_aio_write (struct kiocb *req,char *buf,size_t size,loff_t pos);/* for sysctl: */ extern unsigned aio_max_nr, aio_max_size, aio_max_pinned;
include/linux/fs.h +10 -0
@@ -200,6 +200,9 @@#ifdef __KERNEL__ +#include <linux/aio.h> +#include <linux/aio_abi.h> +#include <asm/semaphore.h> #include <asm/byteorder.h>
@@ -764,6 +767,10 @@ssize_t (*sendfile) (struct file *,struct file *,loff_t *,size_t );ssize_t (*sendpage) (struct file *,struct page *,int ,size_t ,loff_t *,int );unsigned long (*get_unmapped_area)(struct file *,unsigned long ,unsigned long ,unsigned long ,unsigned long ); + +/* in-kernel fully async api */ +int (*kvec_read)(struct file *,kvec_cb_t ,size_t ,loff_t ); +int (*kvec_write)(struct file *,kvec_cb_t ,size_t ,loff_t ); };struct inode_operations {
@@ -1248,6 +1255,9 @@ loff_t offset, size_t count);int generic_direct_IO (int rw,struct inode *inode,char *buf,loff_t offset,size_t count,get_blocks_t *get_blocks); +extern int generic_file_kvec_read (struct file *file,kvec_cb_t cb,size_t size,loff_t pos); +extern int generic_file_kvec_write (struct file *file,kvec_cb_t cb,size_t size,loff_t pos); +extern loff_t no_llseek (struct file *file,loff_t offset,int origin);extern loff_t generic_file_llseek (struct file *file,loff_t offset,int origin);
include/linux/kiovec.h new file +59 -0
59 lines not on this page · raw message
include/linux/types.h +5 -0
@@ -149,4 +149,9 @@ char f_fpack[6]; }; +/* kernel typedefs -- they belong here. */ +#ifdef __KERNEL__ +typedef struct kvec_cb kvec_cb_t ; +#endif /* __KERNEL__ */ +#endif /* _LINUX_TYPES_H */
mm/memory.c +173 -0
189 lines not on this page · raw message
Quoted 11 lines · Shailabh Nagar
I just did a rough port of the raw device part of the aio-20020619.diff over to 2.5.32 using the 2.5 aio API published so far. The changeset comments are below. The patch hasn't been tested. Its only guaranteed to compile.
I'd like to reiterate that this is not a fork of aio kernel code development or any attempt to question Ben's role as maintainer ! This was only an exercise in porting to enable a comparison of the older (2.4) approach with whatever's coming soon.
Comments are invited on all aspects of the design and implementation.
The generic aio <-> kvec functions were found to not work well, and the chunking code needs to actually pipeline data for decent io thruput. Short story: the raw device code must be rewritten using the dio code that akpm introduced.
-ben
Quoted 12 lines · Benjamin LaHaise
Quoted 10 lines · Shailabh Nagar
I just did a rough port of the raw device part of the aio-20020619.diff over to 2.5.32 using the 2.5 aio API published so far. The changeset comments are below. The patch hasn't been tested. Its only guaranteed to compile.
I'd like to reiterate that this is not a fork of aio kernel code development or any attempt to question Ben's role as maintainer ! This was only an exercise in porting to enable a comparison of the older (2.4) approach with whatever's coming soon.
Quoted 7 lines
Quoted 1 line
Comments are invited on all aspects of the design and implementation.
The generic aio <-> kvec functions were found to not work well, and the chunking code needs to actually pipeline data for decent io thruput. Short story: the raw device code must be rewritten using the dio code that akpm introduced.
-ben
--
So does the kvec structure go away (and some variant of dio get used) ?
Quoted 1 line · Shailabh Nagar
So does the kvec structure go away (and some variant of dio get used) ?
That's orthogonal. kvecs are really just bio_vecs for use by any code that has to pass around data that is scatter-gathered.
-ben
Signature · 1 line
"You will be reincarnated as a toad; and you will be much happier."
Quoted 9 lines · Benjamin LaHaise
Quoted 2 lines · Shailabh Nagar
So does the kvec structure go away (and some variant of dio get used) ?
That's orthogonal. kvecs are really just
bio_vecsfor use by any code that has to pass around data that is scatter-gathered.-ben
I see. So generic_aio_rw would directly call some function which used dio's rather than map the kvec first and call a kvec_op ?
Quoted 2 lines · Shailabh Nagar
I see. So
generic_aio_rwwould directly call some function which used dio's rather than map the kvec first and call akvec_op?
There should be no generic_aio_rw. Don't bring it back. Don't make any kvec ops either for it, just implement aio_read.
-ben
Quoted 11 lines · Benjamin LaHaise
Quoted 10 lines · Shailabh Nagar
I just did a rough port of the raw device part of the aio-20020619.diff over to 2.5.32 using the 2.5 aio API published so far. The changeset comments are below. The patch hasn't been tested. Its only guaranteed to compile.
I'd like to reiterate that this is not a fork of aio kernel code development or any attempt to question Ben's role as maintainer ! This was only an exercise in porting to enable a comparison of the older (2.4) approach with whatever's coming soon.
Quoted 6 lines
Quoted 1 line
Comments are invited on all aspects of the design and implementation.
The generic aio <-> kvec functions were found to not work well, and the chunking code needs to actually pipeline data for decent io thruput. Short story: the raw device code must be rewritten using the dio code that akpm introduced.
How async (degree on non-blocking nature of steps in the async state machine) do we want to be when we use the dio pipelining code ? (besides making the wait for dio completion bit async, of course)
Some key places where we can potentially block are when mapping the user pages, as part of get_blocks, when alloc'ing a bio, when issuing submit_bio (i.e. waiting for the request pipeline to drain out or free up slots). I guess, at least the last one would be addressed ... not sure what the plans for the rest are.
Regards
Suparna
Quoted 6 lines
-ben
--
To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to [email protected]. For more info on Linux AIO,
see: http://www.kvack.org/aio/
Quoted 23 lines · Suparna Bhattacharya
Quoted 11 lines · Benjamin LaHaise
Quoted 10 lines · Shailabh Nagar
I just did a rough port of the raw device part of the aio-20020619.diff over to 2.5.32 using the 2.5 aio API published so far. The changeset comments are below. The patch hasn't been tested. Its only guaranteed to compile.
I'd like to reiterate that this is not a fork of aio kernel code development or any attempt to question Ben's role as maintainer ! This was only an exercise in porting to enable a comparison of the older (2.4) approach with whatever's coming soon.
Quoted 6 lines
Quoted 1 line
Comments are invited on all aspects of the design and implementation.
The generic aio <-> kvec functions were found to not work well, and the chunking code needs to actually pipeline data for decent io thruput. Short story: the raw device code must be rewritten using the dio code that akpm introduced.
How async (degree on non-blocking nature of steps in the async state machine) do we want to be when we use the dio pipelining code ? (besides making the wait for dio completion bit async, of course)
Quoted 6 lines
Some key places where we can potentially block are when mapping the user pages, as part of
get_blocks, when alloc'ing a bio, when issuingsubmit_bio(i.e. waiting for the request pipeline to drain out or free up slots). I guess, at least the last one would be addressed ... not sure what the plans for the rest are.
alloc_bio non-blocking can be done by caller himself, submit_bio non-blocking can be assured with BIO_RW_AHEAD.
Signature · 1 line
Jens Axboe
Quoted 4 lines · Jens Axboe
...
alloc_bionon-blocking can be done by caller himself,submit_bionon-blocking can be assured withBIO_RW_AHEAD.
I haven't really found that to be usable - by the time you've called submit_bio() it's just waaaay too late to back out and undo everything. Mark pages dirty again, unlock them, clear the writeback bits, tell the caller that we really didn't write these many pages, tell the caller that things aren't working out, stop sending us pages, etc.
It's made harder by the fact that submit_bio() always returns "1". So you need to work out what happened in the bi_end_io() handler and pass all that back again. And somehow work out whether it was a failed WRITEA and not an IO error...
That's why I added the ability to ask "is this mapping's queue congested". It is much simpler to use and test from the perspective of the upper layers.
It has the disadvantage that we may have some data which is mergeable, and would in fact nonblockingly fit into a "congested" queue. Don't know if that makes a lot of difference in practice.
But there are some more things we can do to improve IO scheduling from the top layer. The most prominent of these is to write back the blockdev mapping's dirty pages in pgoff_t order (ie: LBA order) rather than in chronological mapping->dirty_pages order. That's happening, slowly, but involves significant surgery on radix_tree_brains.
Quoted 3 lines · Andrew Morton
It has the disadvantage that we may have some data which is mergeable, and would in fact nonblockingly fit into a "congested" queue. Don't know if that makes a lot of difference in practice.
That's what I was thinking. Not having a congested queue really breaks aio as your submit point is not supposed to incur significant latency: an io should -EAGAIN if it would cost a large delay to setup.
-ben
Signature · 1 line
"You will be reincarnated as a toad; and you will be much happier."
Quoted 10 lines · Benjamin LaHaise
Quoted 3 lines · Andrew Morton
It has the disadvantage that we may have some data which is mergeable, and would in fact nonblockingly fit into a "congested" queue. Don't know if that makes a lot of difference in practice.
That's what I was thinking. Not having a congested queue really breaks aio as your submit point is not supposed to incur significant latency: an io should
-EAGAINif it would cost a large delay to setup.
So is this congestion-query interface adequate for AIO? (It only works for disk-backed address_spaces, but other technologies can be taught to implement the required signalling).
The patch provides a means for the VM to be able to determine whether a request queue is in a "congested" state. If it is congested, then a write to (or read from) the queue may cause blockage in get_request_wait().
So the VM can do:
if (!bdi_write_congested(page->mapping->backing_dev_info))
writepage(page);
This is not exact. The code assumes that if the request queue still has 1/4 of its capacity (queue_nr_requests) available then a request will be non-blocking. There is a small chance that another CPU could zoom in and consume those requests. But on the rare occasions where that may happen the result will mereley be some unexpected latency - it's not worth doing anything elaborate to prevent this.
The patch decreases the size of `batch_requests'. batch_requests is positively harmful - when a "heavy" writer and a "light" writer are both writing to the same queue, batch_requests provides a means for the heavy writer to massively stall the light writer. Instead of waiting for one or two requests to come free, the light writer has to wait for 32 requests to complete.
Plus batch_requests generally makes things harder to tune, understand and predict. I wanted to kill it altogether, but Jens says that it is important for some hardware - it allows decent size requests to be submitted.
The VM changes which go along with this code cause batch_requests to be not so painful anyway - the only processes which sleep in get_request_wait() are the ones which we elect, by design, to wait in there - typically heavy writers.
The patch changes the meaning of `queue_nr_requests'. It used to mean "total number of requests per queue". Half of these are for reads, and half are for writes. This always confused the heck out of me, and the code needs to divide queue_nr_requests by two all over the place.
So queue_nr_requests now means "the number of write requests per queue" and "the number of read requests per queue". ie: I halved it.
Also, queue_nr_requests was converted to static scope. Nothing else uses it.
The accuracy of bdi_read_congested() and bdi_write_congested() depends upon the accuracy of mapping->backing_dev_info. With complex block stacking arrangements it is possible that ->backing_dev_info is pointing at the wrong queue. I don't know.
But the cost of getting this wrong is merely latency, and if it is a problem we can fix it up in the block layer, by getting stacking devices to communicate their congestion state upwards in some manner.
drivers/block/ll_rw_blk.c | 160 +++++++++++++++++++++++++++++++++++++------- include/linux/backing-dev.h | 14 +++ include/linux/blkdev.h | 1 3 files changed, 151 insertions(+), 24 deletions(-)
drivers/block/ll_rw_blk.c renamed from drivers/block/ll_rw_blk.c~queue-congestion +136 -24
@@ -56,13 +56,76 @@ struct blk_dev_struct blk_dev[MAX_BLKDEVint * blk_size[MAX_BLKDEV ];/* -* How many reqeusts do we allocate per queue, -* and how many do we "batch" on freeing them? +* Number of requests per queue. This many for reads and for writes (twice +* this number, total). */ -int queue_nr_requests, batch_requests; +static int queue_nr_requests; + +/* +* How many free requests must be available before we wake a process which +* is waiting for a request? +*/ +static int batch_requests; +unsigned long blk_max_low_pfn, blk_max_pfn;int blk_nohighio =0 ; +static struct congestion_state { +wait_queue_head_t wqh; +atomic_t nr_congested_queues; +} congestion_states[2 ]; + +/* +* Return the threshold (number of free requests) at which the queue is +* considered to be congested. It include a little hysteresis to keep the +* context switch rate down. +*/ +static inline int queue_congestion_on_threshold (void ) +{ +int ret; + + ret = queue_nr_requests /4 -1 ; +if (ret <0 ) + ret =1 ; +return ret; +} + +/* +* The threshold at which a queue is considered to be uncongested +*/ +static inline int queue_congestion_off_threshold (void ) +{ +int ret; + + ret = queue_nr_requests /4 +1 ; +if (ret > queue_nr_requests) + ret = queue_nr_requests; +return ret; +} + +static void clear_queue_congested (request_queue_t *q,int rw) +{ +enum bdi_state bit; +struct congestion_state *cs = &congestion_states[rw]; + + bit = (rw ==WRITE ) ? BDI_write_congested : BDI_read_congested; + +if (test_and_clear_bit (bit, &q->backing_dev_info.state)) +atomic_dec (&cs->nr_congested_queues); +if (waitqueue_active (&cs->wqh)) +wake_up (&cs->wqh); +} + +static void set_queue_congested (request_queue_t *q,int rw) +{ +enum bdi_state bit; + + bit = (rw ==WRITE ) ? BDI_write_congested : BDI_read_congested; + +if (!test_and_set_bit (bit, &q->backing_dev_info.state)) +atomic_inc (&congestion_states[rw].nr_congested_queues); +} +/** * bdev_get_queue: - return the queue that matches the given device * @bdev: device
@@ -345,8 +408,8 @@ int blk_queue_init_tags(request_queue_tstruct blk_queue_tag *tags;int bits, i; -if (depth > queue_nr_requests) { - depth = queue_nr_requests; +if (depth > (queue_nr_requests*2 )) { + depth = (queue_nr_requests*2 );printk ("blk_queue_init_tags: adjusted depth to %d\n" , depth); }
@@ -1004,7 +1067,7 @@ static int __blk_cleanup_queue(struct re**/ void blk_cleanup_queue (request_queue_t * q) { -int count = queue_nr_requests; +int count = (queue_nr_requests*2 ); count -=__blk_cleanup_queue (&q->rq[READ ]); count -=__blk_cleanup_queue (&q->rq[WRITE ]);
@@ -1035,7 +1098,7 @@ static int blk_init_free_list(request_qu* Divide requests in half between read and write */ rl = &q->rq[READ ]; -for (i =0 ; i < queue_nr_requests; i++) { +for (i =0 ; i < (queue_nr_requests*2 ); i++) { rq =kmem_cache_alloc (request_cachep,SLAB_KERNEL );if (!rq) goto nomem;
@@ -1043,7 +1106,7 @@ static int blk_init_free_list(request_qu/* * half way through, switch to WRITE list */ -if (i == queue_nr_requests /2 ) +if (i == queue_nr_requests) rl = &q->rq[WRITE ];memset (rq,0 ,sizeof (struct request ));
@@ -1129,7 +1192,7 @@ int blk_init_queue(request_queue_t *q, r* Get a free request. queue lock must be held and interrupts * disabled on the way in. */ -static inline struct request *get_request (request_queue_t *q,int rw) +static struct request *get_request (request_queue_t *q,int rw) {struct request *rq =NULL ;struct request_list *rl = q->rq + rw;
@@ -1138,6 +1201,8 @@ static inline struct request *get_reques rq =blkdev_free_rq (&rl->free);list_del (&rq->queuelist); rl->count--; +if (rl->count <queue_congestion_on_threshold ()) +set_queue_congested (q, rw); rq->flags =0 ; rq->rq_status =RQ_ACTIVE ; rq->special =NULL ;
@@ -1350,13 +1415,50 @@ void blk_put_request(struct request *req* it didn't come out of our reserved rq pools */ if (rl) { +int rw =0 ; +list_add (&req->queuelist, &rl->free); -if (++rl->count >= batch_requests &&waitqueue_active (&rl->wait)) +if (rl == &q->rq[WRITE ]) + rw =WRITE ; +else if (rl == &q->rq[READ ]) + rw =READ ; +else +BUG (); + + rl->count++; +if (rl->count >=queue_congestion_off_threshold ()) +clear_queue_congested (q, rw); +if (rl->count >= batch_requests &&waitqueue_active (&rl->wait))wake_up (&rl->wait); } } +/** +* blk_congestion_wait - wait for a queue to become uncongested +* @rw: READ or WRITE +* @timeout: timeout in jiffies +* +* Waits for up to @timeout jiffies for a queue (any queue) to exit congestion. +* If no queues are congested then just return, in the hope that the caller +* will submit some more IO. +*/ +void blk_congestion_wait (int rw,long timeout) +{ +DECLARE_WAITQUEUE (wait, current); +struct congestion_state *cs = &congestion_states[rw]; + +if (atomic_read (&cs->nr_congested_queues) ==0 ) +return ; +blk_run_queues (); +set_current_state (TASK_UNINTERRUPTIBLE ); +add_wait_queue (&cs->wqh, &wait); +if (atomic_read (&cs->nr_congested_queues) !=0 ) +schedule_timeout (timeout); +set_current_state (TASK_RUNNING ); +remove_wait_queue (&cs->wqh, &wait); +} +/* * Has to be called with the request spinlock acquired */
@@ -1866,6 +1968,7 @@ int __init blk_dev_init(void) {struct blk_dev_struct *dev;int total_ram; +int i; request_cachep = kmem_cache_create("blkdev_requests", sizeof(struct request),
@@ -1882,27 +1985,36 @@ int __init blk_dev_init(void) total_ram =nr_free_pages () << (PAGE_SHIFT -10 );/* -* Free request slots per queue. -* (Half for reads, half for writes) -*/ - queue_nr_requests = (total_ram >>8 ) & ~15 ;/* One per quarter-megabyte */ -if (queue_nr_requests <32 ) - queue_nr_requests =32 ; -if (queue_nr_requests >256 ) - queue_nr_requests =256 ; - -/* -* Batch frees according to queue length +* Free request slots per queue. One per quarter-megabyte. +* We use this many requests for reads, and this many for writes. */ -if ((batch_requests = queue_nr_requests /4 ) >32 ) - batch_requests =32 ; -printk ("block: %d slots per queue, batch=%d\n" , queue_nr_requests, batch_requests); + queue_nr_requests = (total_ram >>9 ) & ~7 ; +if (queue_nr_requests <16 ) + queue_nr_requests =16 ; +if (queue_nr_requests >128 ) + queue_nr_requests =128 ; + + batch_requests = queue_nr_requests /8 ; +if (batch_requests >8 ) + batch_requests =8 ; + +printk ("block request queues:\n" ); +printk (" %d requests per read queue\n" , queue_nr_requests); +printk (" %d requests per write queue\n" , queue_nr_requests); +printk (" %d requests per batch\n" , batch_requests); +printk (" enter congestion at %d\n" ,queue_congestion_on_threshold ()); +printk (" exit congestion at %d\n" ,queue_congestion_off_threshold ()); blk_max_low_pfn = max_low_pfn; blk_max_pfn = max_pfn;INIT_LIST_HEAD (&blk_plug_list); +for (i =0 ; i <ARRAY_SIZE (congestion_states); i++) { +init_waitqueue_head (&congestion_states[i].wqh); +atomic_set (&congestion_states[i].nr_congested_queues,0 ); + } +#if defined(CONFIG_IDE ) && defined(CONFIG_BLK_DEV_HD )hd_init ();#endif
include/linux/backing-dev.h renamed from include/linux/backing-dev.h~queue-congestion +14 -0
@@ -8,11 +8,15 @@#ifndef _LINUX_BACKING_DEV_H#define _LINUX_BACKING_DEV_H +#include <asm/atomic.h> +/* * Bits in backing_dev_info.state */ enum bdi_state { BDI_pdflush,/* A pdflush thread is working this device */ + BDI_write_congested,/* The write queue is getting full */ + BDI_read_congested,/* The read queue is getting full */ BDI_unused,/* Available bits start here */ };
@@ -28,4 +32,14 @@ int writeback_acquire(struct backing_devint writeback_in_progress (struct backing_dev_info *bdi);void writeback_release (struct backing_dev_info *bdi); +static inline int bdi_read_congested (struct backing_dev_info *bdi) +{ +return test_bit (BDI_read_congested, &bdi->state); +} + +static inline int bdi_write_congested (struct backing_dev_info *bdi) +{ +return test_bit (BDI_write_congested, &bdi->state); +} +#endif /* _LINUX_BACKING_DEV_H */
include/linux/blkdev.h renamed from include/linux/blkdev.h~queue-congestion +1 -0
@@ -341,6 +341,7 @@ extern void blk_queue_end_tag(request_quextern int blk_queue_init_tags (request_queue_t *,int );extern void blk_queue_free_tags (request_queue_t *);extern void blk_queue_invalidate_tags (request_queue_t *); +extern void blk_congestion_wait (int rw,long timeout);extern int * blk_size[MAX_BLKDEV ];/* in units of 1024 bytes */
.