Skip to contentSkip to conversation

Module rewrite 10/20: Parameter Support for Modules

PATCH New Rusty Russell 1 participant 1 message Sep 25, 2002

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Module rewrite 10/20: Parameter Support for Modules

Name: Parameter Implementation for modules
Author: Rusty Russell
Status: Tested on 2.5.38
Depends: Module/modbase-try-i386.patch.gz

D: This activates parameter parsing for PARAM() declarations in modules.

kernel/module.c +1 -3
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .29380-linux-2.5.36/kernel/module.c .29380-linux-2.5.36.updated/kernel/module.c
@@ -809,8 +809,7 @@ static struct module *load_module(void *
 	if (err < 0)
 		goto cleanup;
 
-#if 0 /* Needs param support */
-	/* Size of section 0 is 0, so this works well */
+	/* Size of section 0 is 0, so this works well if no params */
 	err = parse_args(mod->args,
 			 (struct kernel_param *)
 			 sechdrs[setupindex].sh_offset,
@@ -819,7 +818,6 @@ static struct module *load_module(void *
 			 NULL);
 	if (err < 0)
 		goto cleanup;
-#endif
 
 	/* Get rid of temporary copy */
 	vfree(hdr);

--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.