Serial 2/2
Quoted 5 lines
(quoted diff) +0
-0@@ -1582,10 +1583,10 @@ ret = -ENOMEM; }
Review line 1592
Quoted 10 lines
(quoted diff) +3
-3- if (ret) { - if (res_rsa) + if (ret == 0) { + if (res_rsa == 0) release_resource(res_rsa); - if (res) + if (res == 0) release_resource(res); } return ret;
definitely not.
if (res_rsa) release_resource(res_rsa);
will release the resource if we allocated it. your patch calls release_resource with an argument of NULL, and we'll leak the resource we allocated.
i'm not sure about the rest of your changes, but this one is definitely wrong.
Signature · 1 line
Revolutions do not require corporate support.
Quoted 2 lines · Matthew Wilcox
i'm not sure about the rest of your changes, but this one is definitely wrong.
I've sent Hu my proposed solution and I'm waiting to hear back.
Signature · 2 lines
Russell King ([email protected]) The developer of ARM Linux http://www.arm.linux.org.uk/personal/aboutme.html