vmalloc.c fix for 2.4.20-pre8-ac2
Subsystems (2)
PATCH 1/1 vmalloc.c fix for 2.4.20-pre8-ac2
Hi.
I noticed this when building 2.4.20-pre8-ac2 ...
gcc -D__KERNEL__ -I/usr/src/linux-2.4.20-pre8-ac2/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=i586 -nostdinc -iwithprefix include -DKBUILD_BASENAME=vmalloc -c -o vmalloc.o vmalloc.cvmalloc.c: In function `get_vm_area':
vmalloc.c:182: warning: passing arg 1 of `kfree' makes pointer from integer without a cast
vmalloc.c:173: warning: `addr' might be used uninitialized in this function
I peek at vmalloc.c shows what looks to be a typo. The variable 'area' is allocated by kmalloc(), and 'addr' is a local variable that hasn't been set. Trying to kfree() it would probably be a bad thing.
Art Haas
mm/vmalloc.c renamed from mm/vmalloc.c.ac2 +1 -1
@@ -179,7 +179,7 @@ size +=PAGE_SIZE ;if (!size) { -kfree (addr); +kfree (area);return NULL ; }
Signature · 3 lines
They that can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety. -- Benjamin Franklin, Historical Review of Pennsylvania, 1759