Bug in IEEE1394 implementation on PowerBooks [Patch address]
Hello again,
Since this is my first Linux patch, I'm not sure if what it does is OK, or even possible (but it works for me).
As this is kind of a specialist thing (FireWire on Apple laptops with Linux) I decided to put the patch on a web page:
http://anrp.irulethe.net/powerbook-ieee1394.html
Anyone with this setup (Apple Pbook + firewire) please test this patch.
Thanks,
Andrew Patrikalakis
-----
Beware of geeks thumbing for a ride.
Quoted 7 lines · Andrew Patrikalakis
Hello again,
Since this is my first Linux patch, I'm not sure if what it does is OK, or even possible (but it works for me).
Quoted 7 lines
As this is kind of a specialist thing (FireWire on Apple laptops with Linux) I decided to put the patch on a web page:
http://anrp.irulethe.net/powerbook-ieee1394.htmlAnyone with this setup (Apple Pbook + firewire) please test this patch.
Checked your patch, but there are several problems with it.
For one, it only takes into account one OHCI1394 card being installed. You'd be better of iterating over a list of all cards rather than hardcoding one card, but that's moot given point 2.
Secondly, it seems that the problem doesn't really lie in ohci1394, but that it actually has to do with the disk layer. From other usages of the pmu interface, it seems that your best example is in drivers/scsi/mesh.c and the change should be applied to sbp2.c.
If you need further help, you may want to talk to BenH (ppc maintainer).
Signature · 4 lines
Debian - http://www.debian.org/ Linux 1394 - http://www.linux1394.org/ Subversion - http://subversion.tigris.org/ Deqo - http://www.deqo.com/