Skip to contentSkip to conversation

keeping nfsd dentries on unused_list

DISCUSSION Christoph Hellwig 2 participants 2 messages Oct 21, 2002 VFS

lore
Share & tools
lore
#0 lore raw

Hi Neil,

since your export changes in 2.5.<early> always have a non-empty ->d_hash (linked into sb->s_anon) and thus are put on the unused list by dput instead of directly reclaiming it.

Is this behaviour intentional and will stay during 2.6? Keeping those dentries alive will allow me to remove lots of code in XFS to keep inodes that are written to by nfsd in cache as the final iput will flush all delayed allocated space and thus decrease nfs write performance massively - but as long as the dentry is on the unused list after dput we still have an inode reference and thus the delalloc block don't need to be converted.

#1 lore raw
Quoted 6 lines · On Monday October 21, [email protected] wrote:

Hi Neil,

since your export changes in 2.5.<early> always have a non-empty ->d_hash (linked into sb->s_anon) and thus are put on the unused list by dput instead of directly reclaiming it.

Quoted 7 lines

Is this behaviour intentional and will stay during 2.6? Keeping those dentries alive will allow me to remove lots of code in XFS to keep inodes that are written to by nfsd in cache as the final iput will flush all delayed allocated space and thus decrease nfs write performance massively - but as long as the dentry is on the unused list after dput we still have an inode reference and thus the delalloc block don't need to be converted.

Yes. That behaviour is intentional and will stay.

NeilBrown