Skip to contentSkip to conversation

de-cryptify ide-disk host protected area output

PATCH In review bert hubert 4 participants 4 messages Oct 26, 2002 – Nov 3, 2002

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 de-cryptify ide-disk host protected area output

Useless number '1' being printed leading to operator confusion.

drivers/ide/ide-disk.c renamed from drivers/ide/ide-disk.c~orig +1 -1
@@ -1128,7 +1128,7 @@
 {
 	int flag = (drive->id->cfs_enable_1 & 0x0400) ? 1 : 0;
 	if (flag)
-		printk("%s: host protected area => %d\n", drive->name, flag);
+		printk("%s: supports host protected area", drive->name);
 	return flag;
 }
 
Signature · 2 lines
http://www.PowerDNS.com          Versatile DNS Software & Services
http://lartc.org           Linux Advanced Routing & Traffic Control HOWTO
#1 lore raw

drivers/ide/ide-disk.c line 1133

Quoted 12 lines · bert hubert

Useless number '1' being printed leading to operator confusion.

drivers/ide/ide-disk.c renamed from drivers/ide/ide-disk.c~orig +1 -1
@@ -1128,7 +1128,7 @@
 {
 	int flag = (drive->id->cfs_enable_1 & 0x0400) ? 1 : 0;
 	if (flag)
-		printk("%s: host protected area => %d\n", drive->name, flag);
+		printk("%s: supports host protected area", drive->name);
 	return flag;
 }

Even better -- kill the prink entirely. If anyone really cares, they can run 'hdparm -I <drivename>' and get the exhaustive list of everything the drive supports....

-Erik

--
Erik B. Andersen http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--

#2 lore raw
Quoted 3 lines · Erik Andersen

Even better -- kill the prink entirely. If anyone really cares, they can run 'hdparm -I <drivename>' and get the exhaustive list of everything the drive supports....

Please leave it alone for now. There are a whole collection of extremely verbose and pointless IDE messages left, and I want them left until we are close to release, so we can debug stuff

In fact I will probably add more very soon

#3 lore raw
In reply to Erik Andersen

Agreed w/ Erik.

Quoted 18 lines · Erik Andersen

drivers/ide/ide-disk.c line 1133

Quoted 12 lines · bert hubert

Useless number '1' being printed leading to operator confusion.

drivers/ide/ide-disk.c renamed from drivers/ide/ide-disk.c~orig +1 -1
@@ -1128,7 +1128,7 @@
 {
 	int flag = (drive->id->cfs_enable_1 & 0x0400) ? 1 : 0;
 	if (flag)
-		printk("%s: host protected area => %d\n", drive->name, flag);
+		printk("%s: supports host protected area", drive->name);
 	return flag;
 }

Even better -- kill the prink entirely. If anyone really cares, they can run 'hdparm -I <drivename>' and get the exhaustive list of everything the drive supports....

Quoted 6 lines

-Erik

--
Erik B. Andersen http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--

Andre Hedrick
LAD Storage Consulting Group