Skip to contentSkip to conversation

PROBLEM REPORT 2.4.20-rc1: sundance.c

DISCUSSION Stephan von Krawczynski 2 participants 4 messages Oct 31, 2002 – Nov 2, 2002

lore
Share & tools
lore
#0 lore raw

Hello all,

I'd like to point out that (at least) the network driver sundance.c has weird flaws when trying to use more than MAX_UNITS (8) cards at the same time. Since this driver can be used for DFE-580TX 4 port network card it is really easy to get more than 8 ports :-)
In fact the driver does check against MAX_UNITS, but does _not_ fail if you go through the roof. Instead you can expect really interesting ifconfig-outputs ;-)
IMHO it should check and fail. I wonder what other card drivers do in such a case ...

Signature · 2 lines
Regards,
Stephan
#1 lore raw

Re: PROBLEM REPORT 2.4.20-rc1: sundance.c (OT: userspace)

... and to have even more fun:
"ifconfig" coming with SuSE 8.1 produces broken output list if there is ethX with X>9.
(just in case someone is listening ... ;-)

Signature · 2 lines
Regards,
Stephan
#2 lore raw
In reply to Stephan von Krawczynski
Quoted 5 lines · Stephan von Krawczynski

Hello all,

I'd like to point out that (at least) the network driver sundance.c has weird flaws when trying to use more than MAX_UNITS (8) cards at the same time. Since

Smileys nonwithstanding, you need to include far more information

Please define "weird flaws"... explicitly.

Quoted 9 lines

this driver can be used for DFE-580TX 4 port network card it is really easy to get more than 8 ports :-)
In fact the driver does check against MAX_UNITS, but does _not_ fail if you go through the roof. Instead you can expect really interesting ifconfig-outputs ;-)
IMHO it should check and fail. I wonder what other card drivers do in such a case ...

Other card drivers handle this case just fine. The expected behavior is that module options will only support up to MAX_UNITS of certain arguments, but beyond that nothing is affected at all.

Jeff

#3 lore raw
Quoted 4 lines · On Thu, 31 Oct 2002 16:04:10 -0500 Jeff Garzik <[email protected]> wrote:
Quoted 2 lines · Stephan von Krawczynski

Hello all,

Quoted 8 lines
Quoted 4 lines

I'd like to point out that (at least) the network driver sundance.c has weird flaws when trying to use more than MAX_UNITS (8) cards at the same time. Since

Smileys nonwithstanding, you need to include far more information

Please define "weird flaws"... explicitly.

I am experiencing dropped packets as sundance RX side when simple nfs copying takes places. These are at a rate of about 1-2% of RX packets. I call it "weird" because I cannot see a definitive problem location in the driver source. fact stays one simple copy drops packets, something I never saw in the same setup (same cabling, same mainboard) with tulip cards.
I know that this is a hell of a "bug-report", but I really want to point out only a strange difference between tulip-setup and sundance-setup.

Signature · 2 lines
Regards,
Stephan