Patch(2.5.45): move io_restrictions to blkdev.h
Quoted 9 lines · Jens Axboe
Quoted 4 lines · Adam J. Richter
This patch makes good on a threat that I posted yesterday
to move structio_restrictionsfrom <linux/device-mapper.h> to <linux/blkdev.h>, eliminating duplication of a list of fields in structrequest_queue.Adam, I generally think the patch is a good idea. I also think it's a very stupid time to start messing with stuff that is basically trivial but still touches lost of stuff.
It's pretty much simple string substitution and it doesn't
touch that many files, but OK.
Quoted 5 lines
Please leave it alone for a few weeks.
Quoted 1 line
Jens, can I persuade you to integrate this change?
In due time, yes.
Great. The only thing I was going to do that might depend
on this patch is try to port /dev/loop to device mapper, and I may be able to eliminate the affected code anyhow.
I've checked in the change and will continue running it in the
meantime. Unless I hear otherwise or run into a problem with this patch, I'll plan to resubmit it around November 24.
Adam J. Richter __ ______________ 575 Oroville Road [email protected] \ / Milpitas, California 95035 +1 408 309-6081 | g g d r a s i l United States of America
"Free Software For The Rest Of Us."
Quoted 3 lines · Adam J. Richter
Great. The only thing I was going to do that might depend
on this patch is try to port/dev/loopto device mapper, and I may be able to eliminate the affected code anyhow.
This makes me uneasy, do you mean you want to:
i) make a 'loop' target, if so why ?
ii) or that you want to rewrite loop so that it sits on top of dm -
ie. you create a set of linear mappings that correspond to the
file ? This would only be sensible if there is significant
simplification/reduction of the loop code, and probably would never work because of tail packing.
I'm not keen on either of these ideas.
- Joe