Fix undeclared NULL in timer.h

PATCH In review Rusty Russell 3 participants 3 messages Nov 4, 2002 High-resolution timers, timer wheel, clockevents

lore

Share & tools

lore

Rusty Russell

author

2002-11-04 08:32 UTC #0 lore raw

PATCH 1/1 Fix undeclared NULL in timer.h

Uncovered on a PPC compile: timer.h uses NULL, so needs stddef.h

include/linux/timer.h +1 -0

diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .22822-2.5.45-bk-module-ppc.pre/include/linux/timer.h .22822-2.5.45-bk-module-ppc/include/linux/timer.h
@@ -3,6 +3,7 @@
 
 #include <linux/config.h>
 #include <linux/list.h>
+#include <linux/stddef.h>
 
 struct tvec_t_base_s;

--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

Denis Vlasenko

2002-11-04 11:39 UTC #1 lore raw

Quoted 11 lines · Rusty Russell

Uncovered on a PPC compile: timer.h uses NULL, so needs stddef.h
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .22822-2.5.45-bk-module-ppc.pre/include/linux/timer.h .22822-2.5.45-bk-module-ppc/include/linux/timer.h ---
.22822-2.5.45-bk-module-ppc.pre/include/linux/timer.h 2002-10-31
12:37:02.000000000 +1100 +++
.22822-2.5.45-bk-module-ppc/include/linux/timer.h 2002-11-04
18:28:53.000000000 +1100 @@ -3,6 +3,7 @@

Quoted 5 lines

#include <linux/config.h>
#include <linux/list.h>
+#include <linux/stddef.h>
struct tvec_t_base_s;

The whole problem of #include forest going out of control needs some clever solution or we will eternally chase missing .h files
--
vda

Dave Jones

2002-11-04 14:22 UTC #2 lore raw

Quoted 3 lines · Denis Vlasenko

The whole problem of #include forest going out of control needs some clever solution or we will eternally chase missing .h files

Doing an untangle at this point is pretty much a waste of effort. As we get closer to stabilising, we can regenerate the dependancy graphs and see what looks out of place again.

Adding lots of #include's isn't an issue as long as those includes aren't sucking in 200 others.

Dave

Signature · 1 line

| Dave Jones.        http://www.codemonkey.org.uk