aty128fb.c does not compile in linux 2.5.46

Hi.

I don't know if its currently considered important, but just for the record.
Please CC any replies to me, since I am not subscribed to the list.

I'm running an AMD Duron/Via kt133, with Debian testing. Nothing unusual that
I am aware of. If I choose to use the ATI Rage128 framebuffer console, I get
the following compile error:

gcc -Wp,-MD,drivers/video/.aty128fb.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4 -Iarch/i386/mach-generic
-nostdinc -iwithprefix include -DKBUILD_BASENAME=aty128fb -c -o
drivers/video/aty128fb.o drivers/video/aty128fb.c drivers/video/aty128fb.c:419: unknown field `fb_get_fix' specified in initializer
drivers/video/aty128fb.c:419: warning: initialization from incompatible pointer type
drivers/video/aty128fb.c:420: unknown field `fb_get_var' specified in initializer
drivers/video/aty128fb.c:420: warning: initialization from incompatible pointer type
drivers/video/aty128fb.c: In function `aty128fb_set_var':
drivers/video/aty128fb.c:1379: structure has no member named visual' drivers/video/aty128fb.c:1380: structure has no member named type' drivers/video/aty128fb.c:1381: structure has no member named type_aux' drivers/video/aty128fb.c:1382: structure has no member named ypanstep' drivers/video/aty128fb.c:1383: structure has no member named ywrapstep' drivers/video/aty128fb.c:1384: structure has no member named line_length'
make[2]: *** [drivers/video/aty128fb.o] Error 1
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2

Cheers
Neilen

Yep. There was a recent fbdev API rewrite, not all of the drivers have been converted yet. (The radeonfb driver, eg, does this too.)

You can fix it by looking at the changesets from the PPC Bitkeeper tree at http://ppc.bkbits.net:8080/linuxppc-2.5 ... the changes are fairly straightforward, I did this and got radeonfb working under 2.5.45.

Matt

Cool. Ben would the ppc guys mind if I grab those files and placed them into my latest BK tree. The reason is I want to make them work with the latest changes for fbdev.