Skip to contentSkip to conversation

RFC: [2.5 patch] Create a "Subarchitecture" menu

PATCH Adrian Bunk 1 participant 1 message Nov 16, 2002

lore
Share & tools
lore
#0 lore raw

My impression is that it's currently easy to accidentially activate the Voyager support in 2.5.47 by typing once too often "y" which results in a kernel that doesn't boot on a PC. The patch below is a suggestion to to create a "Subarchitecture" choice.

The wording might not be perfect and it might make sense to add other subarchs there, too. I'm interested in comments whether this is a good idea or whether there are reasons why this is a bad idea.

TIA
Adrian

arch/i386/Kconfig renamed from arch/i386/Kconfig.old +31 -12
@@ -39,7 +39,33 @@
 menu "Processor type and features"
 
 choice
+	prompt "Subarchitecture"
+	default PC
+
+config PC
+	bool "PC"
+	help
+	  Choose this option if your computer is a PC.
+
+	  Choose this option unless you really know what you are doing.
+
+config VOYAGER
+	bool "Support for the NCR Voyager Architecture"
+	help
+	  Voyager is a MCA based 32 way capable SMP architecture proprietary
+	  to NCR Corp.  Machine classes 345x/35xx/4100/51xx are voyager based.
+  
+	  *** WARNING ***
+
+	  If you do not specifically know you have a Voyager based machine,
+	  don't choose this option otherwise the kernel you build will not
+	  be bootable.
+
+endchoice
+
+choice
 	prompt "Processor family"
+	depends on PC
 	default M686
 
 config M386
@@ -980,17 +1006,6 @@
 
 menu "Bus options (PCI, PCMCIA, EISA, MCA, ISA)"
 
-config VOYAGER
-	bool "Support for the NCR Voyager Architecture"
-	depends on MCA
-	help
-	  Voyager is a MCA based 32 way capable SMP architecture proprietary
-	  to NCR Corp.  Machine classes 345x/35xx/4100/51xx are voyager based.
-  
-	  *** WARNING ***
-
-	  If you do not specifically know you have a Voyager based machine,
-	  say N here otherwise the kernel you build will not be bootable.
 
 # Visual Workstation support is utterly broken.
 # If you want to see it working mail an VW540 to [email protected] 8)
@@ -1102,8 +1117,12 @@
 	  Otherwise, say N.
 
 config MCA
+	bool
+	depends on VOYAGER
+
+config MCA
 	bool "MCA support"
-	depends on !VISWS
+	depends on !VISWS && !VOYAGER
 	help
 	  MicroChannel Architecture is found in some IBM PS/2 machines and
 	  laptops.  It is a bus system similar to PCI or ISA. See