hugetlbpage.c build failure?
I see the following build failure in bk current:
gcc -Wp,-MD,arch/i386/mm/.hugetlbpage.o.d -D__KERNEL__ -Iinclude -Wall
-Wstric
t-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-po
inter -pipe -g -mpreferred-stack-boundary=2 -march=athlon -Iarch/i386/mach-gener
ic -nostdinc -iwithprefix include -DKBUILD_BASENAME=hugetlbpage
-DKBUILD_MODN
AME=hugetlbpage -c -o arch/i386/mm/hugetlbpage.oarch/i386/mm/hugetlbpage.c
arch/i386/mm/hugetlbpage.c:610: parse error before '*' token arch/i386/mm/hugetlbpage.c: In function `hugetlb_sysctl_handler':arch/i386/mm/hugetlbpage.c:611: number of arguments doesn't match prototypeinclude/linux/hugetlb.h:14: prototype declaration arch/i386/mm/hugetlbpage.c:612: warning: implicit declaration of function `proc_
dointvec'arch/i386/mm/hugetlbpage.c:612: `table' undeclared (first use in this function)arch/i386/mm/hugetlbpage.c:612: (Each undeclared identifier is reported only onc
earch/i386/mm/hugetlbpage.c:612: for each function it appears in.) arch/i386/mm/hugetlbpage.c:612: `write' undeclared (first use in this function)arch/i386/mm/hugetlbpage.c:612: `file' undeclared (first use in this function)arch/i386/mm/hugetlbpage.c:612: `buffer' undeclared (first use in this function)arch/i386/mm/hugetlbpage.c:612: `length' undeclared (first use in this function)
make[1]: *** [arch/i386/mm/hugetlbpage.o] Error 1
make: *** [arch/i386/mm] Error 2
Signature · 1 line
Kevin
Quoted 1 line · Kevin Brosius
I see the following build failure in bk current:
If you get those problems fixed, you're going to need this patch too :)
greg k-h
fs/hugetlbfs/inode.c +2 -2
@@ -209,7 +209,7 @@if (inode->i_data.nrpages)truncate_hugepages (&inode->i_data,0 ); - security_ops->inode_delete (inode); +security_inode_delete (inode);clear_inode (inode);destroy_inode (inode);
@@ -333,7 +333,7 @@if (error) goto out; - error = security_ops->inode_setattr (dentry, attr); + error =security_inode_setattr (dentry, attr);if (error) goto out;
Quoted 1 line · Kevin Brosius
arch/i386/mm/hugetlbpage.c:610: parse error before '*' token
The patch below fixed this for me
===== arch/i386/mm/hugetlbpage.c 1.17 vs edited =====
arch/i386/mm/hugetlbpage.c Wed Nov 27 19:18:23 2002 renamed from arch/i386/mm/hugetlbpage.c Thu Nov 14 23:03:02 2002 +1 -0
@@ -14,6 +14,7 @@ #include <linux/slab.h> #include <linux/module.h> #include <linux/err.h> +#include <linux/sysctl.h> #include <asm/mman.h> #include <asm/pgalloc.h>
Quoted 11 lines · Arnd Bergmann
Quoted 1 line · Kevin Brosius
arch/i386/mm/hugetlbpage.c:610: parse error before '*' tokenThe patch below fixed this for me
=====
arch/i386/mm/hugetlbpage.c1.17 vs edited =====
arch/i386/mm/hugetlbpage.c Wed Nov 27 19:18:23 2002 line 19
Quoted 6 lines
arch/i386/mm/hugetlbpage.c Wed Nov 27 19:18:23 2002 renamed from arch/i386/mm/hugetlbpage.c Thu Nov 14 23:03:02 2002 +1
-0@@ -14,6 +14,7 @@ #include <linux/slab.h> #include <linux/module.h> #include <linux/err.h> +#include <linux/sysctl.h> #include <asm/mman.h> #include <asm/pgalloc.h>
Thanks guys, that does it here. Greg, was yours a run time fix? I don't see any difference during build.
Signature · 1 line
Kevin
Quoted 8 lines · Kevin Brosius
Quoted 7 lines · Arnd Bergmann
Quoted 1 line · Kevin Brosius
arch/i386/mm/hugetlbpage.c:610: parse error before '*' tokenThe patch below fixed this for me
Quoted 13 lines
arch/i386/mm/hugetlbpage.c Wed Nov 27 19:18:23 2002 line 19
Quoted 10 lines
=====
arch/i386/mm/hugetlbpage.c1.17 vs edited =====arch/i386/mm/hugetlbpage.c Wed Nov 27 19:18:23 2002 renamed from arch/i386/mm/hugetlbpage.c Thu Nov 14 23:03:02 2002 +1
-0@@ -14,6 +14,7 @@ #include <linux/slab.h> #include <linux/module.h> #include <linux/err.h> +#include <linux/sysctl.h> #include <asm/mman.h> #include <asm/pgalloc.h>Thanks guys, that does it here. Greg, was yours a run time fix? I don't see any difference during build.
Should be needed during building, but I don't know the .config options that are necessary for it to be needed, sorry.
greg k-h