Skip to contentSkip to conversation

named struct initialiser updates

PATCH Geert Uytterhoeven 2 participants 2 messages Nov 29, 2002 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Geert Uytterhoeven

author
#1 lore raw
Quoted 10 lines · Linux Kernel Mailing List

ChangeSet 1.842.43.47, 2002/11/25 18:40:22-08:00, [email protected]

[PATCH] named struct initialiser updates

diff -Nru a/drivers/video/fbcon.c b/drivers/video/fbcon.c

drivers/video/fbcon.c +0 -0
@@ -230,8 +230,9 @@

drivers/video/fbcon.c line 238

Quoted 10 lines
drivers/video/fbcon.c +3 -2
 static void cursor_timer_handler(unsigned long dev_addr);
 
-static struct timer_list cursor_timer =
-		TIMER_INITIALIZER(cursor_timer_handler, 0, 0);
+static struct timer_list cursor_timer = {
+    function: cursor_timer_handler
+};
 
 static void cursor_timer_handler(unsigned long dev_addr)
 {

Doesn't this part reverse the timer initializer fix?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#2 lore raw
Quoted 5 lines · Geert Uytterhoeven
Quoted 5 lines

diff -Nru a/drivers/video/fbcon.c b/drivers/video/fbcon.c

drivers/video/fbcon.c +0 -0
@@ -230,8 +230,9 @@
Quoted 8 lines

drivers/video/fbcon.c line 235

Quoted 7 lines
drivers/video/fbcon.c +3 -2
 static void cursor_timer_handler(unsigned long dev_addr);
 
-static struct timer_list cursor_timer =
-		TIMER_INITIALIZER(cursor_timer_handler, 0, 0);
+static struct timer_list cursor_timer = {
+    function: cursor_timer_handler
+};

Doesn't this part reverse the timer initializer fix?

Looks like it. I'll take a look later.

Dave

Signature · 2 lines
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs