Skip to contentSkip to conversation

generic HDLC update for 2.4.21-pre

PATCH In review Krzysztof Halasa 2 participants 3 messages Dec 2, 2002 – Dec 3, 2002

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 generic HDLC update for 2.4.21-pre

Hi,

Alan, Marcelo:

I've uploaded the HDLC update discussed here to:
ftp://hq.pm.waw.pl/pub/linux/hdlc/current/hdlc-2.4.20.patch.gz

This patch is essentially a downport from current 2.5 kernel line, which means quite a big rewrite and a binary incompatibility of userspace utility "sethdlc".

There seem to be an agreement that this patch should be applied to 2.4, despite the compatibility problem. Most users are already using the updated version anyway (my own hw drivers only support 2 older ISA cards, while manufacturers of newer cards have drivers working only with the newer code).

The new code isn't really that new, it has been in use for over a year.

This patch doesn't change anything outside "generic HDLC" area (except that it adds a new SIOCWANDEV net device ioctl, which is used instead of various SIOCDEVPRIVATEs, but it's a trivial change).

Please apply to 2.4. Thanks.

Francois: I hope the dscc4 driver from 2.5 is ok. It compiles cleanly (not counting the __setup warning if built as a module), but I have no hw to test it. I'd be glad if you check it's working correctly. Thanks.

Signature · 2 lines
Krzysztof Halasa
Network Administrator
#1 lore raw

Krzysztof Halasa <[email protected]> :
[...]

Quoted 3 lines

Francois: I hope the dscc4 driver from 2.5 is ok. It compiles cleanly (not counting the __setup warning if built as a module), but I have no hw to test it. I'd be glad if you check it's working correctly. Thanks.

I'd rather avoid pushing the 2.5.x core code for the dscc4 chipset in 2.4 now as some side of it still suck. Is it fine to wait for me to update current 2.4.x dscc4 code to new api ? ETA = now + a few days at worst.

Btw if someone can get in touch with Infineon, it would be interesting to know if recent releases of the chipset still behaves as the old ones (I only have rather old ones).

Regards

--
Ueimor

#2 lore raw
Quoted 4 lines · Francois Romieu

I'd rather avoid pushing the 2.5.x core code for the dscc4 chipset in 2.4 now as some side of it still suck. Is it fine to wait for me to update current 2.4.x dscc4 code to new api ? ETA = now + a few days at worst.

I can see no problem with that, as long as we are at early 2.4.21 stages.

Signature · 2 lines
Krzysztof Halasa
Network Administrator