Skip to contentSkip to conversation

2.5.50 apm.c better printk messages about workaround.

PATCH Hiroshi Miura 1 participant 1 message Dec 5, 2002

lore
Share & tools
lore
#0 lore raw

Sorry,
I mistake in my patch.
I add '\n' now.

Quoted 4 lines

I post patch about work around for a broken bios. Pavel comments and i think it is reasonable and better.

this patch fix printk message in 2.5.50.

arch/i386/kernel/apm.c +5 -3
@@ -2054,12 +2054,14 @@
 			_set_limit((char *)&cpu_gdt_table[i][APM_DS >> 3],
 				(apm_info.bios.dseg_len - 1) & 0xffff);
 		      /* workaround for broken BIOSes */
-	                if (apm_info.bios.cseg_len <= apm_info.bios.offset)
+	                if (apm_info.bios.cseg_len <= apm_info.bios.offset) {
         	                _set_limit((char *)&cpu_gdt_table[i][APM_CS >> 3], 64 * 1024 -1);
-                       if (apm_info.bios.dseg_len <= 0x40) { /* 0x40 * 4kB == 64kB */
+				printk(KERN_WARNING "apm: broken bios -- code segment too short, assuming 64k.\n");
+			}
+                        if (apm_info.bios.dseg_len <= 0x40) { /* 0x40 * 4kB == 64kB */
                         	/* for the BIOS that assumes granularity = 1 */
                         	cpu_gdt_table[i][APM_DS >> 3].b |= 0x800000;
-                        	printk(KERN_NOTICE "apm: we set the granularity of dseg.\n");
+                        	printk(KERN_WARNING "apm: broken bios -- assuming granularity 1 on dseg.\n");
         	        }
 		}
 #endif
Signature · 4 lines
Hiroshi Miura  --- http://www.da-cha.org/ 
NTTDATA Corp. Marketing & Business Strategy Planning Dept. --- [email protected] 
Key fingerprint = 9117 9407 5684 FBF1 4063  15B4 401D D077 04AB 8617
-- My hacking life is happy as the day is long