Skip to contentSkip to conversation

link error

2.5.50, ACPI Shawn Starr 3 participants 5 messages Dec 4, 2002 – Dec 8, 2002 3 messages not in the archive

lore
Share & tools
lore

Shawn Starr

author
#0 lore raw

Thats what I thought until Pavel told me SOFTWARE_SUSPEND requires ACPI_SLEEP and ACPI_SLEEP should not be unchecked if SOFTWARE_SUSPEND is disabled.

My patch was only to fix a link error in 2.5.49/50. A better solution is needed :-)

Shawn.

Quoted 2 lines
List:     linux-kernel
Subject:  Re: [2.5.50, ACPI] link error

From: Roman Zippel <[email protected]>

Quoted 42 lines

Date: 2002-12-04 20:29:08
[Download message RAW]

Hi,

On Wed, 4 Dec 2002, Adrian Bunk wrote:

In drivers/acpi/Config.in in 2.5.44:

<-- snip -->

...
if [ "$CONFIG_ACPI_HT_ONLY" != "y" ]; then
bool ' Sleep States' CONFIG_ACPI_SLEEP
...
define_bool CONFIG_ACPI_SLEEP $CONFIG_SOFTWARE_SUSPEND
...
fi
...

<-- snip -->

This double definition was at least confusing, a simple

dep_bool ' Sleep States' CONFIG_ACPI_SLEEP $CONFIG_SOFTWARE_SUSPEND

would have expressed it better.

It's not really the same and the first probably heavily confuses xconfig. If CONFIG_SOFTWARE_SUSPEND can do without CONFIG_ACPI_SLEEP, the second version should work fine.

config ACPI_SLEEP
bool "Sleep States"

(quoted diff) +1 -1
-     depends on X86 && ACPI && !ACPI_HT_ONLY
+     depends on X86 && ACPI && !ACPI_HT_ONLY && SOFTWARE_SUSPEND
      default SOFTWARE_SUSPEND
      ---help---
        This option adds support for ACPI suspend states.

The default is probably not needed anymore.

Signature · 8 lines
Shawn Starr
UNIX Systems Administrator, Operations
Datawire Communication Networks Inc.
10 Carlson Court, Suite 300
Toronto, ON, M9W 6L2
T: 416-213-2001 ext 179  F: 416-213-2008
[email protected]
"The power to Transact" - http://www.datawire.net
#1 lore raw

Hi,

Quoted 2 lines · Shawn Starr

Thats what I thought until Pavel told me SOFTWARE_SUSPEND requires ACPI_SLEEP and ACPI_SLEEP should not be unchecked if SOFTWARE_SUSPEND is disabled.

Is there then any reason to ask the user for ACPI_SLEEP?

bye, Roman

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

Hi,

Quoted 5 lines · Shawn Starr

ACPI_SLEEP should only be required if the user selects SOFTWARE_SUSPEND. Otherwise if the user selects only ACPI_SLEEP then they don't get software suspend mode (S3).

Then problem is, I can't figure out how to get Kconfig to do this ;-(

This should do it:

config ACPI_SLEEP
bool "Sleep States" if !SOFTWARE_SUSPEND
default SOFTWARE_SUSPEND
depends on X86

bye, Roman

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw

Hi,

Quoted 4 lines · Shawn Starr

if ACPI_SLEEP = selected then display SOFTWARE_SUSPEND else if SOFTWARE_SUSPEND selected select ACPI_SLEEP else if ACPI_SLEEP unselected unselect SOFTWARE_SUSPEND endif

Recursive dependencies are not allowed, the parser currently accepts them silently, but that will change.
Anyway, I don't really understand above, SOFTWARE_SUSPEND can only be selected if ACPI_SLEEP sleep is selected, so why should it select ACPI_SLEEP?
Could you please make a table of all possible combinations?

bye, Roman

#7 lore raw
In reply to Shawn Starr
Quoted 2 lines

Thats what I thought until Pavel told me SOFTWARE_SUSPEND requires ACPI_SLEEP and ACPI_SLEEP should not be unchecked if SOFTWARE_SUSPEND is disabled.

Did I say that? That is wrong, sorry. acpi_sleep
should require swsusp but not the other way
round.

Signature · 2 lines
				Pavel
Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...