Old Debian patches
Hello!
As promised, we've been trying to track down some of the old patches lying around in our package for quite soem time. We'd like you guys to see if they are still needed so you can apply them upstream, or we can get rid of them.
Bug#141114: improper call to snd_power_lock in ppc (reported against
beta12).
Jack Howarth reported:
Quoted 8 lines
On debian ppc sid, the new alsa-source 0.9beta12-1 doesn't build the powermac sound driver properly. The current source has an improper call to
snd_power_lockwhich has changed its api. Also the powermac driver builds with unresolved symbols for udelay and mdelay. The attached patch needs to be added to the current alsa-source 0.9+beta12 debian sources to resolve these issues. With this patch the powermac sound module builds and operates fine under Linux 2.4.19pre5.
alsa-kernel/ppc/keywest.c Sun May 12 20:56:25 2002 renamed from alsa-kernel/ppc/keywest.c Mon Feb 25 20:50:13 2002 +1 -0
@@ -21,6 +21,7 @@ #include <sound/driver.h> #include <linux/init.h> +#include <linux/delay.h> #include <linux/i2c.h> #include <linux/i2c-dev.h> #include <linux/slab.h>
-----
Bug#167633: usbaudio fails to build on 2.2 kernels (reported against
rc5)
Aaron M. Ucko provided the following fix:
usr/src/modules/alsa-driver/usb/usbaudio.c 2002-11-03 19:43:22.000000000 -0 renamed from usr/src/modules/alsa-driver/usb/usbaudio.c~ 2002-10-10 08:25:03.0000 +1 -0
@@ -171,6 +171,7 @@ void snd_compat_usb_driver_claim_interface(struct snd_compat_usb_driver *driver { + struct snd_usb_reg_table *tbl; if ((tbl = find_matchingUsb_driver(driver)) != NULL) usb_driver_claim_interface(&tbl->driver, iface, ptr); }
-----
Bug#142693: depmod problem with provided isapnp (reported against
beta12)
"K-Bay" reported:
Quoted 4 lines
After initialisation of ALSA version 0.9b12 the depmod complains about problems in snd-isapnp module.
The following patch should get rid of the problem:
isapnp.c.fix Mon Apr 8 11:18:13 2002 renamed from isapnp.c Sat Feb 9 19:30:13 2002 +1 -1
@@ -2094,7 +2094,7 @@ static void isapnp_release_resource(struct resource *res) { if (res) { - release_resource(res); + isapnp_release_resource(res); kfree(res); } }
We never got feedback from the user when we took over ALSA, so it was never applied. I don't know if it's needed/valid.
That's all for the moment.
Jordi
Signature · 3 lines
Jordi Mallach Pérez -- Debian developer http://www.debian.org/ [email protected] [email protected] http://www.sindominio.net/ GnuPG public key information available at http://oskuro.net/~jordi/
Takashi Iwai
AppliedHi Jordi,
thanks for the patches!
At Sat, 21 Dec 2002 16:17:22 +0100,
Quoted 10 lines · Jordi Mallach
Hello!
As promised, we've been trying to track down some of the old patches lying around in our package for quite soem time. We'd like you guys to see if they are still needed so you can apply them upstream, or we can get rid of them.
Bug#141114: improper call to
snd_power_lockin ppc (reported againstbeta12).
already fixed.
Quoted 16 lines
Jack Howarth reported:
Quoted 8 lines
On debian ppc sid, the new alsa-source 0.9beta12-1 doesn't build the powermac sound driver properly. The current source has an improper call to
snd_power_lockwhich has changed its api. Also the powermac driver builds with unresolved symbols for udelay and mdelay. The attached patch needs to be added to the current alsa-source 0.9+beta12 debian sources to resolve these issues. With this patch the powermac sound module builds and operates fine under Linux 2.4.19pre5.
alsa-kernel/ppc/keywest.c Sun May 12 20:56:25 2002 line 27
Quoted 7 lines
alsa-kernel/ppc/keywest.c Sun May 12 20:56:25 2002 renamed from alsa-kernel/ppc/keywest.c Mon Feb 25 20:50:13 2002 +1
-0@@ -21,6 +21,7 @@ #include <sound/driver.h> #include <linux/init.h> +#include <linux/delay.h> #include <linux/i2c.h> #include <linux/i2c-dev.h> #include <linux/slab.h>
applied to cvs now.
Quoted 10 lines
-----
Bug#167633: usbaudio fails to build on 2.2 kernels (reported againstrc5)Aaron M. Ucko provided the following fix:
usr/src/modules/alsa-driver/usb/usbaudio.c 2002-11-03 19:43:22.000000000 -0 line 177
Quoted 7 lines
usr/src/modules/alsa-driver/usb/usbaudio.c 2002-11-03 19:43:22.000000000 -0 renamed from usr/src/modules/alsa-driver/usb/usbaudio.c~ 2002-10-10 08:25:03.0000 +1
-0@@ -171,6 +171,7 @@ void snd_compat_usb_driver_claim_interface(struct snd_compat_usb_driver *driver { + struct snd_usb_reg_table *tbl; if ((tbl = find_matchingUsb_driver(driver)) != NULL) usb_driver_claim_interface(&tbl->driver, iface, ptr); }
already fixed.
Quoted 23 lines
-----
Bug#142693: depmod problem with provided isapnp (reported againstbeta12)"K-Bay" reported:
Quoted 4 lines
After initialisation of ALSA version 0.9b12 the depmod complains about problems in snd-isapnp module.
The following patch should get rid of the problem:
isapnp.c.fix Mon Apr 8 11:18:13 2002 renamed from isapnp.c Sat Feb 9 19:30:13 2002 +1
-1@@ -2094,7 +2094,7 @@ static void isapnp_release_resource(struct resource *res) { if (res) { - release_resource(res); + isapnp_release_resource(res); kfree(res); } }
Quoted 2 lines
We never got feedback from the user when we took over ALSA, so it was never applied. I don't know if it's needed/valid.
apparently this will cause an infinite loop, won't it? i haven't seen any isapnp-problems on my 2.2 environment...
so, skipped now.
thanks,
Takashi
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
Quoted 1 line · Takashi Iwai
thanks for the patches!
Thanks for reviewing :)
Quoted 17 lines
Quoted 17 lines
Quoted 4 lines
After initialisation of ALSA version 0.9b12 the depmod complains about problems in snd-isapnp module.
The following patch should get rid of the problem:
isapnp.c.fix Mon Apr 8 11:18:13 2002 renamed from isapnp.c Sat Feb 9 19:30:13 2002 +1
-1@@ -2094,7 +2094,7 @@ static void isapnp_release_resource(struct resource *res) { if (res) { - release_resource(res); + isapnp_release_resource(res); kfree(res); } }
Quoted 5 lines
Quoted 2 lines
We never got feedback from the user when we took over ALSA, so it was never applied. I don't know if it's needed/valid.
apparently this will cause an infinite loop, won't it? i haven't seen any isapnp-problems on my 2.2 environment... so, skipped now.
Ok. As I said, I've asked the submitter to check against recent alsa verisons and never got new feedback, so we'll just close the bug. If it's still there he can always reopen.
Jordi
Signature · 3 lines
Jordi Mallach Pérez -- Debian developer http://www.debian.org/ [email protected] [email protected] http://www.sindominio.net/ GnuPG public key information available at http://oskuro.net/~jordi/