Skip to contentSkip to conversation

2.4.21pre2aa2

DISCUSSION Andrea Arcangeli 4 participants 5 messages Dec 26, 2002 – Jan 14, 2003

lore
Share & tools
lore
#0 lore raw

I'm leaving for vacations in 5 minutes so hopefully this will compile for everybody ;) [I know, mylex still doesn't compile without backing out the elevator-lowlatency patch but I hadn't time to fix it yet], I'll be back online on 3 Jan.

URL:

	http://www.us.kernel.org/pub/linux/kernel/people/andrea/kernels/v2.4/2.4.21pre2aa2.gz
	http://www.us.kernel.org/pub/linux/kernel/people/andrea/kernels/v2.4/2.4.21pre2aa2/

diff between 2.4.21pre2aa1 and 2.4.21pre2aa2:

Only in 2.4.21pre2aa1: 10_rawio-vary-io-15
Only in 2.4.21pre2aa2: 10_rawio-vary-io-16

Fix compilation.

Andrea

#1 lore raw
Quoted 5 lines · Andrea Arcangeli

I'm leaving for vacations in 5 minutes so hopefully this will compile for everybody ;) [I know, mylex still doesn't compile without backing out the elevator-lowlatency patch but I hadn't time to fix it yet], I'll be back online on 3 Jan.

Have a nice break.

Quoted 1 line

http://www.us.kernel.org/pub/linux/kernel/people/andrea/kernels/v2.4/2.4.21pre2aa2.gz

Makefile still says aa1...

--
Eyal Lebedinsky ([email protected]) <http://samba.org/eyal/>

#2 lore raw
In reply to Andrea Arcangeli
Quoted 4 lines · Andrea Arcangeli

I'm leaving for vacations in 5 minutes so hopefully this will compile for everybody ;) [I know, mylex still doesn't compile without backing out the elevator-lowlatency patch but I hadn't time to fix it yet], I'll be back online on 3 Jan.

Hmm. Where is init_one_highpage() defined?

Thanks,
Bill

$ grep -nr init_one_highpage .                   
./arch/i386/mm/discontig.c:47:extern void init_one_highpage(struct page *, int, int);
./arch/i386/mm/discontig.c:297:                 init_one_highpage((struct page *) (zone_mem_map + node_pfn), zone_start_pfn + node_pfn, bad_ppro);
Binary file ./arch/i386/mm/discontig.o matches
Binary file ./arch/i386/mm/mm.o matches
#3 lore raw
Quoted 7 lines · William Lee Irwin III
Quoted 4 lines · Andrea Arcangeli

I'm leaving for vacations in 5 minutes so hopefully this will compile for everybody ;) [I know, mylex still doesn't compile without backing out the elevator-lowlatency patch but I hadn't time to fix it yet], I'll be back online on 3 Jan.

Hmm. Where is init_one_highpage() defined?

I assumed it got dropped while upgrading to new mainline trees, Marcelo merged parts of the arch init cleanup and probably init_one_highpage was missing from those patches merged in mainline despite most other things were present. Thanks for the info (I will now go find where it was lost).

Andrea

#4 lore raw
Quoted 7 lines · On 2003.01.14 Andrea Arcangeli wrote:
Quoted 6 lines · William Lee Irwin III
Quoted 4 lines · Andrea Arcangeli

I'm leaving for vacations in 5 minutes so hopefully this will compile for everybody ;) [I know, mylex still doesn't compile without backing out the elevator-lowlatency patch but I hadn't time to fix it yet], I'll be back online on 3 Jan.

Quoted 7 lines
Quoted 1 line

Hmm. Where is init_one_highpage() defined?

I assumed it got dropped while upgrading to new mainline trees, Marcelo merged parts of the arch init cleanup and probably init_one_highpage was missing from those patches merged in mainline despite most other things were present. Thanks for the info (I will now go find where it was lost).

Perhaps it is just a mutant ?

vi +449 arch/i386/mm/init.c

BTW, could you apply this, to get in sync with 2.5 ?

arch/i386/mm/init.c +7 -14
@@ -442,21 +442,14 @@ static inline int page_kills_ppro(unsign
 #ifdef CONFIG_HIGHMEM
 void __init one_highpage_init(struct page *page, int pfn, int bad_ppro)
 {
-	if (!page_is_ram(pfn)) {
+	if (page_is_ram(pfn) && !(bad_ppro && page_kills_ppro(pfn))) {
+		ClearPageReserved(page);
+		set_bit(PG_highmem, &page->flags);
+		set_page_count(page, 1);
+		__free_page(page);
+		totalhigh_pages++;
+	} else
 		SetPageReserved(page);
-		return;
-	}
-	
-	if (bad_ppro && page_kills_ppro(pfn)) {
-		SetPageReserved(page);
-		return;
-	}
-	
-	ClearPageReserved(page);
-	set_bit(PG_highmem, &page->flags);
-	atomic_set(&page->count, 1);
-	__free_page(page);
-	totalhigh_pages++;
 }
 #endif /* CONFIG_HIGHMEM */
 
Signature · 4 lines
J.A. Magallon <[email protected]>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.1 (Cooker) for i586
Linux 2.4.21-pre3-jam2 (gcc 3.2.1 (Mandrake Linux 9.1 3.2.1-2mdk))