Skip to contentSkip to conversation

Stop APM as module from oopsing

PATCH Applied Daniel Ritz 2 participants 2 messages Jan 4, 2003 – Jan 6, 2003

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Stop APM as module from oopsing

trivial fix to stop APM from oopsing when compiled as module. against 2.5.54bk1. please apply.

beep
-daniel

arch/i386/kernel/apm.c +1 -1
@@ -718,7 +718,7 @@
  *	same format.
  */
 
-static int __init apm_driver_version(u_short *val)
+static int apm_driver_version(u_short *val)
 {
 	u32	eax;
 
#1 lore raw
Quoted 3 lines · Daniel Ritz

trivial fix to stop APM from oopsing when compiled as module. against 2.5.54bk1. please apply.

Hmm.. I think this is potentially a bug even for non-modular builds, since apm_driver_version() is called from the APM thread, and as such it might in theory (although probably not in practice) run after the init sequence even when compiled in.

Applied, with modified checkin comments.

Linus