Skip to contentSkip to conversation

include order for i2c-amd8111

PATCH Pavel Machek 4 participants 4 messages Jan 5, 2003 – Jan 10, 2003

Subsystems (2)
I2C subsystem host drivers I2C/smbus controller drivers for pc
lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

Hi!

It seems all linux then all asm is prefered order...
Pavel

drivers/i2c/busses/i2c-amd8111.c +1 -1
@@ -11,7 +11,6 @@
 #include <linux/version.h>
 #include <linux/module.h>
 #include <linux/pci.h>
-#include <asm/io.h>
 #include <linux/kernel.h>
 #include <linux/stddef.h>
 #include <linux/sched.h>

@@ -19,6 +18,7 @@
 #include <linux/init.h>
 #include <linux/i2c.h>
 #include <linux/delay.h>
+#include <asm/io.h>
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR ("Vojtech Pavlik <[email protected]>");
Signature · 2 lines
Worst form of spam? Adding advertisment signatures ala sourceforge.net.
What goes next? Inserting advertisment *into* email?
#1 lore raw

In message <[email protected]> you write:

Quoted 4 lines

Hi!

It seems all linux then all asm is prefered order...
Pavel

Yes, but not for any great reason, AFAICT. I think this comes under the "too trivial" rule (ie. I'll accept it from the author, but not someone else).

Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

#2 lore raw
Quoted 9 lines · Rusty Russell

In message <[email protected]> you write:

Quoted 4 lines

Hi!

It seems all linux then all asm is prefered order...
Pavel

Yes, but not for any great reason, AFAICT. I think this comes under the "too trivial" rule (ie. I'll accept it from the author, but not someone else).

The author (me ;) definitely doesn't mind you applying the patch, but would prefer if the one who pushed the 8111 driver into the kernel (Pavel) would update it to the version found in lm_sensors 2.7.0 at the same time.

Thanks.

Signature · 2 lines
Vojtech Pavlik
SuSE Labs
#3 lore raw

Hi!

Quoted 9 lines
Quoted 4 lines
Quoted 2 lines

It seems all linux then all asm is prefered order...
> > Yes, but not for any great reason, AFAICT. I think this comes under

the "too trivial" rule (ie. I'll accept it from the author, but not someone else).

The author (me ;) definitely doesn't mind you applying the patch, but would prefer if the one who pushed the 8111 driver into the kernel (Pavel) would update it to the version found in lm_sensors 2.7.0 at the same time.

Do you think you can mail me that file?

Pavel

Signature · 2 lines
				Pavel
Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...