Skip to contentSkip to conversation

MAC and iptables-save

PATCH Fridtjof Busse 2 participants 2 messages Dec 27, 2002 – Jan 6, 2003 netfilter

lore
Share & tools
lore
#0 lore raw

Hi
"iptables-restore" doesn't work if "iptables-save" saved a rule with "-m mac --mac-source"
To reproduce this:

Create a rule:
iptables -A INPUT -i eth0 -m mac --mac-source ! 00:01:02:03:04:05 -j REJECT

Save this rule:
iptables-save > test.iptables

Load the ruleset:
iptables-restore test.iptables
iptables-restore v1.2.7a: Bad mac address !00:01:02:03:04:05' Try iptables-restore -h' or 'iptables-restore --help' for more

iptables-save doesn't add a space before it prints the mac-address, it looks like this:
-A INPUT -i wlan0 -m mac --mac !00:02:2D:5C:08:1B -j DROP

instead of:
-A INPUT -i wlan0 -m mac --mac ! 00:02:2D:5C:08:1B -j DROP

Fix attached, since this bug seems to be still in the CVS.

Signature · 3 lines
Fridtjof Busse
BOFH excuse #63:
not properly grounded, please bury computer
libipt_mac.c renamed from libipt_mac.c.orig +1 -1
@@ -90,7 +90,7 @@
 {
 	unsigned int i;
 
-	printf("%s%02X", invert ? "!" : "", macaddress[0]);
+	printf("%s %02X", invert ? "!" : "", macaddress[0]);
 	for (i = 1; i < ETH_ALEN; i++)
 		printf(":%02X", macaddress[i]);
 	printf(" ");
libip6t_mac.c renamed from libip6t_mac.c.orig +1 -1
@@ -90,7 +90,7 @@
 {
 	unsigned int i;
 
-	printf("%s%02X", invert ? "!" : "", macaddress[0]);
+	printf("%s %02X", invert ? "!" : "", macaddress[0]);
 	for (i = 1; i < ETH_ALEN; i++)
 		printf(":%02X", macaddress[i]);
 	printf(" ");
#1 lore raw
Quoted 3 lines · Fridtjof Busse

Hi
"iptables-restore" doesn't work if "iptables-save" saved a rule with "-m mac --mac-source"

thanks for reporting this bug. It has already been fixed in CVS for ipv4 mac, although slightly different than your solution.

I have now changed the ipv6 mac match, too.

Signature · 4 lines
- Harald Welte / [email protected]               http://www.gnumonks.org/
============================================================================
"If this were a dictatorship, it'd be a heck of a lot easier, just so long
 as I'm the dictator."  --  George W. Bush Dec 18, 2000