Skip to contentSkip to conversation

kallsyms prints wrong symbol names

PATCH New Petr Vandrovec 1 participant 1 message Jan 9, 2003

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kallsyms prints wrong symbol names

Hi Linus,

Since stem compression arrived to kallsyms table, we are printing name of symbol BEFORE one we want to print (and empty string for first symbol) because of we return buffer with copy of last name we skipped instead of 'name' variable as we did before. So one more pass through loop is required.

Without this patch my stack traces were really strange...

Thanks,
Petr Vandrovec [email protected]

kernel/kallsyms.c +1 -1
@@ -46,7 +46,7 @@
 		}
 
 		/* Grab name */
-		for (i = 0; i < best; i++) { 
+		for (i = 0; i < best + 1; i++) { 
 			unsigned prefix = *name++;
 			strncpy(namebuf + prefix, name, 127 - prefix);
 			name += strlen(name) + 1;