Skip to contentSkip to conversation

2.5.55: static compilation of mxser.c doesn't work

DISCUSSION Adrian Bunk 2 participants 3 messages Jan 10, 2003 – Jan 12, 2003 Char and misc drivers

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

Hi Arnaldo,

the 2.5 Linux kernel contains your patch

o mxser: add module_exit/module_init
This fixes the compilation problem in 2.5

This patch renames mxser_init to mxser_module_init causing a compile error when trying to compile this driver statically into the kernel since mxser_init is still called from drivers/char/tty_io.c.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#1 lore raw
Quoted 10 lines · Adrian Bunk

Hi Arnaldo,

the 2.5 Linux kernel contains your patch

o mxser: add module_exit/module_init
This fixes the compilation problem in 2.5

This patch renames mxser_init to mxser_module_init causing a compile error when trying to compile this driver statically into the kernel since mxser_init is still called from drivers/char/tty_io.c.

You should be able to kill the call from tty_io.c

author
#2 lore raw
Quoted 5 lines · Alan Cox
Quoted 4 lines · Adrian Bunk

Hi Arnaldo,

the 2.5 Linux kernel contains your patch

Quoted 8 lines
Quoted 6 lines

o mxser: add module_exit/module_init
This fixes the compilation problem in 2.5

This patch renames mxser_init to mxser_module_init causing a compile error when trying to compile this driver statically into the kernel since mxser_init is still called from drivers/char/tty_io.c.

You should be able to kill the call from tty_io.c

Unfortunately I don't have the hardware to test whether the driver actually works but the patch below fixes the compilation.

cu
Adrian

drivers/char/tty_io.c renamed from drivers/char/tty_io.c.old +0 -3
@@ -2372,9 +2372,6 @@
 	rs_8xx_init();
 #endif /* CONFIG_8xx */
 	pty_init();
-#ifdef CONFIG_MOXA_SMARTIO
-	mxser_init();
-#endif	
 #ifdef CONFIG_MOXA_INTELLIO
 	moxa_init();
 #endif