Skip to contentSkip to conversation

RPC match and conntrack modules v2.1

PATCH Ian Latter 2 participants 2 messages Jan 12, 2003 – Jan 13, 2003 netfilter

lore
Share & tools
lore

Ian Latter

author
#0 lore raw

Hi Harald,

I didn't get your gz attachment, but I reassembled your patch from
the mailling list archive.

I have done all bar the cache implementation. You may be right
about its usage (and hence its performance) but I'm not sure -- if NFS only does one RPC lookup per procedure then the ls data will be a packet per file in the expectation, not the decision making process, which will put it out of my hands ... I don't have the gear to test that particular scenario on hand.
I would like to apply the cache stuff, but it looked a little challenging
for the time I had available. I am also interested in combining the tcp and udp modules into a single module.
I have done a fair bit of work on its cleanliness since you last
saw it.

The file is on the ftp server -- it applies cleanly to 2.4.20. I think
you'll be much happier with that implementation (v2.2).

11572 Jan 12 21:08 pom-rpc-030112-01.tgz afd50da3f913ba860b69c74030b0a056 pom-rpc-030112-01.tgz

Let me know how you find it ...

----- Original Message -----

Quoted 62 lines

From: "Harald Welte" <[email protected]>
To: "Ian Latter" <[email protected]>
Subject: Re: [PATCH] RPC match and conntrack modules v2.1
Date: Sat, 11 Jan 2003 01:05:55 +0100

Quoted 2 lines · Ian Latter

Cool, thanks .. :-) I think there will be a lot of embedded firewall manufacturers that will enjoy this one ...

agreed :)

Quoted 10 lines

That's correct - there was no NAT built into record-rpc, not even in an old API. I wanted to make the module set complete by writing the corresponding NAT module(s) but I didn't get time. I might be re-inspired later in January if no one else picks it up -- the code should be almost identical to the RSH work module that I wrote, because the connection handling is quite similar ..... actually ... maybe it doesn't need a nat helper; the connections are all initiated from the client to the server, and the internal protocols aren't carrying payloads that need to be rewritten ... so as long as the nat stuff handles "related" streams sanely, then its probably ok ...

no problem, let's just ignore NAT for now.

Quoted 5 lines
Quoted 2 lines

See attached patch. Mostly CodingStyle updates (you seem to like 8 spaces instead of tab), but also a minor fix:

Cool ... could you resent it as a "zip" attachment ... my mail software decodes text attachments which will make all the tabs in your patch spaces again ...

well, here it is as .gz again. Strange mailclient you must be using...

Quoted 6 lines
Quoted 3 lines

btw: I'd really love to see the large chunk of code in the switch statement of the match() function in ipt_rpc.c be split up in seperate functions (thus reducing indentation and improving readability).

possibly could be ... the gumby way might be to do udp and tcp functions ... but a better way might be to pull out the rpc payload stuff .... I can take a look at that.

thanks.

Quoted 5 lines
Quoted 3 lines

I don't know, but I think esp. in cases where you have lots of rpc activity (NFS?, I'm not an RPC expert) it might be wise to use a slab cache for the 'struct request_p' list items.

I have not done that before, is there an example some place in the existing modules?

yes, it's done in ip_conntrack_core. see kmem_cache_create /
kmem_cache_alloc / and related functions. The idea is for the memory
management to keep a pool of memory chunks of the requested size around, in case they are heavily allocated / deallocated. We do this with struct sk_buff, struct ip_conntrack.

I'm not sure whether it's worth the effort in the rpc case... But if I'm not mistaken in NFSv2, every single file in an 'ls' is a seperate RPC request/reply, isn't it?

Quoted 3 lines
Quoted 2 lines

Please integrate my patch [and maybe consider my suggestions, that's of course up to you], test it and resubmit it.

hopefully be done by the end of the weekend/early next week.

Quoted 12 lines

no problem, I'll be off over the wekend anyway.

Quoted 2 lines
Quoted 1 line

Thanks!

Thanks for taking a look at it, and providing feed back ...

You're welcome.

Quoted 2 lines

--
Ian Latter

Signature · 1 line
- Harald Welte / [email protected]               http://www.gnumonks.org/

===========================================================================
=

Quoted 3 lines

"If this were a dictatorship, it'd be a heck of a lot easier, just so long
as I'm the dictator." -- George W. Bush Dec 18, 2000

--
Ian Latter
Internet and Networking Security Officer
Macquarie University

#1 lore raw
Quoted 4 lines · Ian Latter

Hi Harald,

I didn't get your gz attachment, but I reassembled your patch from
the mailling list archive.

sorry, I missed that attachment :(

Quoted 1 line

I have done all bar the cache implementation.

Thanks. let's consider the slab cache as optional optimization, if needed this can be changed later.

Quoted 2 lines

I have done a fair bit of work on its cleanliness since you last
saw it.

great. I'll apply your patch to CVS now.

Signature · 4 lines
- Harald Welte / [email protected]               http://www.gnumonks.org/
============================================================================
"If this were a dictatorship, it'd be a heck of a lot easier, just so long
 as I'm the dictator."  --  George W. Bush Dec 18, 2000