v850 obsolete params fix
PATCH 1/1 v850 obsolete params fix
Linus, please apply. No variable arrays anywhere.
Rusty.
Name: Make obsolete module parameters work with MODULE_SYMBOL_PREFIX
Author: Rusty Russell, Miles Bader
Status: Trivial
D: Since these are just symbols in the module object, they need symbol name
D: munging to find the symbol from the parameter name.
kernel/module.c +6 -6
@@ -679,19 +679,19 @@ static int obsolete_params(const char *nif (!kp)return -ENOMEM ; -DEBUGP ("Module %s has %u obsolete params\n" , name, num); -for (i =0 ; i < num; i++) -DEBUGP ("Param %i: %s type %s\n" , - num, obsparm[i].name, obsparm[i].type); -for (i =0 ; i < num; i++) { +char sym_name[128 +sizeof (MODULE_SYMBOL_PREFIX )]; + +snprintf (sym_name,sizeof (sym_name),"%s%s" , +MODULE_SYMBOL_PREFIX , obsparm[i].name); + kp[i].name = obsparm[i].name; kp[i].perm =000 ; kp[i].set = set_obsolete; kp[i].get =NULL ; obsparm[i].addr = (void *)find_local_symbol (sechdrs, symindex, strtab, - obsparm[i].name); + sym_name);if (!obsparm[i].addr) {printk ("%s: falsely claims to have parameter %s\n" , name, obsparm[i].name);
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.