Skip to contentSkip to conversation

driver_char_Kconfig bug (fwd)

PATCH In review Rusty Trivial Russell 2 participants 2 messages Jan 14, 2003 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 driver_char_Kconfig bug (fwd)

[ Roman, I've put you down as maintainer for *Kconfig*, so any trivial
patches which touch those files get CC'd to you. Is that OK? --RR ]

From: Adrian Bunk <[email protected]>

Hi Linus,

the issue described in the mail forwarded below is still present in 2.5.54. Please apply the simple patch supplied there.

TIA
Adrian

----- Forwarded message from Rusty Lynch <[email protected]> -----

Date: Fri, 22 Nov 2002 21:56:12 -0800
From: Rusty Lynch <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: [Tiny PATCH]driver/char/Kconfig bug

VT support requires drivers/char/keyboard.c which makes function calls implemented in drivers/input/, so that attempting to set CONFIG_INPUT=m or just not setting CONFIG_INPUT will result in a compile error if CONFIG_VT is on.

Here is a trivial patch against 2.5.49.

-rustyl

drivers/char/Kconfig renamed from drivers/char/Kconfig.orig +1 -0
@@ -6,6 +6,7 @@
 
 config VT
 	bool "Virtual terminal"
+	requires INPUT=y
 	---help---
 	  If you say Y here, you will get support for terminal devices with
 	  display and keyboard devices. These are called "virtual" because you
Signature · 2 lines
  Don't blame me: the Monkey is driving
  File: Adrian Bunk <[email protected]>: [Tiny PATCH]driver_char_Kconfig bug (fwd)
#1 lore raw

Hi,

Quoted 2 lines · Rusty Trivial Russell

[ Roman, I've put you down as maintainer for *Kconfig*, so any trivial
patches which touch those files get CC'd to you. Is that OK? --RR ]

No problem, although the individual entries are still owned by the maintainers, but I'm very interested how the config system is used.

bye, Roman