Dealing with 2.5.x subarch headers

Hi,

I am working on a module for 2.5.x. My module requires something like irq_vectors.h.
Due do previous messages about this and John Stultz' subarch cleanup patch (merged in 2.5.53), I finally added "-Iinclude/asm/mach-default" to gcc options.

Talking to John about a way to find an easy solution for module developers to get the good -I options, he proposed to add something like this to the Makefile.

#Subarch selection

mflags-$(CONFIG_X86_VOYAGER)    := -Iinclude/asm-i386/mach-voyager
mflags-$(CONFIG_X86_VISWS)      := -Iinclude/asm-i386/mach-visws
mflags-$(CONFIG_X86_NUMAQ)      := -Iinclude/asm-i386/mach-numaq
# default subarch .h files
mflags-y += -Iinclude/asm-i386/mach-default
CFLAGS += $(mflags-y)
AFLAGS += $(mflags-y)

I was wondering if a easiest way could be found. Forcing module developers to add something like this looks to much complicated for me.

The way the "asm" symbolic link hides kernel arch config looks pretty.
Maybe we could hide subarch config with a symbolic link pointing to the good asm/mach-xyz.

But the current i386 subarch organization requires to include both the generic asm-i386/mach-default and a specific asm-i386/mach-xyz (voyager or ...).

A solution could be to create a symbolic link "mach-specific" pointing the specific "mach-xyz" and then include both asm/mach-default and asm/mach-specific.
(Yes, it would require a few updates in all other archs which do not have any subarch).

Any simple idea ?
Maybe the subarch organization needs some more cleanups ?

Regards

Brice Goglin
==============================================
Ph.D Student
Laboratoire de l'Informatique du Parallélisme
ENS Lyon - France

You should avoid introducing all this.
Do the following

$ make -C path/to/kernel/src SUBDIRS=$PWD modules

That will do the trick, and you include the .config for the selected kernel.

Sam