Skip to contentSkip to conversation

OSS mpu401 exit fix

PATCH In review Daniel Ritz 2 participants 2 messages Jan 22, 2003 – Jan 28, 2003 Sound

lore
Share & tools
lore

Daniel Ritz

author
#0 lore raw

PATCH 1/1 OSS mpu401 exit fix

hello

who is 2.5 OSS maintainer?

if it's not removed then it should be at least stable. patch to fix module unload bug in mu401. io and irq can't be __initdata since they're used for the exit function as well...

rgds,
-daniel

===== sound/oss/mpu401.c 1.9 vs edited =====

sound/oss/mpu401.c +4 -4
@@ -1762,13 +1762,13 @@
 
 static struct address_info cfg;
 
-static int __initdata io = -1;
-static int __initdata irq = -1;
+static int io = -1;
+static int irq = -1;
 
 MODULE_PARM(irq, "i");
 MODULE_PARM(io, "i");
 
-int __init init_mpu401(void)
+static int __init init_mpu401(void)
 {
 	int ret;
 	/* Can be loaded either for module use or to provide functions

@@ -1785,7 +1785,7 @@
 	return 0;
 }
 
-void __exit cleanup_mpu401(void)
+static void __exit cleanup_mpu401(void)
 {
 	if (io != -1 && irq != -1) {
 		/* Check for use by, for example, sscape driver */
#1 lore raw
Quoted 3 lines · Daniel Ritz

hello

who is 2.5 OSS maintainer?

AFAIK it doesn't have one.