Skip to contentSkip to conversation

remove EXT2_MAX_BLOCK_SIZE

PATCH William Lee Irwin III 2 participants 3 messages Jan 22, 2003 ext2 file system

lore
Share & tools
lore

William Lee Irwin III

author
#0 lore raw

Remove 100% unused EXT2_MAX_BLOCK_SIZE.

 ext2_fs.h |    1 -
 1 files changed, 1 deletion(-)
include/linux/ext2_fs.h +0 -1
diff -urpN cleanup-2.5.59-3/include/linux/ext2_fs.h cleanup-2.5.59-4/include/linux/ext2_fs.h
@@ -90,7 +90,6 @@ static inline struct ext2_sb_info *EXT2_
  * Macro-instructions used to manage several block sizes
  */
 #define EXT2_MIN_BLOCK_SIZE		1024
-#define	EXT2_MAX_BLOCK_SIZE		4096
 #define EXT2_MIN_BLOCK_LOG_SIZE		  10
 #ifdef __KERNEL__
 # define EXT2_BLOCK_SIZE(s)		((s)->s_blocksize)
#1 lore raw

include/linux/ext2_fs.h static inline struct ext2_sb_info *EXT2_ · line 95

Quoted 13 lines · William Lee Irwin III

Remove 100% unused EXT2_MAX_BLOCK_SIZE.

diff -urpN cleanup-2.5.59-3/include/linux/ext2_fs.h cleanup-2.5.59-4/include/linux/ext2_fs.h

include/linux/ext2_fs.h +0 -1
@@ -90,7 +90,6 @@ static inline struct ext2_sb_info *EXT2_
  * Macro-instructions used to manage several block sizes
  */
 #define EXT2_MIN_BLOCK_SIZE		1024
-#define	EXT2_MAX_BLOCK_SIZE		4096
 #define EXT2_MIN_BLOCK_LOG_SIZE		  10
 #ifdef __KERNEL__
 # define EXT2_BLOCK_SIZE(s)		((s)->s_blocksize)

Actually, the correct fix is to check in ext2_read_super() whether the blocksize is larger than EXT2_MAX_BLOCK_SIZE like ext3 does, and maybe even fix up the code drift between that part of ext2_read_super() and ext3_read_super()...

Both ext2 and ext3 will in theory support a blocksize up to PAGE_SIZE, but nobody with access to a > 4kB PAGE_SIZE system has bothered to test whether it works, so EXT[23]_MAX_BLOCK_SIZE has not been increased. Any e2fsprogs from the last year or so will support larger blocksizes, but it has never been tested AFAIK.

Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/

author
#2 lore raw
Quoted 9 lines · Andreas Dilger

Actually, the correct fix is to check in ext2_read_super() whether the blocksize is larger than EXT2_MAX_BLOCK_SIZE like ext3 does, and maybe even fix up the code drift between that part of ext2_read_super() and ext3_read_super()...
Both ext2 and ext3 will in theory support a blocksize up to PAGE_SIZE, but nobody with access to a > 4kB PAGE_SIZE system has bothered to test whether it works, so EXT[23]_MAX_BLOCK_SIZE has not been increased. Any e2fsprogs from the last year or so will support larger blocksizes, but it has never been tested AFAIK.

Block sizes > 4K should be trivially testable on IA64. ISTR bcrl having patches to increase PAGE_CACHE_SIZE independently of PAGE_SIZE and repair ext2's assumptions, so they should also be testable that way.

-- wli