: CLASSIFY
Hi,
I've written the attached target a couple of days ago for someone else. It is used to classify packets for qdiscs by setting skb->priority. i haven't tested it myself but according to Abraham van der Merwe who cared to test it "works great".
I think other people might consider this useful, please consider for inclusion in patch-o-matic.
Regards,
Patrick
patch-o-matic/extra/CLASSIFY.patch +83 -0
@@ -0,0 +1,83 @@ +diff -urN linux-2.4.20-clean/include/linux/netfilter_ipv4/ipt_CLASSIFY.h linux-2.4.20_nfclassify/include/linux/netfilter_ipv4/ipt_CLASSIFY.h +--- linux-2.4.20-clean/include/linux/netfilter_ipv4/ipt_CLASSIFY.h 1970-01-01 01:00:00.000000000 +0100 ++++ linux-2.4.20_nfclassify/include/linux/netfilter_ipv4/ipt_CLASSIFY.h 2003-01-25 02:11:35.000000000 +0100 +@@ -0,0 +1,8 @@ ++#ifndef _IPT_CLASSIFY_H ++#define _IPT_CLASSIFY_H ++ ++struct ipt_classify_target_info { ++ unsigned int priority; ++}; ++ ++#endif /*_IPT_CLASSIFY_H */ +diff -urN linux-2.4.20-clean/net/ipv4/netfilter/ipt_CLASSIFY.c linux-2.4.20_nfclassify/net/ipv4/netfilter/ipt_CLASSIFY.c +--- linux-2.4.20-clean/net/ipv4/netfilter/ipt_CLASSIFY.c 1970-01-01 01:00:00.000000000 +0100 ++++ linux-2.4.20_nfclassify/net/ipv4/netfilter/ipt_CLASSIFY.c 2003-01-25 02:09:36.000000000 +0100 +@@ -0,0 +1,67 @@ ++/* This is a module which is used for setting the skb->priority field of an skb for qdisc classification. */ ++#include <linux/module.h> ++#include <linux/skbuff.h> ++#include <linux/ip.h> ++#include <net/checksum.h> ++ ++#include <linux/netfilter_ipv4/ip_tables.h> ++#include <linux/netfilter_ipv4/ipt_CLASSIFY.h> ++ ++static unsigned int ++target(struct sk_buff **pskb, ++ unsigned int hooknum, ++ const struct net_device *in, ++ const struct net_device *out, ++ const void *targinfo, ++ void *userinfo) ++{ ++ const struct ipt_classify_target_info *clinfo = targinfo; ++ ++ if((*pskb)->priority != clinfo->priority) { ++ (*pskb)->priority = clinfo->priority; ++ (*pskb)->nfcache |= NFC_ALTERED; ++ } ++ return IPT_CONTINUE; ++} ++ ++static int ++checkentry(const char *tablename, ++ const struct ipt_entry *e, ++ void *targinfo, ++ unsigned int targinfosize, ++ unsigned int hook_mask) ++{ ++ if (targinfosize != IPT_ALIGN(sizeof(struct ipt_classify_target_info))) { ++ printk(KERN_WARNING "CLASSIFY: targinfosize %u != %Zu\n", ++ targinfosize, ++ IPT_ALIGN(sizeof(struct ipt_classify_target_info))); ++ return 0; ++ } ++ ++ if (strcmp(tablename, "mangle") != 0) { ++ printk(KERN_WARNING "CLASSIFY: can only be called from \"mangle\" table, not \"%s\"\n", tablename); ++ return 0; ++ } ++ ++ return 1; ++} ++ ++static struct ipt_target ipt_classify_reg ++= { { NULL, NULL }, "CLASSIFY", target, checkentry, NULL, THIS_MODULE }; ++ ++static int __init init(void) ++{ ++ if (ipt_register_target(&ipt_classify_reg)) ++ return -EINVAL; ++ ++ return 0; ++} ++ ++static void __exit fini(void) ++{ ++ ipt_unregister_target(&ipt_classify_reg); ++} ++ ++module_init(init); ++module_exit(fini); ++MODULE_LICENSE("GPL");
patch-o-matic/extra/CLASSIFY.patch.config.in +2 -0
@@ -0,0 +1,2 @@ + dep_tristate ' MARK target support' CONFIG_IP_NF_TARGET_MARK $CONFIG_IP_NF_MANGLE + dep_tristate ' CLASSIFY target support (EXPERIMENTAL)' CONFIG_IP_NF_TARGET_CLASSIFY $CONFIG_IP_NF_FILTER
patch-o-matic/extra/CLASSIFY.patch.help +5 -0
@@ -0,0 +1,5 @@ +Author: Patrick McHardy <[email protected]> +Status: untested + +This patch adds support for the CLASSIFY target which sets skb->priority. +Some qdiscs can use this value for classifying packets.
patch-o-matic/extra/CLASSIFY.patch.makefile +2 -0
@@ -0,0 +1,2 @@ +obj-$(CONFIG_IP_NF_TARGET_MIRROR) += ipt_MIRROR.o +obj-$(CONFIG_IP_NF_TARGET_CLASSIFY) += ipt_CLASSIFY.o
userspace/extensions/.CLASSIFY-test +3 -0
@@ -0,0 +1,3 @@ +#! /bin/sh +[ -f $KERNEL_DIR/net/ipv4/netfilter/ipt_CLASSIFY.c ] && echo CLASSIFY +
userspace/extensions/libipt_CLASSIFY.c +130 -0
130 lines not on this page · raw message
Quoted 1 line · --- Patrick McHardy
Hi,
Hi Patrick,
Quoted 5 lines
I've written the attached target a couple of days ago for someone else.
It is used to classify packets for qdiscs by settingskb->priority.
You might consider using bugzilla to submit your patch as an enhancement, as I believe this is what Harald now prefers.
https://bugzilla.netfilter.org/
=====
Kevin C. McConnell --RHCE-- <Red Hat Certified Engineer>
__________________________________________________
Do you Yahoo!?
Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
http://mailplus.yahoo.com
Quoted 10 lines · Kevin McConnell
Quoted 6 lines · --- Patrick McHardy
I've written the attached target a couple of days ago for someone else.
It is used to classify packets for qdiscs by settingskb->priority.
Quoted 6 lines
You might consider using bugzilla to submit your patch as an enhancement, as I believe this is what Harald now prefers. https://bugzilla.netfilter.org/
I doubt that Harald would really prefer it that way, bugzilla is a bugtracker and this is the development list.
Bye,
Patrick
Quoted 4 lines · --- Patrick McHardy
I doubt that Harald would really prefer it that way, bugzilla is a
bugtracker
and this is the development list.
Oh, I thought that this would qualify as an
enhancement.
=====
Kevin C. McConnell --RHCE-- <Red Hat Certified Engineer>
__________________________________________________
Do you Yahoo!?
Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
http://mailplus.yahoo.com
Quoted 12 lines · Kevin McConnell
Quoted 1 line · --- Patrick McHardy
Hi,
Hi Patrick,
Quoted 5 lines
I've written the attached target a couple of days ago for someone else.
It is used to classify packets for qdiscs by settingskb->priority.
Quoted 4 lines
You might consider using bugzilla to submit your patch as an enhancement, as I believe this is what Harald now prefers.
https://bugzilla.netfilter.org/
No, sorry :)
To make it clear [maybe this should be on the website somewhere]:
- enhancements/patches for patch-o-matic per email to the devel list
- enhancement [new feature] requests and bugreports in bugzilla
Quoted 1 line
Kevin C. McConnell --RHCE-- <Red Hat Certified Engineer>
Signature · 5 lines
Live long and prosper - Harald Welte / [email protected] http://www.gnumonks.org/ ============================================================================ GCS/E/IT d- s-: a-- C+++ UL++++$ P+++ L++++$ E--- W- N++ o? K- w--- O- M- V-- PS+ PE-- Y+ PGP++ t++ 5-- !X !R tv-- b+++ DI? !D G+ e* h+ r% y+(*)