Skip to contentSkip to conversation

pci: make pci_direct_conf1 structure nonstatic

PATCH In review Andrey Panin 2 participants 2 messages Feb 4, 2003 PCI

lore
Share & tools
lore

Andrey Panin

author
#0 lore raw

PATCH 1/1 pci: make pci_direct_conf1 structure nonstatic

Hi,

this triial patch is needed to use pci access functions from i386/pci/direct.c by the visws pci code. To achieve this patch makes pci_direct_conf1 structure (which hold pci pointers of access functions) nonstatic. PCI id for SGI lithium hostbridge is added also.

SGI visws supports pci type 1 pci access, but needs different bus and irq enumeration logic.

Please consider applying.

Best regards.

Signature · 2 lines
Andrey Panin		| Embedded systems software developer
[email protected]	| PGP key: wwwkeys.pgp.net
arch/i386/pci/direct.c +1 -1
diff -urN -X /usr/share/dontdiff linux-2.5.59.vanilla/arch/i386/pci/direct.c linux-2.5.59/arch/i386/pci/direct.c
@@ -83,7 +83,7 @@
 		PCI_FUNC(devfn), where, size, value);
 }
 
-static struct pci_ops pci_direct_conf1 = {
+struct pci_ops pci_direct_conf1 = {
 	.read =		pci_conf1_read,
 	.write =	pci_conf1_write,
 };
include/linux/pci_ids.h +1 -0
diff -urN -X /usr/share/dontdiff linux-2.5.59.vanilla/include/linux/pci_ids.h linux-2.5.59/include/linux/pci_ids.h
@@ -844,6 +844,7 @@
 
 #define PCI_VENDOR_ID_SGI		0x10a9
 #define PCI_DEVICE_ID_SGI_IOC3		0x0003
+#define PCI_VENDOR_ID_SGI_LITHIUM	0x1002
 
 #define PCI_VENDOR_ID_ACC		0x10aa
 #define PCI_DEVICE_ID_ACC_2056		0x0000
#1 lore raw
Quoted 11 lines · Andrey Panin

Hi,

this triial patch is needed to use pci access functions from i386/pci/direct.c by the visws pci code. To achieve this patch makes pci_direct_conf1 structure (which hold pci pointers of access functions) nonstatic. PCI id for SGI lithium hostbridge is added also.

SGI visws supports pci type 1 pci access, but needs different bus and irq enumeration logic.

Please consider applying.

Linus usually only applies patches that have him in the To (or maybe Cc) line. It might also worth to send all the small patches as a series (i.e. [PATCH] bring visw back alive (1/10)) so he sees a grand goal)