Skip to contentSkip to conversation

2.4.21pre: ide_fix_driveid unresolved in usb-storage

PATCH In review Olaf Hering 2 participants 2 messages Feb 6, 2003 USB

lore
Share & tools
lore

Olaf Hering

author
#0 lore raw

PATCH 1/1 2.4.21pre: ide_fix_driveid unresolved in usb-storage

Hi,

drivers/usb/storage/isd200.c calls ide_fix_driveid() This function is only available when CONFIG_IDE is active.

drivers/usb/Config.in renamed from drivers/usb/Config.in.olh +1 -1
@@ -46,7 +46,7 @@ if [ "$CONFIG_USB" = "y" -o  "$CONFIG_US
       dep_mbool '    USB Mass Storage verbose debug' CONFIG_USB_STORAGE_DEBUG $CONFIG_USB_STORAGE
       dep_mbool '    Datafab MDCFE-B Compact Flash Reader support' CONFIG_USB_STORAGE_DATAFAB $CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL
       dep_mbool '    Freecom USB/ATAPI Bridge support' CONFIG_USB_STORAGE_FREECOM  $CONFIG_USB_STORAGE
-      dep_mbool '    ISD-200 USB/ATA Bridge support' CONFIG_USB_STORAGE_ISD200 $CONFIG_USB_STORAGE
+      dep_mbool '    ISD-200 USB/ATA Bridge support' CONFIG_USB_STORAGE_ISD200 $CONFIG_USB_STORAGE $CONFIG_IDE
       dep_mbool '    Microtech CompactFlash/SmartMedia support' CONFIG_USB_STORAGE_DPCM $CONFIG_USB_STORAGE
       dep_mbool '    HP CD-Writer 82xx support' CONFIG_USB_STORAGE_HP8200e $CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL
       dep_mbool '    SanDisk SDDR-09 (and other SmartMedia) support' CONFIG_USB_STORAGE_SDDR09 $CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL
Signature · 2 lines
A: No.
Q: Should I include quotations after my reply?
#1 lore raw
Quoted 2 lines · Olaf Hering

drivers/usb/storage/isd200.c calls ide_fix_driveid() This function is only available when CONFIG_IDE is active.

I know. I submitted a patch for this in September 2002:

http://marc.theaimsgroup.com/?l=linux-usb-devel&m=103305998718432&w=2

...which was rejected "until people make up their minds" about how ide_fix_driveid() should be implemented in various architectures:

http://marc.theaimsgroup.com/?l=linux-usb-devel&m=103310439026491&w=2

I've been meaning to remind Matt and Greg about this issue.

Signature · 1 line
Björn (not subscribed to lkml)